date:20231020

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix whitespace

2023-10-20 Thread fixeria

Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email )

Change subject: diameter_3gpp_ts29_273_swx.dia: Fix whitespace
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2966070ee1bd7709565ab7b568ae6f23a3b6954f
Gerrit-Change-Number: 34842
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Sat, 21 Oct 2023 04:44:09 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: ggsn: log start of test in SUT

2023-10-20 Thread fixeria

Attention is currently required from: osmith.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email )

Change subject: ggsn: log start of test in SUT
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa
Gerrit-Change-Number: 34839
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Sat, 21 Oct 2023 04:35:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp

2023-10-20 Thread fixeria

Attention is currently required from: osmith.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email )

Change subject: library: deduplicate f_logp
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Sat, 21 Oct 2023 04:35:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: write_queue: Fix Doxygen comment

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34695?usp=email )

Change subject: write_queue: Fix Doxygen comment
..

write_queue: Fix Doxygen comment

Change-Id: Ib2508411ae46e2456466beaae63d3f401e34d0d4
---
M src/core/write_queue.c
1 file changed, 10 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved




diff --git a/src/core/write_queue.c b/src/core/write_queue.c
index ffa7704..8fb73a6 100644
--- a/src/core/write_queue.c
+++ b/src/core/write_queue.c
@@ -147,7 +147,7 @@
queue->bfd.when &= ~OSMO_FD_WRITE;
 }
 
-/* Update write queue length & drop excess messages.
+/*! Update write queue length & drop excess messages.
  * \param[in] queue linked list header of message queue
  * \param[in] len new max. wqueue length
  * \returns Number of messages dropped.

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34695?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib2508411ae46e2456466beaae63d3f401e34d0d4
Gerrit-Change-Number: 34695
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libosmocore[master]: write_queue: Fix Doxygen comment

2023-10-20 Thread laforge

Attention is currently required from: arehbein.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34695?usp=email )

Change subject: write_queue: Fix Doxygen comment
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34695?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib2508411ae46e2456466beaae63d3f401e34d0d4
Gerrit-Change-Number: 34695
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:55:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: ASCI: Reject TERMINATION, if MS is not the originator

2023-10-20 Thread laforge

Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email )

Change subject: ASCI: Reject TERMINATION, if MS is not the originator
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe289920fa3ea50dd3e7d5c1371456dca9b72604
Gerrit-Change-Number: 34830
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:54:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-msc[master]: ASCI: Reject TERMINATION, if MS is not the originator

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email )

Change subject: ASCI: Reject TERMINATION, if MS is not the originator
..

ASCI: Reject TERMINATION, if MS is not the originator

Only the originator may terminate the VGCS/VBS call. This will not
happen in real life, because the UI of the MS should not allow
termination of a recevied VGCS call.

Change-Id: Ibe289920fa3ea50dd3e7d5c1371456dca9b72604
Related: OS#4854
---
M src/libmsc/msc_vgcs.c
1 file changed, 34 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve




diff --git a/src/libmsc/msc_vgcs.c b/src/libmsc/msc_vgcs.c
index 772a9e3..d3f2e0e 100644
--- a/src/libmsc/msc_vgcs.c
+++ b/src/libmsc/msc_vgcs.c
@@ -859,6 +859,21 @@
trans_free(trans);
 }

+/* Send TERMINATION REJECT to the calling/talking subscriber. */
+static void gcc_termination_reject(struct gsm_trans *trans, enum 
osmo_gsm44068_cause cause)
+{
+   uint8_t pdisc = (trans->type == TRANS_GCC) ? GSM48_PDISC_GROUP_CC : 
GSM48_PDISC_BCAST_CC;
+   int rc;
+
+   /* Send TERMINATION towards MS. */
+   rc = gsm44068_tx_termination(trans->msc_a, trans->gcc.uplink_bss,
+pdisc | (trans->transaction_id << 4),
+OSMO_GSM44068_MSGT_TERMINATION_REJECT,
+cause,  NULL, 0);
+   if (rc < 0)
+   LOG_GCC(trans, LOGL_ERROR, "Failed to send TERMINATION REJECT 
towards MS.\n");
+}
+
 /* Start inactivity timer.
  * This timer is used to terminate the call, if the radio connection to the 
caller gets lost. */
 static void start_inactivity_timer(struct gsm_trans *trans)
@@ -1112,6 +1127,11 @@
gcc_terminate_and_destroy(trans, 
OSMO_GSM44068_CAUSE_NORMAL_CALL_CLEARING);
break;
case VGCS_GCC_EV_USER_TERM:
+   if (!trans->gcc.uplink_originator) {
+   LOG_GCC(trans, LOGL_ERROR, "Termination by user, but it 
is not the originator.\n");
+   gcc_termination_reject(trans, 
OSMO_GSM44068_CAUSE_USER_NOT_ORIGINATOR);
+   break;
+   }
LOG_GCC(trans, LOGL_DEBUG, "Termination by user, destroying 
call.\n");
/* Send TERMINATE to the calling subscriber and destroy group 
call in all cells. */
gcc_terminate_and_destroy(trans, 
OSMO_GSM44068_CAUSE_NORMAL_CALL_CLEARING);

--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34830?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe289920fa3ea50dd3e7d5c1371456dca9b72604
Gerrit-Change-Number: 34830
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

2023-10-20 Thread laforge

Attention is currently required from: lynxis lazus, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:54:03 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in docker-playground[master]: ttcn3-epdg-test: Update config file to set up GTPv2C socket

2023-10-20 Thread laforge

Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email )

Change subject: ttcn3-epdg-test: Update config file to set up GTPv2C socket
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I05ae2d87e16cef9772bc5c3690f687e5ecbd5f51
Gerrit-Change-Number: 34834
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:54:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: ggsn: log start of test in SUT

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email )

Change subject: ggsn: log start of test in SUT
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa
Gerrit-Change-Number: 34839
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:52:51 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email )

Change subject: library: deduplicate f_logp
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:52:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-10-20 Thread laforge

Attention is currently required from: fixeria, jolly, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email )

Change subject: mobile: add support for Circuit Switched Data calls
..


Patch Set 4: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6
Gerrit-Change-Number: 34762
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly 
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: jolly 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:52:11 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in pysim[master]: pySim-shell: do not fail when EF.ICCID does not exist

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34768?usp=email )

Change subject: pySim-shell: do not fail when EF.ICCID does not exist
..

pySim-shell: do not fail when EF.ICCID does not exist

An eUICC that has no active eSIM profile does not have an ICCID. (The
reason for this is that EF.ICCID is part of the eSIM profile).
Unfortunately pySim-shell insists on reading the ICCID from EF.ICCID on
startup in order to use it as a lookup key for verify_adm later.

To solve the problem, let's add a try/except block around the section
where EF.ICCID is read. In case of failure we set the ICCID to None,

Related: OS#5636
Change-Id: I8d18c5073946c5a6bb1f93be0ce692a599f46f8c
---
M pySim-shell.py
1 file changed, 23 insertions(+), 2 deletions(-)

Approvals:
  osmith: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  laforge: Looks good to me, approved




diff --git a/pySim-shell.py b/pySim-shell.py
index afc7653..a79949c 100755
--- a/pySim-shell.py
+++ b/pySim-shell.py
@@ -244,8 +244,11 @@
 self.register_command_set(Ts10Commands())
 self.register_command_set(PySimCommands())

-self.lchan.select('MF/EF.ICCID', self)
-self.iccid = dec_iccid(self.lchan.read_binary()[0])
+try:
+self.lchan.select('MF/EF.ICCID', self)
+self.iccid = dec_iccid(self.lchan.read_binary()[0])
+except:
+self.iccid = None

 self.lchan.select('MF', self)
 rc = True

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8d18c5073946c5a6bb1f93be0ce692a599f46f8c
Gerrit-Change-Number: 34768
Gerrit-PatchSet: 2
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in pysim[master]: pySim-shell: do not fail when EF.ICCID does not exist

2023-10-20 Thread laforge

Attention is currently required from: dexter, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34768?usp=email )

Change subject: pySim-shell: do not fail when EF.ICCID does not exist
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8d18c5073946c5a6bb1f93be0ce692a599f46f8c
Gerrit-Change-Number: 34768
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:51:22 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libgtpnl[master]: Use struct gtp_addr for ms_addr and sgsn_addr

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email )

Change subject: Use struct gtp_addr for ms_addr and sgsn_addr
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34734?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ifc7e3b03a723fb544d1c7b789101102b2c27b60e
Gerrit-Change-Number: 34734
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:50:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libgtpnl[master]: README, debian/control: update URLs

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email )

Change subject: README, debian/control: update URLs
..

README, debian/control: update URLs

Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0
---
M README.md
M debian/control
2 files changed, 14 insertions(+), 5 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified




diff --git a/README.md b/README.md
index 5d3b5bf..95ad1ac 100644
--- a/README.md
+++ b/README.md
@@ -20,9 +20,9 @@

 You can clone from the official libgtpnl.git repository using

-   git clone git://git.osmocom.org/libgtpnl.git
+   git clone https://gitea.osmocom.org/cellular-infrastructure/libgtpnl

-There is a cgit interface at 
+Visiting the URL in a browser shows a web interface.

 Mailing List
 
diff --git a/debian/control b/debian/control
index a24564e..17a8649 100644
--- a/debian/control
+++ b/debian/control
@@ -12,9 +12,9 @@
pkg-config,
libmnl-dev
 Standards-Version: 3.9.8
-Vcs-Git: git://git.osmocom.org/libgtpnl.git
-Vcs-Browser: http://git.osmocom.org/gitweb?p=libgtpnl.git;a=summary
-Homepage: https://projects.osmocom.org/projects/openggsn
+Vcs-Git: https://gitea.osmocom.org/cellular-infrastructure/libgtpnl
+Vcs-Browser: https://gitea.osmocom.org/cellular-infrastructure/libgtpnl
+Homepage: https://osmocom.org/projects/linux-kernel-gtp-u/wiki/Libgtpnl

 Package: libgtpnl0
 Section: libs

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0
Gerrit-Change-Number: 34825
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libgtpnl[master]: include/linux/gtp.h: fix GTPA_MAX

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email )

Change subject: include/linux/gtp.h: fix GTPA_MAX
..

include/linux/gtp.h: fix GTPA_MAX

Apply same fix as done by Pablo in linux.git:
> Subtract one to __GTPA_MAX, otherwise GTPA_MAX is off by 2

Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa
---
M include/linux/gtp.h
1 file changed, 13 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  pablo: Looks good to me, approved




diff --git a/include/linux/gtp.h b/include/linux/gtp.h
index c525cb3..5d37b1c 100644
--- a/include/linux/gtp.h
+++ b/include/linux/gtp.h
@@ -28,6 +28,6 @@
GTPA_PAD,
__GTPA_MAX,
 };
-#define GTPA_MAX (__GTPA_MAX + 1)
+#define GTPA_MAX (__GTPA_MAX - 1)

 #endif /* _UAPI_LINUX_GTP_H_ */

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa
Gerrit-Change-Number: 34828
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pablo 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libgtpnl[master]: include/linux/gtp.h: sync with kernel header

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email )

Change subject: include/linux/gtp.h: sync with kernel header
..

include/linux/gtp.h: sync with kernel header

Make the file exactly the same as include/uapi/linux/gtp.h in
linux.git. GTPA_SGSN_ADDRESS is not used, but we decided to rather add
it and not have a diff.

Related: 
https://gerrit.osmocom.org/c/libgtpnl/+/34735/comment/909c69a6_2fe7781a/
Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594
---
M include/linux/gtp.h
1 file changed, 21 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved




diff --git a/include/linux/gtp.h b/include/linux/gtp.h
index 5d37b1c..3dcdb9e 100644
--- a/include/linux/gtp.h
+++ b/include/linux/gtp.h
@@ -1,10 +1,14 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
 #ifndef _UAPI_LINUX_GTP_H_
-#define _UAPI_LINUX_GTP_H__
+#define _UAPI_LINUX_GTP_H_
+
+#define GTP_GENL_MCGRP_NAME"gtp"

 enum gtp_genl_cmds {
GTP_CMD_NEWPDP,
GTP_CMD_DELPDP,
GTP_CMD_GETPDP,
+   GTP_CMD_ECHOREQ,

GTP_CMD_MAX,
 };
@@ -19,7 +23,8 @@
GTPA_LINK,
GTPA_VERSION,
GTPA_TID,   /* for GTPv0 only */
-   GTPA_PEER_ADDRESS,
+   GTPA_PEER_ADDRESS,  /* Remote GSN peer, either SGSN or GGSN */
+#define GTPA_SGSN_ADDRESS GTPA_PEER_ADDRESS /* maintain legacy attr name */
GTPA_MS_ADDRESS,
GTPA_FLOW,
GTPA_NET_NS_FD,

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594
Gerrit-Change-Number: 34829
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libgtpnl[master]: configure: add --enable-werror

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email )

Change subject: configure: add --enable-werror
..

configure: add --enable-werror

Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a
---
M configure.ac
1 file changed, 28 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/configure.ac b/configure.ac
index e7d9888..a16f40b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -53,6 +53,25 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi

+AC_ARG_ENABLE(werror,
+   [AS_HELP_STRING(
+   [--enable-werror],
+   [Turn all compiler warnings into errors, with exceptions:
+a) deprecation (allow upstream to mark deprecation without 
breaking builds);
+b) "#warning" pragmas (allow to remind ourselves of errors 
without breaking builds)
+   ]
+   )],
+   [werror=$enableval], [werror="no"])
+if test x"$werror" = x"yes"
+then
+   WERROR_FLAGS="-Werror"
+   WERROR_FLAGS+=" -Werror=implicit-int -Werror=int-conversion 
-Werror=old-style-definition"
+   WERROR_FLAGS+=" -Wno-error=deprecated 
-Wno-error=deprecated-declarations"
+   WERROR_FLAGS+=" -Wno-error=cpp" # "#warning"
+   CFLAGS="$CFLAGS $WERROR_FLAGS"
+   CPPFLAGS="$CPPFLAGS $WERROR_FLAGS"
+fi
+
 AC_SUBST([CPPFLAGS])
 AC_SUBST([CFLAGS])
 AC_CONFIG_FILES([Makefile src/Makefile include/Makefile 
include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc])

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a
Gerrit-Change-Number: 34827
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libgtpnl[master]: configure: regular_C(PP)FLAGS -> C(PP)FLAGS

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email )

Change subject: configure: regular_C(PP)FLAGS -> C(PP)FLAGS
..

configure: regular_C(PP)FLAGS -> C(PP)FLAGS

Make it consistent with other Osmocom projects by removing special
naming for CFLAGS and CPPFLAGS. Otherwise the arguments we typically
add, such as --enable-sanitize which is already there, or
--enable-werror which I'll add in the next patch, do not work without
further changes.

Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7
---
M Make_global.am
M configure.ac
2 files changed, 24 insertions(+), 8 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve




diff --git a/Make_global.am b/Make_global.am
index f2cb36c..9a3d5b2 100644
--- a/Make_global.am
+++ b/Make_global.am
@@ -1,2 +1,2 @@
-AM_CPPFLAGS = ${regular_CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS}
-AM_CFLAGS = ${regular_CFLAGS} ${GCC_FVISIBILITY_HIDDEN}
+AM_CPPFLAGS = ${CPPFLAGS} -I${top_srcdir}/include ${LIBMNL_CFLAGS}
+AM_CFLAGS = ${CFLAGS} ${GCC_FVISIBILITY_HIDDEN}
diff --git a/configure.ac b/configure.ac
index eb35f57..e7d9888 100644
--- a/configure.ac
+++ b/configure.ac
@@ -9,6 +9,11 @@
 AC_CONFIG_HEADERS([config.h])
 AM_INIT_AUTOMAKE([foreign tar-pax no-dist-gzip dist-bzip2 1.6 subdir-objects])

+CPPFLAGS="$CPPFLAGS -D_FILE_OFFSET_BITS=64 -D_REENTRANT"
+CFLAGS="$CFLAGS -Wall -Waggregate-return -Wmissing-declarations \
+   -Wmissing-prototypes -Wshadow -Wstrict-prototypes \
+   -Wformat=2 -pipe"
+
 dnl include release helper
 RELMAKE='-include osmo-release.mk'
 AC_SUBST([RELMAKE])
@@ -48,12 +53,8 @@
CPPFLAGS="$CPPFLAGS -fsanitize=address -fsanitize=undefined"
 fi

-regular_CPPFLAGS="-D_FILE_OFFSET_BITS=64 -D_REENTRANT"
-regular_CFLAGS="-Wall -Waggregate-return -Wmissing-declarations \
-   -Wmissing-prototypes -Wshadow -Wstrict-prototypes \
-   -Wformat=2 -pipe"
-AC_SUBST([regular_CPPFLAGS])
-AC_SUBST([regular_CFLAGS])
+AC_SUBST([CPPFLAGS])
+AC_SUBST([CFLAGS])
 AC_CONFIG_FILES([Makefile src/Makefile include/Makefile 
include/libgtpnl/Makefile include/linux/Makefile tools/Makefile libgtpnl.pc])
 AC_OUTPUT(
contrib/libgtpnl.spec)

--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7
Gerrit-Change-Number: 34826
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libgtpnl[master]: include/linux/gtp.h: sync with kernel header

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email )

Change subject: include/linux/gtp.h: sync with kernel header
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34829?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Icf7b78e6655b6573c09c2eaa71d22ef6742b2594
Gerrit-Change-Number: 34829
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:42 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libgtpnl[master]: configure: add --enable-werror

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email )

Change subject: configure: add --enable-werror
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34827?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: Ife3716c667d2e9b3fcd94d3cdc044d594e7dab5a
Gerrit-Change-Number: 34827
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:10 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libgtpnl[master]: configure: regular_C(PP)FLAGS -> C(PP)FLAGS

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email )

Change subject: configure: regular_C(PP)FLAGS -> C(PP)FLAGS
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34826?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I11e9657fb0c038169bd414a6455044ff4a4709b7
Gerrit-Change-Number: 34826
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:49:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libgtpnl[master]: README, debian/control: update URLs

2023-10-20 Thread laforge

Attention is currently required from: osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email )

Change subject: README, debian/control: update URLs
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34825?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I0995f14657e3f58a46e9e357aa3e6baecc132fe0
Gerrit-Change-Number: 34825
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:48:46 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in pysim[master]: Use keyword argument for file description argument

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34814?usp=email )

Change subject: Use keyword argument for file description argument
..

Use keyword argument for file description argument

While our base classes (TransparentEF / LinFixedEF) always have the
dsecription as 4th argument after "fid, sfid, name", most of the derived
file-specific classes do not share that same argument order.

As seen in the bug fixed by previous Change-Id 
I7f32c9fd01094620b68b0e54536ecc6cdbe67903
this can have serious consequences.  Let's avoid using unnamed
(positional) arguments for the description text altogether.

Change-Id: Icfb3fd1bae038c54fa14a91aa9f75219d839968c
---
M pySim/ts_31_102.py
M pySim/ts_51_011.py
2 files changed, 73 insertions(+), 57 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved




diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index 5afa2ef..54ff4c8 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -1382,47 +1382,46 @@
 EF_Keys('6f09', 0x09, 'EF.KeysPS',
 desc='Ciphering and Integrity Keys for PS domain'),
 EF_xPLMNwAcT('6f60', 0x0a, 'EF.PLMNwAcT',
- 'User controlled PLMN Selector with Access 
Technology', service=20),
+ desc='User controlled PLMN Selector with Access 
Technology', service=20),
 EF_HPPLMN(),
 EF_ACMmax(service=13),
 EF_UST(),
 CyclicEF('6f39', None, 'EF.ACM',
- 'Accumulated call meter', rec_len=(3, 3), service=13),
-TransparentEF('6f3e', None, 'EF.GID1', 'Group Identifier Level 1', 
service=17),
-TransparentEF('6f3f', None, 'EF.GID2', 'Group Identifier Level 2', 
service=18),
+ desc='Accumulated call meter', rec_len=(3, 3), 
service=13),
+TransparentEF('6f3e', None, 'EF.GID1', desc='Group Identifier 
Level 1', service=17),
+TransparentEF('6f3f', None, 'EF.GID2', desc='Group Identifier 
Level 2', service=18),
 EF_SPN(service=19),
 TransparentEF('6f41', None, 'EF.PUCT',
-  'Price per unit and currency table', size=(5, 5), 
service=13),
+  desc='Price per unit and currency table', size=(5, 
5), service=13),
 EF_CBMI(service=15),
 EF_ACC(sfid=0x06),
-EF_PLMNsel('6f7b', 0x0d, 'EF.FPLMN',
-   'Forbidden PLMNs', size=(12, None)),
+EF_PLMNsel('6f7b', 0x0d, 'EF.FPLMN', desc='Forbidden PLMNs', 
size=(12, None)),
 EF_LOCI(),
 EF_AD(),
 EF_CBMID(sfid=0x0e, service=29),
 EF_ECC(),
 EF_CBMIR(service=16),
 EF_PSLOCI(),
-EF_ADN('6f3b', None, 'EF.FDN', 'Fixed Dialling Numbers', 
service=[2, 89], ext=2),
+EF_ADN('6f3b', None, 'EF.FDN', desc='Fixed Dialling Numbers', 
service=[2, 89], ext=2),
 EF_SMS('6f3c', None, service=10),
 EF_MSISDN(service=21),
 EF_SMSP(service=12),
 EF_SMSS(service=10),
-EF_ADN('6f49', None, 'EF.SDN', 'Service Dialling Numbers', 
service=[4, 89], ext=3),
-EF_EXT('6f4b', None, 'EF.EXT2', 'Extension2 (FDN)', service=3),
-EF_EXT('6f4c', None, 'EF.EXT3', 'Extension2 (SDN)', service=5),
+EF_ADN('6f49', None, 'EF.SDN', desc='Service Dialling Numbers', 
service=[4, 89], ext=3),
+EF_EXT('6f4b', None, 'EF.EXT2', desc='Extension2 (FDN)', 
service=3),
+EF_EXT('6f4c', None, 'EF.EXT3', desc='Extension2 (SDN)', 
service=5),
 EF_SMSR(service=11),
 EF_ICI(service=9),
 EF_OCI(service=8),
 EF_ICT(service=9),
-EF_ICT('6f83', None, 'EF.OCT', 'Outgoing Call Timer', service=8),
-EF_EXT('6f4e', None, 'EF.EXT5', 'Extension5 (ICI/OCI/MSISDN)', 
service=44),
+EF_ICT('6f83', None, 'EF.OCT', desc='Outgoing Call Timer', 
service=8),
+EF_EXT('6f4e', None, 'EF.EXT5', desc='Extension5 
(ICI/OCI/MSISDN)', service=44),
 EF_CCP2(service=14),
 EF_eMLPP(service=24),
 EF_AAeM(service=25),
 # EF_Hiddenkey
-EF_ADN('6f4d', None, 'EF.BDN', 'Barred Dialling Numbers', 
service=6, ext=4),
-EF_EXT('6f55', None, 'EF.EXT4', 'Extension4 (BDN/SSC)', service=7),
+EF_ADN('6f4d', None, 'EF.BDN', desc='Barred Dialling Numbers', 
service=6, ext=4),
+EF_EXT('6f55', None, 'EF.EXT4', desc='Extension4 (BDN/SSC)', 
service=7),
 EF_CMI(service=6),
 EF_EST(service=[2, 6, 34, 35]),
 EF_ACL(service=35),
@@ -1430,52 +1429,52 @@
 EF_CNL(service=37),
 EF_START_HFN(),
 EF_THRESHOLD(),
-

[S] Change in pysim[master]: ts_31_102: Fix initialization of file size

2023-10-20 Thread laforge

laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34813?usp=email )

Change subject: ts_31_102: Fix initialization of file size
..

ts_31_102: Fix initialization of file size

We were using positional arguments when instantiating instances
of classes like EF_5GS3GPPLOCI with non-default names/fids/...

However, we got the argument order wrong and were passing the
description string in the position of the file size, which causes
exceptions like the following from pySim-trace:

Traceback (most recent call last):
  File "/home/laforge/projects/git/pysim/./pySim-trace.py", line 198, in 

tracer.main()
  File "/home/laforge/projects/git/pysim/./pySim-trace.py", line 125, in main
inst.process(self.rs)
  File "/home/laforge/projects/git/pysim/pySim/apdu/__init__.py", line 259, in 
process
self.processed = method(self.lchan)
  File "/home/laforge/projects/git/pysim/pySim/apdu/ts_102_221.py", line 152, 
in process_on_lchan
if self.cmd_dict['offset'] != 0 or self.lr < self.file.size[0]:
TypeError: '<' not supported between instances of 'int' and 'str'

Let's use named initializers for any arguments after the usual "fid, sfid, name"
initial arguments.

Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903
---
M pySim/ts_31_102.py
1 file changed, 33 insertions(+), 3 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index c7a58f1..5afa2ef 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -1331,10 +1331,10 @@
 # I'm looking at 31.102 R16.6
 EF_5GS3GPPLOCI(service=122),
 EF_5GS3GPPLOCI('4f02', 0x02, 'EF.5GSN3GPPLOCI',
-   '5GS non-3GPP location information', service=122),
+   desc='5GS non-3GPP location information', 
service=122),
 EF_5GS3GPPNSC(service=122),
 EF_5GS3GPPNSC('4f04', 0x04, 'EF.5GSN3GPPNSC',
-  '5GS non-3GPP Access NAS Security Context', 
service=122),
+  desc='5GS non-3GPP Access NAS Security Context', 
service=122),
 EF_5GAUTHKEYS(service=123),
 EF_UAC_AIC(service=126),
 EF_SUCI_Calc_Info(service=124),
@@ -1342,7 +1342,7 @@
 EF_SUPI_NAI(service=130),
 EF_Routing_Indicator(service=124),
 TransparentEF('4F0B', 0x0b, 'EF.URSP',
-  'UE Route Selector Policies per PLMN', service=132),
+  desc='UE Route Selector Policies per PLMN', 
service=132),
 EF_TN3GPPSNN(service=133),
 # Rel-17 additions below
 EF_CAG(service=137),

--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34813?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903
Gerrit-Change-Number: 34813
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: manawyrm 
Gerrit-MessageType: merged

[S] Change in pysim[master]: ts_31_102: Fix initialization of file size

2023-10-20 Thread laforge

Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34813?usp=email )

Change subject: ts_31_102: Fix initialization of file size
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34813?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7f32c9fd01094620b68b0e54536ecc6cdbe67903
Gerrit-Change-Number: 34813
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: manawyrm 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:47:57 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in pysim[master]: Use keyword argument for file description argument

2023-10-20 Thread laforge

Attention is currently required from: dexter.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34814?usp=email )

Change subject: Use keyword argument for file description argument
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34814?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Icfb3fd1bae038c54fa14a91aa9f75219d839968c
Gerrit-Change-Number: 34814
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:47:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

2023-10-20 Thread daniel

Attention is currently required from: arehbein, laforge.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email )

Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues
..


Patch Set 5:

(1 comment)

File src/core/gsmtap_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/d4de8de3_f6d6e4ca
PS5, Line 478:  osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", 
OSMO_IO_FD_MODE_READ_WRITE, _sink_ops, NULL);
This will leak iofds returned by osmo_iofd_setup().

Also having a read_cb() will cause (de-)allocations for each message, which 
will impact performance. Maybe the sink should stay a struct osmo_fd? The 
alternative would be to simply never read from that fd and just keep it open 
there so no ICMP errors are sent.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: pespin 
Gerrit-CC: laforge 
Gerrit-Attention: arehbein 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Fri, 20 Oct 2023 20:27:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: diameter_3gpp_ts29_273_swx.dia: Fix whitespace

2023-10-20 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email )


Change subject: diameter_3gpp_ts29_273_swx.dia: Fix whitespace
..

diameter_3gpp_ts29_273_swx.dia: Fix whitespace

Change-Id: I2966070ee1bd7709565ab7b568ae6f23a3b6954f
---
M dia/diameter_3gpp_ts29_273_swx.dia
1 file changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/42/34842/1

diff --git a/dia/diameter_3gpp_ts29_273_swx.dia 
b/dia/diameter_3gpp_ts29_273_swx.dia
index d6f91da..d6d446c 100644
--- a/dia/diameter_3gpp_ts29_273_swx.dia
+++ b/dia/diameter_3gpp_ts29_273_swx.dia
@@ -33,7 +33,6 @@
 @vendor 10415 3GPP

 @inherits diameter_gen_base_rfc6733
-
 @inherits diameter_3gpp_base
 @inherits diameter_3gpp_break_circles
 @inherits diameter_3gpp_ts29_212
@@ -113,7 +112,7 @@
*[ Supported-Features ]
*[ AVP ]

-;; 8.2.2.2 Push-Profile-Answer
+;; 8.2.2.2 Push-Profile-Answer
PPA ::= < Diameter Header: 305, PXY >
< Session-Id >
{ Auth-Session-State }

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34842?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2966070ee1bd7709565ab7b568ae6f23a3b6954f
Gerrit-Change-Number: 34842
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[S] Change in ...osmo-epdg[master]: Makefile: run 'rebar3 clean' upon make clean

2023-10-20 Thread pespin

pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email )


Change subject: Makefile: run 'rebar3 clean' upon make clean
..

Makefile: run 'rebar3 clean' upon make clean

Otherwise the diameter files generated during compile in include/ and
src/ are not removed.

Change-Id: I771860f965499bb754c13385819845ef23f33553
---
M Makefile
1 file changed, 13 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/41/34841/1

diff --git a/Makefile b/Makefile
index b2fe66f..5ef1f58 100644
--- a/Makefile
+++ b/Makefile
@@ -14,4 +14,5 @@
rebar3 eunit

 clean:
+   rebar3 clean
rm -rf _build/

--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34841?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I771860f965499bb754c13385819845ef23f33553
Gerrit-Change-Number: 34841
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[S] Change in libgtpnl[master]: include/linux/gtp.h: fix GTPA_MAX

2023-10-20 Thread pablo

Attention is currently required from: osmith.

pablo has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email )

Change subject: include/linux/gtp.h: fix GTPA_MAX
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/34828?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libgtpnl
Gerrit-Branch: master
Gerrit-Change-Id: I42a358fc795d0e593e2c5509dcfa6ffdbad3cbfa
Gerrit-Change-Number: 34828
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pablo 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 16:46:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master b...

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email )

Change subject: Makefile: Update titan.ProtocolModules.BSSMAP to new 
osmocom/master branch
..

Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master branch

The repository branches were rebased and rearranged, where now its master branch
follows upstream, and we keep an osmocom/master branch with our own
patches (Osmux, not aimed at upstream) which can then be rebased on top of 
master.

Related: OS#6011
Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94
---
M deps/Makefile
1 file changed, 15 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  osmith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified




diff --git a/deps/Makefile b/deps/Makefile
index bd6ce8a..c6031cb 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -89,7 +89,7 @@
 titan.ProtocolEmulations.SCCP_commit=  
f8a44f2cdef44d0c3adf787ab3184c293a9a58be
 titan.ProtocolModules.BSSAPP_v7.3.0_commit=R.2.A-4-g20cfaf8
 titan.ProtocolModules.BSSGP_v13.0.0_commit=
e97d92a8b66bec399babea52f593771b76cb175a
-titan.ProtocolModules.BSSMAP_commit=   
814c5d786ab633bce384eea99685f0e49a386172
+titan.ProtocolModules.BSSMAP_commit=   
4acb6ab5f058477f0b90c2da182d52054e3614b0
 titan.ProtocolModules.DNS_commit=  R.7.B
 titan.ProtocolModules.GRE_commit=  R.2.A-5-g654c446
 titan.ProtocolModules.GTP_v13.5.0_commit=  
54219599037626c675610d3a44433d01af264fbb

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94
Gerrit-Change-Number: 34823
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ttcn3-hacks[master]: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master b...

2023-10-20 Thread fixeria

Attention is currently required from: laforge, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email )

Change subject: Makefile: Update titan.ProtocolModules.BSSMAP to new 
osmocom/master branch
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94
Gerrit-Change-Number: 34823
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 13:34:38 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: LAPDm: Correctly count expiry of T200 during estabishment/release

2023-10-20 Thread pespin

Attention is currently required from: jolly.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email )

Change subject: LAPDm: Correctly count expiry of T200 during 
estabishment/release
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48
Gerrit-Change-Number: 34840
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 20 Oct 2023 13:23:14 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: LAPDm: Correctly count expiry of T200 during estabishment/release

2023-10-20 Thread fixeria

Attention is currently required from: jolly.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email )

Change subject: LAPDm: Correctly count expiry of T200 during 
estabishment/release
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48
Gerrit-Change-Number: 34840
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-Reviewer: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Attention: jolly 
Gerrit-Comment-Date: Fri, 20 Oct 2023 13:10:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: LAPDm: Correctly count expiry of T200 during estabishment/release

2023-10-20 Thread jolly

jolly has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email )


Change subject: LAPDm: Correctly count expiry of T200 during 
estabishment/release
..

LAPDm: Correctly count expiry of T200 during estabishment/release

After T200 expires N200+1 times, the link establishment or relase
fails. The counting must be performed prior check.

Related: OS#5970
Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48
---
M src/isdn/lapd_core.c
1 file changed, 17 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/40/34840/1

diff --git a/src/isdn/lapd_core.c b/src/isdn/lapd_core.c
index 6475cb0..5674c66 100644
--- a/src/isdn/lapd_core.c
+++ b/src/isdn/lapd_core.c
@@ -593,6 +593,8 @@
switch (dl->state) {
case LAPD_STATE_SABM_SENT:
/* 5.4.1.3 */
+   /* increment re-transmission counter */
+   dl->retrans_ctr++;
if (dl->retrans_ctr >= dl->n200_est_rel + 1) {
/* flush tx and send buffers */
lapd_dl_flush_tx(dl);
@@ -611,13 +613,13 @@
}
/* retransmit SABM command */
lapd_send_resend(dl);
-   /* increment re-transmission counter */
-   dl->retrans_ctr++;
/* restart T200 (PH-READY-TO-SEND) */
lapd_start_t200(dl);
break;
case LAPD_STATE_DISC_SENT:
/* 5.4.4.3 */
+   /* increment re-transmission counter */
+   dl->retrans_ctr++;
if (dl->retrans_ctr >= dl->n200_est_rel + 1) {
/* send MDL ERROR INIDCATION to L3 */
mdl_error(MDL_CAUSE_T200_EXPIRED, >lctx);
@@ -635,8 +637,6 @@
}
/* retransmit DISC command */
lapd_send_resend(dl);
-   /* increment re-transmission counter */
-   dl->retrans_ctr++;
/* restart T200 (PH-READY-TO-SEND) */
lapd_start_t200(dl);
break;

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34840?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf44e26420fc91312e7c8972a2f3ed475e42fc48
Gerrit-Change-Number: 34840
Gerrit-PatchSet: 1
Gerrit-Owner: jolly 
Gerrit-MessageType: newchange

[S] Change in osmo-ttcn3-hacks[master]: Makefile: Update titan.ProtocolModules.BSSMAP to new osmocom/master b...

2023-10-20 Thread osmith

Attention is currently required from: fixeria, laforge, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email )

Change subject: Makefile: Update titan.ProtocolModules.BSSMAP to new 
osmocom/master branch
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34823?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1ec7cb6f8fa5acaca6eb434ea9449119de078c94
Gerrit-Change-Number: 34823
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:57:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread osmith

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat
..

scripts/repo-install-test: fix sftp compat

When running scp, Debian 12 uses the SFTP protocol by default instead of
the legacy SCP protocol. For some reason, this means it doesn't create
the /repo-install-test directory inside QEMU:

  + … scp … -r scripts/repo-install-test root@127.0.0.1:/repo-install-test
  Warning: Permanently added '[127.0.0.1]:22793' (ED25519) to the list of known 
hosts.
  scp: realpath /repo-install-test: No such file
  scp: upload "/repo-install-test": path canonicalization failed
  scp: failed to upload directory scripts/repo-install-test to 
/repo-install-test

Changing to the legacy protocol with "scp -O" would make it work again,
but instead of doing that add the mkdir so it works with the new
protocol too.

Related: OS#6186
Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
---
M scripts/repo-install-test.sh
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified




diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index 246d5e5..98f0176 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -153,6 +153,7 @@
EOF

qemu_ssh rm -rf /repo-install-test/
+   qemu_ssh mkdir /repo-install-test
qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test"

TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread osmith

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat
..


Patch Set 2:

(1 comment)

File scripts/repo-install-test.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/34837/comment/18f95d05_d541e8af
PS2, Line 156:  qemu_ssh mkdir /repo-install-test
> You could probably do it in one command to save some time, but it's fine 
> otherwise. […]
Right, but not worth optimizing here. I find the current version slightly more 
readable.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:25:47 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix sveral wrong ElementIdentifier

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: GTPv2_Templates: Fix sveral wrong ElementIdentifier
..

GTPv2_Templates: Fix sveral wrong ElementIdentifier

Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1
---
M library/GTPv2_Templates.ttcn
1 file changed, 14 insertions(+), 5 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn
index 644728e..b306955 100644
--- a/library/GTPv2_Templates.ttcn
+++ b/library/GTPv2_Templates.ttcn
@@ -213,16 +213,16 @@
 }


-/* 8.5 */
+/* 8.6 */
 template (value) AccessPointName ts_GTP2C_APN(template (value) octetstring 
apn) := {
-   elementIdentifier := '48'O,
+   elementIdentifier := '47'O,
lengthIndicator := 0, /* overwritten */
instance := ''B,
spare := ''B,
aPN_Value := apn
 }
 template (present) AccessPointName tr_GTP2C_APN(template (present) octetstring 
apn) := {
-   elementIdentifier := '48'O,
+   elementIdentifier := '47'O,
lengthIndicator := ?,
instance := ?,
spare := ''B,
@@ -321,7 +321,7 @@

 /* 8.17 */
 template (value) RAT_Type ts_GTP2C_RatType(template (value) integer rat) := {
-   elementIdentifier := '53'O,
+   elementIdentifier := '52'O,
lengthIndicator := 0, /* overwritten */
instance := ''B,
spare := ''B,
@@ -329,7 +329,7 @@
additionalOctets := omit
 }
 template (present) RAT_Type tr_GTP2C_RatType(template (present) integer rat) 
:= {
-   elementIdentifier := '53'O,
+   elementIdentifier := '52'O,
lengthIndicator := ?,
instance := ?,
spare := ''B,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1
Gerrit-Change-Number: 34820
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite
..

Introduce EPDG_Tests testsuite

Relted: OS#6204
Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
---
M Makefile
A epdg/EPDG_Tests.cfg
A epdg/EPDG_Tests.default
A epdg/EPDG_Tests.ttcn
A epdg/gen_links.sh
A epdg/regen_makefile.sh
M library/DIAMETER_Templates.ttcn
M library/GSUP_Types.ttcn
8 files changed, 746 insertions(+), 9 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve




diff --git a/Makefile b/Makefile
index 0ed632f..51e51ed 100644
--- a/Makefile
+++ b/Makefile
@@ -22,6 +22,7 @@
dia2gsup \
fr \
fr-net \
+   epdg \
gbproxy \
ggsn_tests \
hlr \
diff --git a/epdg/EPDG_Tests.cfg b/epdg/EPDG_Tests.cfg
new file mode 100644
index 000..c164293
--- /dev/null
+++ b/epdg/EPDG_Tests.cfg
@@ -0,0 +1,19 @@
+[ORDERED_INCLUDE]
+# Common configuration, shared between test suites
+"../Common.cfg"
+# testsuite specific configuration, not expected to change
+"./EPDG_Tests.default"
+
+# Local configuration below
+
+[LOGGING]
+
+[TESTPORT_PARAMETERS]
+
+
+[MODULE_PARAMETERS]
+
+[MAIN_CONTROLLER]
+
+[EXECUTE]
+EPDG_Tests.control
diff --git a/epdg/EPDG_Tests.default b/epdg/EPDG_Tests.default
new file mode 100644
index 000..95b42e9
--- /dev/null
+++ b/epdg/EPDG_Tests.default
@@ -0,0 +1,8 @@
+[LOGGING]
+mtc.FileMask := LOG_ALL | TTCN_DEBUG | TTCN_MATCHING; // | DEBUG_ENCDEC;
+
+[TESTPORT_PARAMETERS]
+
+[MODULE_PARAMETERS]
+
+[EXECUTE]
diff --git a/epdg/EPDG_Tests.ttcn b/epdg/EPDG_Tests.ttcn
new file mode 100644
index 000..f93b77b
--- /dev/null
+++ b/epdg/EPDG_Tests.ttcn
@@ -0,0 +1,394 @@
+module EPDG_Tests {
+
+import from Misc_Helpers all;
+import from General_Types all;
+import from Osmocom_Types all;
+import from L3_Common all;
+
+import from IPA_Emulation all;
+import from GSUP_Emulation all;
+import from GSUP_Types all;
+
+import from DIAMETER_Types all;
+import from DIAMETER_Templates all;
+import from DIAMETER_Emulation all;
+
+import from GTPv2_Emulation all;
+
+modulepar {
+   /* our emulated GSUP strongswan (CEAI iface) */
+   charstring mp_gsup_local_ip := "127.0.0.100";
+   integer mp_gsup_local_port := 0;
+   charstring mp_gsup_remote_ip := "127.0.0.1";
+   integer mp_gsup_remote_port := 4222;
+
+   /* our emulated HSS */
+   charstring mp_swx_local_ip := "127.0.0.100";
+   integer mp_swx_local_port := 3868;
+
+   /* our emulated PGW (Diameter S6b) */
+   charstring mp_s6b_local_ip := "127.0.0.100";
+   integer mp_s6b_local_port := 3869;
+
+   /* our emulated PGW (GTPv2C S2b) */
+   charstring mp_s2b_local_ip := "127.0.0.100";
+   integer mp_s2b_local_port := GTP2C_PORT;
+   charstring mp_s2b_remote_ip := "127.0.0.1";
+   integer mp_s2b_remote_port := GTP2C_PORT;
+
+   charstring mp_diam_realm := "localdomain";
+}
+
+
+type component MTC_CT {
+   var DIAMETER_Emulation_CT vc_SWx;
+   port DIAMETER_PT SWx_UNIT;
+   port DIAMETEREM_PROC_PT SWx_PROC;
+
+   var DIAMETER_Emulation_CT vc_S6b;
+   port DIAMETER_PT S6b_UNIT;
+   port DIAMETEREM_PROC_PT S6b_PROC;
+
+   var GSUP_Emulation_CT vc_GSUP;
+   var IPA_Emulation_CT vc_GSUP_IPA;
+   port IPA_CTRL_PT GSUP_IPA_EVENT;
+
+   var GTPv2_Emulation_CT vc_GTP2;
+   port GTP2EM_PT TEID0;
+
+   timer g_Tguard;
+};
+
+private altstep as_Tguard() runs on MTC_CT {
+   [] g_Tguard.timeout {
+   Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Tguard 
timeout");
+   }
+}
+
+type component DIAMETER_ConnHdlr_CT extends DIAMETER_ConnHdlr {
+   port DIAMETER_Conn_PT DIAMETER_CLIENT;
+   port DIAMETEREM_PROC_PT DIAMETER_PROC_CLIENT;
+}
+
+function f_diam_connhldr_ct_main(hexstring imsi) runs on DIAMETER_ConnHdlr_CT {
+   var DIAMETER_ConnHdlr vc_conn_unused;
+   var PDU_DIAMETER msg;
+   var UINT32 ete_id;
+
+   f_diameter_expect_imsi(imsi);
+
+
+   while (true) {
+   alt {
+   [] DIAMETER_CLIENT.receive(PDU_DIAMETER:?) -> value msg {
+   DIAMETER.send(msg);
+   }
+   [] DIAMETER.receive(PDU_DIAMETER:?) -> value msg {
+   DIAMETER_CLIENT.send(msg);
+   }
+   [] 
DIAMETER_PROC_CLIENT.getcall(DIAMETEREM_register_eteid:{?,?}) -> param(ete_id, 
vc_conn_unused) {
+   DIAMETER_PROC.call(DIAMETEREM_register_eteid:{ete_id, 
self}) {
+   [] 
DIAMETER_PROC.getreply(DIAMETEREM_register_eteid:{?,?}) {};
+   }
+   
DIAMETER_PROC_CLIENT.reply(DIAMETEREM_register_eteid:{ete_id, vc_conn_unused});
+   }
+

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Fix tr_GSUP_IMSI params

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: GSUP_Types: Fix tr_GSUP_IMSI params
..

GSUP_Types: Fix tr_GSUP_IMSI params

Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892
---
M library/GSUP_Types.ttcn
1 file changed, 11 insertions(+), 2 deletions(-)

Approvals:
  osmith: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index ef98175..739dcbc 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -507,7 +507,7 @@
ies := ies
 }

-template GSUP_PDU tr_GSUP_IMSI(template GSUP_MessageType msgt := ?, template 
hexstring imsi) := {
+template (present) GSUP_PDU tr_GSUP_IMSI(template (present) GSUP_MessageType 
msgt := ?, template (present) hexstring imsi := ?) := {
msg_type := msgt,
ies := { tr_GSUP_IE_IMSI(imsi), * }
 }
@@ -715,7 +715,7 @@
}
 }

-template GSUP_IE tr_GSUP_IE_IMSI(template hexstring imsi) := {
+template (present) GSUP_IE tr_GSUP_IE_IMSI(template (present) hexstring imsi 
:= ?) := {
tag := OSMO_GSUP_IMSI_IE,
len := ?,
val := {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892
Gerrit-Change-Number: 34831
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: GTPv2_Templates: Several improvements to 
tr_GTP2C_CreateSessionReq
..

GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq

Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
---
M library/GTPv2_Templates.ttcn
1 file changed, 20 insertions(+), 11 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved




diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn
index e5022d8..753774d 100644
--- a/library/GTPv2_Templates.ttcn
+++ b/library/GTPv2_Templates.ttcn
@@ -740,38 +740,38 @@


 template (present) PDU_GTPCv2
-tr_GTP2C_CreateSessionReq(template (present) hexstring imsi) :=
+tr_GTP2C_CreateSessionReq(template (present) hexstring imsi := ?, template 
(present) octetstring apn := ?) :=
 tr_PDU_GTP2C(''O, ?, {
createSessionRequest := {
iMSI := tr_GTP2C_Imsi(imsi),
mSISDN := *,
mEI := *,
-   userLocationInfo := ?,
-   servingNetwork := ?,
-   rAT_Type := tr_GTP2C_RatType(6),
+   userLocationInfo := *,
+   servingNetwork := *,
+   rAT_Type := tr_GTP2C_RatType(?),
indication := *,
fullyQualifiedTEID := ?,
-   accessPointName := tr_GTP2C_APN('012a'O), // '*'
+   accessPointName := tr_GTP2C_APN(apn), // '*'
selectionMode := ?,
-   pDN_Type := ?,
+   pDN_Type := *,
pDN_AddressAllocation := ?,
-   maxAPN_Restriction := ?,
+   maxAPN_Restriction := *,
ambr := *,
linkedEPS_Bearer_ID := omit,
trustedWLANModeIndication := omit,
protocolConfigOptions := omit,
bearerContextGrouped := ?,
traceInformation := *,
-   recovery := omit,
+   recovery := *,
csid := omit,
-   uE_TimeZone := ?,
+   uE_TimeZone := *,
user_CSG_Information := omit,
-   chargingCharacteristics := ?,
+   chargingCharacteristics := *,
lDN := omit,
signallingPriorityIndication := *,
iP_Addr := omit,
portNumber := omit,
-   aPCO := omit,
+   aPCO := *,
trustedWLANAccessNetworkIdentifier := omit,
cNOperatorSelectionEntity := omit,
presenceReportingAreaInformation := omit,

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
Gerrit-Change-Number: 34822
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: Fix match of 15-digit IMSIs

2023-10-20 Thread pespin

pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: GTPv2: Fix match of 15-digit IMSIs
..

GTPv2: Fix match of 15-digit IMSIs

15-digit IMSIs are len(imsi)=15, but decoded messages are
octet-aligned, hence the hexstring in messages is len(imsi)=16,
where the last hex char is a padding 'F'H.

* Make sure IMSIs stored in GTPv2_Emulation are padded to 16 digits (8
  octets) to process matches easily.
* Update tr_ template to transparently adapt passed hexstrings to match
  the octet-aligned value received from the wire.

Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e
---
M library/GTPv2_Emulation.ttcn
M library/GTPv2_Templates.ttcn
M library/Osmocom_Types.ttcn
3 files changed, 35 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  osmith: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve




diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn
index 571da4e..736dd03 100644
--- a/library/GTPv2_Emulation.ttcn
+++ b/library/GTPv2_Emulation.ttcn
@@ -602,6 +602,10 @@
 };

 function f_gtp2_register_imsi(hexstring imsi) runs on GTP2_ConnHdlr {
+   /* 15-digit IMSIs are len(imsi)=15, but decoded messages are
+* octet-aligned, hence the hexstring in messages is len(imsi)=16, where
+* the last hex char is a padding 'F'H */
+   imsi := f_pad_bcd_number(imsi);
GTP2_PROC.call(GTP2EM_register_imsi:{imsi}) {
[] GTP2_PROC.getreply(GTP2EM_register_imsi:{imsi});
}
diff --git a/library/GTPv2_Templates.ttcn b/library/GTPv2_Templates.ttcn
index b306955..e5022d8 100644
--- a/library/GTPv2_Templates.ttcn
+++ b/library/GTPv2_Templates.ttcn
@@ -126,7 +126,7 @@
lengthIndicator := ?,
instance := ?,
spare := ''B,
-   iMSI_Value := imsi
+   iMSI_Value := f_pad_bcd_number_tmpl(imsi)
 }

 template (present) MSISDN ts_GTP2C_msisdn(template (present) hexstring msisdn) 
:= {
diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn
index ef55583..d034a74 100644
--- a/library/Osmocom_Types.ttcn
+++ b/library/Osmocom_Types.ttcn
@@ -261,6 +261,18 @@
}
 }

+function f_pad_bcd_number_tmpl(template hexstring inp) return template 
hexstring {
+   if (istemplatekind(inp, "omit")) {
+   return omit;
+   } else if (istemplatekind(inp, "*")) {
+   return *;
+   } else if (istemplatekind(inp, "?")) {
+   return ?;
+   } else {
+   return f_pad_bcd_number(valueof(inp));
+   }
+}
+
 /* like L1SAP_IS_PACKET_RACH */
 function ra_is_ps(OCT1 ra) return boolean {
if ((ra and4b 'F0'O == '70'O) and (ra and4b '0F'O != '0F'O)) {

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e
Gerrit-Change-Number: 34821
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread pespin

Attention is currently required from: fixeria, laforge, lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite
..


Patch Set 7: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 7
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:24:34 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread pespin

Attention is currently required from: osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat
..


Patch Set 2: Code-Review+2

(1 comment)

File scripts/repo-install-test.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/34837/comment/f296bbec_e12ba1db
PS2, Line 156:  qemu_ssh mkdir /repo-install-test
You could probably do it in one command to save some time, but it's fine 
otherwise.
qemu_ssh /bin/sh -c "rm -rf /repo-install-test/ && mkdir /repo-install-test"



--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:23:10 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread osmith

Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite
..


Patch Set 7: Code-Review+1

(5 comments)

File epdg/EPDG_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/65775eb5_d7308a17
PS6, Line 19: swtrongswan
> strongswan
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/543cc28c_1132fd10 
PS6, Line 216: watchdong
> watchdog
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/42a264dd_aba76e80
PS6, Line 231:  /* TODO: maybe use, set to true */
> the comment? yes, it's for next stages.
Ack


File epdg/gen_links.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/e0087b88_0877315d
PS6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn 
SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"
> commented out FILES here looks like left-overs that should be removed?
Done


File library/DIAMETER_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/1c577b62_63eef414
PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) 
/* Optional */
> I think it's fine for now, it helps people find the related templates/types.
Ack



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 7
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:21:29 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith 
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in osmo-ttcn3-hacks[master]: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req

2023-10-20 Thread pespin

Attention is currently required from: lynxis lazus, pespin.

Hello Jenkins Builder, fixeria, lynxis lazus, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req
..

epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req

Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4
---
M epdg/EPDG_Tests.ttcn
1 file changed, 84 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/33/34833/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4
Gerrit-Change-Number: 34833
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add EDPG_Tunnel messages

2023-10-20 Thread pespin

Attention is currently required from: fixeria, lynxis lazus, osmith, pespin.

Hello Jenkins Builder, fixeria, lynxis lazus, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by osmith, Verified+1 by Jenkins Builder


Change subject: GSUP_Types: Add EDPG_Tunnel messages
..

GSUP_Types: Add EDPG_Tunnel messages

Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
---
M library/GSUP_Types.ttcn
1 file changed, 40 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/32/34832/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
Gerrit-Change-Number: 34832
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Fix tr_GSUP_IMSI params

2023-10-20 Thread pespin

Attention is currently required from: fixeria, lynxis lazus, pespin.

Hello Jenkins Builder, fixeria, lynxis lazus, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: GSUP_Types: Fix tr_GSUP_IMSI params
..

GSUP_Types: Fix tr_GSUP_IMSI params

Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892
---
M library/GSUP_Types.ttcn
1 file changed, 11 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/31/34831/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34831?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifeff47d35df53f4238bc1556bdee037e62e9d892
Gerrit-Change-Number: 34831
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq

2023-10-20 Thread pespin

Hello Jenkins Builder, fixeria, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: GTPv2_Templates: Several improvements to 
tr_GTP2C_CreateSessionReq
..

GTPv2_Templates: Several improvements to tr_GTP2C_CreateSessionReq

Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
---
M library/GTPv2_Templates.ttcn
1 file changed, 20 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/22/34822/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34822?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6dd8cddcb986969d713ed7975a55cb31ab47c499
Gerrit-Change-Number: 34822
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: GTPv2: Fix match of 15-digit IMSIs

2023-10-20 Thread pespin

Attention is currently required from: pespin.

Hello Jenkins Builder, fixeria, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: GTPv2: Fix match of 15-digit IMSIs
..

GTPv2: Fix match of 15-digit IMSIs

15-digit IMSIs are len(imsi)=15, but decoded messages are
octet-aligned, hence the hexstring in messages is len(imsi)=16,
where the last hex char is a padding 'F'H.

* Make sure IMSIs stored in GTPv2_Emulation are padded to 16 digits (8
  octets) to process matches easily.
* Update tr_ template to transparently adapt passed hexstrings to match
  the octet-aligned value received from the wire.

Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e
---
M library/GTPv2_Emulation.ttcn
M library/GTPv2_Templates.ttcn
M library/Osmocom_Types.ttcn
3 files changed, 35 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/21/34821/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34821?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie2f316ccb5bc69ec15e861616de4fd5babc4004e
Gerrit-Change-Number: 34821
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread pespin

Attention is currently required from: fixeria, laforge, lynxis lazus, osmith.

Hello Jenkins Builder, fixeria, laforge, lynxis lazus, osmith,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email

to look at the new patch set (#7).

The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder


Change subject: Introduce EPDG_Tests testsuite
..

Introduce EPDG_Tests testsuite

Relted: OS#6204
Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
---
M Makefile
A epdg/EPDG_Tests.cfg
A epdg/EPDG_Tests.default
A epdg/EPDG_Tests.ttcn
A epdg/gen_links.sh
A epdg/regen_makefile.sh
M library/DIAMETER_Templates.ttcn
M library/GSUP_Types.ttcn
8 files changed, 746 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/78/34778/7
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 7
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: laforge 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Templates: Fix sveral wrong ElementIdentifier

2023-10-20 Thread pespin

Attention is currently required from: pespin.

Hello Jenkins Builder, fixeria,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email

to look at the new patch set (#2).

The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder

The change is no longer submittable: Verified is unsatisfied now.


Change subject: GTPv2_Templates: Fix sveral wrong ElementIdentifier
..

GTPv2_Templates: Fix sveral wrong ElementIdentifier

Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1
---
M library/GTPv2_Templates.ttcn
1 file changed, 14 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/20/34820/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34820?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Idea191cedd78768a3fef7a9958fda5c27f2859e1
Gerrit-Change-Number: 34820
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-MessageType: newpatchset

[S] Change in osmo-ttcn3-hacks[master]: ggsn: log start of test in SUT

2023-10-20 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email )


Change subject: ggsn: log start of test in SUT
..

ggsn: log start of test in SUT

Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa
---
M ggsn_tests/GGSN_Tests.ttcn
1 file changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/39/34839/1

diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn
index 6cc9732..5b1f7a1 100644
--- a/ggsn_tests/GGSN_Tests.ttcn
+++ b/ggsn_tests/GGSN_Tests.ttcn
@@ -292,6 +292,8 @@
f_init_vty();
f_vty_set_gpdu_txseq(use_gtpu_txseq);
f_vty_enable_echo_interval(g_use_echo_intval);
+   /* Emit a marker to appear in the SUT's own logging 
output */
+   f_logp(GGSNVTY, testcasename() & "() start");
} else if (m_ggsn_impl == GGSN_IMPL_OPEN5GS) {
f_init_diameter(testcasename());
}

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34839?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2baccc2b49e8bcbf0d1ca6dae41624b2d18fc0fa
Gerrit-Change-Number: 34839
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

[M] Change in osmo-ttcn3-hacks[master]: library: deduplicate f_logp

2023-10-20 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email )


Change subject: library: deduplicate f_logp
..

library: deduplicate f_logp

Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
---
M bsc/BSC_Tests.ttcn
M hnbgw/HNBGW_Tests.ttcn
M hnodeb/HNB_Tests.ttcn
M library/Osmocom_VTY_Functions.ttcn
M smlc/SMLC_Tests.ttcn
M upf/UPF_Tests.ttcn
6 files changed, 19 insertions(+), 42 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/38/34838/1

diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index 426109a..57b44e0 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -1129,16 +1129,6 @@
  "sccp-timer iar " & int2str(g_bsc_sccp_timer_iar)});
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   if (pt.checkstate("Mapped")) {
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & 
log_msg);
-   }
-}
-
 private function f_sysinfo_seen(integer rsl_idx, RSL_Message rsl) runs on 
test_CT
 {
if (rsl_idx >= lengthof(g_system_information)) {
diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index c3849b8..4afb8dd 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -349,14 +349,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 function f_init_vty(charstring id := "foo") runs on test_CT {
if (HNBGWVTY.checkstate("Mapped")) {
/* skip initialization if already executed once */
diff --git a/hnodeb/HNB_Tests.ttcn b/hnodeb/HNB_Tests.ttcn
index 6d1ddc5..df7a04c 100644
--- a/hnodeb/HNB_Tests.ttcn
+++ b/hnodeb/HNB_Tests.ttcn
@@ -95,14 +95,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 function f_init_vty(charstring id := "foo") runs on test_CT {
if (HNBVTY.checkstate("Mapped")) {
/* skip initialization if already executed once */
diff --git a/library/Osmocom_VTY_Functions.ttcn 
b/library/Osmocom_VTY_Functions.ttcn
index a448b8b..3dd0429 100644
--- a/library/Osmocom_VTY_Functions.ttcn
+++ b/library/Osmocom_VTY_Functions.ttcn
@@ -363,4 +363,14 @@
mtc.stop;
 }

+public function f_logp(TELNETasp_PT pt, charstring log_msg)
+{
+   // log on TTCN3 log output
+   log(log_msg);
+   // log in stderr log
+   if (pt.checkstate("Mapped")) {
+   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & 
log_msg);
+   }
+}
+
 }
diff --git a/smlc/SMLC_Tests.ttcn b/smlc/SMLC_Tests.ttcn
index 5324d1c..2a50666 100644
--- a/smlc/SMLC_Tests.ttcn
+++ b/smlc/SMLC_Tests.ttcn
@@ -156,14 +156,6 @@
}
 }

-private function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 /* global initialization function
  * \param nr_bts Number of BTSs we should start/bring up
  * \param handler_mode Start an RSL_Emulation_CT component (true) or not 
(false).
diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn
index 7dc01bb..140e81b 100644
--- a/upf/UPF_Tests.ttcn
+++ b/upf/UPF_Tests.ttcn
@@ -68,14 +68,6 @@
}
 }

-friend function f_logp(TELNETasp_PT pt, charstring log_msg)
-{
-   // log on TTCN3 log output
-   log(log_msg);
-   // log in stderr log
-   f_vty_transceive(pt, "logp lglobal notice TTCN3 f_logp(): " & log_msg);
-}
-
 private function f_get_name_val(out charstring val, charstring str, charstring 
name, charstring sep := ":", charstring delim := " ") return boolean {
var charstring labl := name & sep;
var integer namepos := f_strstr(str, labl);

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34838?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie84a8a75e9f162fcbef0d07d0bc75e47a5303fa3
Gerrit-Change-Number: 34838
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread pespin

Attention is currently required from: fixeria, lynxis lazus, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite
..


Patch Set 6:

(2 comments)

File epdg/EPDG_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/13abdc4f_cb402053
PS6, Line 231:  /* TODO: maybe use, set to true */
> kept intentionally?
the comment? yes, it's for next stages.


File library/DIAMETER_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/ce02fb50_9b7f3bec
PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) 
/* Optional */
> do you want to keep the // lines in addition to the TODO comment below?
I think it's fine for now, it helps people find the related templates/types.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: osmith 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 12:15:38 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith 
Gerrit-MessageType: comment

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread fixeria

Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email )

Change subject: scripts/repo-install-test: fix sftp compat
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 10:36:45 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread osmith

Hello Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email

to look at the new patch set (#2).


Change subject: scripts/repo-install-test: fix sftp compat
..

scripts/repo-install-test: fix sftp compat

When running scp, Debian 12 uses the SFTP protocol by default instead of
the legacy SCP protocol. For some reason, this means it doesn't create
the /repo-install-test directory inside QEMU:

  + … scp … -r scripts/repo-install-test root@127.0.0.1:/repo-install-test
  Warning: Permanently added '[127.0.0.1]:22793' (ED25519) to the list of known 
hosts.
  scp: realpath /repo-install-test: No such file
  scp: upload "/repo-install-test": path canonicalization failed
  scp: failed to upload directory scripts/repo-install-test to 
/repo-install-test

Changing to the legacy protocol with "scp -O" would make it work again,
but instead of doing that add the mkdir so it works with the new
protocol too.

Related: OS#6186
Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
---
M scripts/repo-install-test.sh
1 file changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/34837/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 2
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset

[S] Change in osmo-ci[master]: scripts/repo-install-test: fix sftp compat

2023-10-20 Thread osmith

osmith has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email )


Change subject: scripts/repo-install-test: fix sftp compat
..

scripts/repo-install-test: fix sftp compat

When running scp, Debian 12 uses the SFTP protocol by default instead of
the legacy SCP protocol. For some reason, this means it doesn't create
the /repo-install-test directory inside QEMU:

  + … scp … -r scripts/repo-install-test root@127.0.0.1:/repo-install-test
  Warning: Permanently added '[127.0.0.1]:22793' (ED25519) to the list of known 
hosts.
  scp: realpath /repo-install-test: No such file
  scp: upload "/repo-install-test": path canonicalization failed
  scp: failed to upload directory scripts/repo-install-test to 
/repo-install-test

Changing to the legacy protocol with "scp -O" would make it work again,
but instead of doing that add the mkdir so it works with the new
protocol too.

Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
---
M scripts/repo-install-test.sh
1 file changed, 24 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/37/34837/1

diff --git a/scripts/repo-install-test.sh b/scripts/repo-install-test.sh
index 246d5e5..98f0176 100755
--- a/scripts/repo-install-test.sh
+++ b/scripts/repo-install-test.sh
@@ -153,6 +153,7 @@
EOF

qemu_ssh rm -rf /repo-install-test/
+   qemu_ssh mkdir /repo-install-test
qemu_scp -r "$TEST_DIR" "root@127.0.0.1:/repo-install-test"

TIMEOUT="1h" qemu_ssh sh -ex /repo-install-test/run-inside-env.sh

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34837?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I740affad2ea794094c8faa89a89bcad094e0075d
Gerrit-Change-Number: 34837
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-MessageType: newchange

[S] Change in osmo-ci[master]: scripts/tarballs: create release dir if missing

2023-10-20 Thread osmith

osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email )

Change subject: scripts/tarballs: create release dir if missing
..

scripts/tarballs: create release dir if missing

Fix for:
rsync: [Receiver] change_dir#3 "/downloads/home/releases/web-files/gapk" 
failed: No such file or directory (2)

Change-Id: I46310d633302028d486dd356147c9c4f35b24940
---
M scripts/tarballs/publish-tarballs-for-tags.sh
1 file changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved




diff --git a/scripts/tarballs/publish-tarballs-for-tags.sh 
b/scripts/tarballs/publish-tarballs-for-tags.sh
index e3dbf5b..c185c21 100755
--- a/scripts/tarballs/publish-tarballs-for-tags.sh
+++ b/scripts/tarballs/publish-tarballs-for-tags.sh
@@ -290,6 +290,7 @@
return
fi

+   $SSH_COMMAND relea...@ftp.osmocom.org -- mkdir -p "$WEB_PATH/$repo"
rsync -vz -e "$SSH_COMMAND" "$tarball_path" $tarball_path_remote
 }


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I46310d633302028d486dd356147c9c4f35b24940
Gerrit-Change-Number: 34819
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in osmo-ci[master]: scripts/tarballs: create release dir if missing

2023-10-20 Thread fixeria

Attention is currently required from: laforge, osmith.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email )

Change subject: scripts/tarballs: create release dir if missing
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34819?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I46310d633302028d486dd356147c9c4f35b24940
Gerrit-Change-Number: 34819
Gerrit-PatchSet: 1
Gerrit-Owner: osmith 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: osmith 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Fri, 20 Oct 2023 10:02:53 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE

2023-10-20 Thread daniel

Attention is currently required from: arehbein.

daniel has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email )

Change subject: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59c86370d13f2bb33c289d1b177df895726975cb
Gerrit-Change-Number: 34835
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Comment-Date: Fri, 20 Oct 2023 10:00:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE

2023-10-20 Thread daniel

daniel has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email )

Change subject: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE
..

osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE

Related: OS#6213
Change-Id: I59c86370d13f2bb33c289d1b177df895726975cb
---
M src/core/osmo_io_poll.c
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  daniel: Looks good to me, approved




diff --git a/src/core/osmo_io_poll.c b/src/core/osmo_io_poll.c
index d207047..a9aaea4 100644
--- a/src/core/osmo_io_poll.c
+++ b/src/core/osmo_io_poll.c
@@ -86,6 +86,10 @@
iofd_txqueue_enqueue_front(iofd, msghdr);
return;
}
+   if (rc == -EAGAIN) {
+   iofd_txqueue_enqueue_front(iofd, msghdr);
+   return;
+   }

switch (iofd->mode) {
case OSMO_IO_FD_MODE_READ_WRITE:

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59c86370d13f2bb33c289d1b177df895726975cb
Gerrit-Change-Number: 34835
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[L] Change in osmocom-bb[master]: mobile: add support for Circuit Switched Data calls

2023-10-20 Thread fixeria

Attention is currently required from: fixeria, laforge, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email )

Change subject: mobile: add support for Circuit Switched Data calls
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34762?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1995fa0a7a68d9b980852b664d472d4633777ac6
Gerrit-Change-Number: 34762
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Comment-Date: Fri, 20 Oct 2023 09:23:21 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in pysim[master]: pySim-shell: do not fail when EF.ICCID does not exist

2023-10-20 Thread osmith

Attention is currently required from: dexter, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/34768?usp=email )

Change subject: pySim-shell: do not fail when EF.ICCID does not exist
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8d18c5073946c5a6bb1f93be0ce692a599f46f8c
Gerrit-Change-Number: 34768
Gerrit-PatchSet: 1
Gerrit-Owner: dexter 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: osmith 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Attention: dexter 
Gerrit-Comment-Date: Fri, 20 Oct 2023 09:16:54 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in osmo-ttcn3-hacks[master]: Introduce EPDG_Tests testsuite

2023-10-20 Thread osmith

Attention is currently required from: fixeria, lynxis lazus, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )

Change subject: Introduce EPDG_Tests testsuite
..


Patch Set 6: Code-Review+1

(6 comments)

Patchset:

PS6:
nice! just some cosmetics


File epdg/EPDG_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/6e954307_94c3b758
PS6, Line 19: swtrongswan
strongswan


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/8a64f3e0_94c14fa0
PS6, Line 216: watchdong
watchdog


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/a8ccf961_f2307b46
PS6, Line 231:  /* TODO: maybe use, set to true */
kept intentionally?


File epdg/gen_links.sh:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/0d30aa1d_a1784497
PS6, Line 30: #FILES+="SS_DataTypes.asn SS_Errors.asn SS_Operations.asn 
SS_PDU_Defs.asn SS_Protocol.asn SS_Types.ttcn SS_EncDec.cc"
commented out FILES here looks like left-overs that should be removed?


File library/DIAMETER_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/b86d0189_8bdee660
PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) 
/* Optional */
do you want to keep the // lines in addition to the TODO comment below?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iab6f3c7dbcbbf344b0beca9490597c9ab0907171
Gerrit-Change-Number: 34778
Gerrit-PatchSet: 6
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: fixeria 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 09:14:16 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands

2023-10-20 Thread fixeria

fixeria has submitted this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email )

Change subject: mobile: vty: rework support enable/disable commands
..

mobile: vty: rework support enable/disable commands

Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2
Related: OS#4396
---
M src/host/layer23/src/mobile/vty_interface.c
1 file changed, 108 insertions(+), 130 deletions(-)

Approvals:
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved; Verified
  laforge: Looks good to me, but someone else must approve
  jolly: Looks good to me, but someone else must approve




diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 28f8a1b..1766071 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -2011,8 +2011,10 @@
return CMD_SUCCESS;
 }

-#define SUP_EN(cfg, cfg_cmd, item, cmd, desc, restart) \
-DEFUN(cfg, cfg_cmd, cmd, "Enable " desc "support") \
+#define SUP_EN(item, cmd, desc, restart) \
+DEFUN(cfg_ms_sup_en_##item, \
+  cfg_ms_sup_en_##item##_cmd, \
+  cmd, "Enable " desc "support") \
 { \
struct osmocom_ms *ms = vty->index; \
struct gsm_settings *set = >settings; \
@@ -2029,8 +2031,10 @@
return CMD_SUCCESS; \
 }

-#define SUP_DI(cfg, cfg_cmd, item, cmd, desc, restart) \
-DEFUN(cfg, cfg_cmd, "no " cmd, NO_STR "Disable " desc " support") \
+#define SUP_DI(item, cmd, desc, restart) \
+DEFUN(cfg_ms_sup_di_##item, \
+  cfg_ms_sup_di_##item##_cmd, \
+  "no " cmd, NO_STR "Disable " desc " support") \
 { \
struct osmocom_ms *ms = vty->index; \
struct gsm_settings *set = >settings; \
@@ -2047,8 +2051,15 @@
return CMD_SUCCESS; \
 }

-#define SET_EN(cfg, cfg_cmd, item, cmd, desc, restart) \
-DEFUN(cfg, cfg_cmd, cmd, "Enable " desc "support") \
+#define SUP_EN_DI(item, cmd, desc, restart) \
+   SUP_EN(item, cmd, desc, restart); \
+   SUP_DI(item, cmd, desc, restart)
+
+
+#define SET_EN(item, cmd, desc, restart) \
+DEFUN(cfg_ms_set_en_##item, \
+  cfg_ms_set_en_##item##_cmd, \
+  cmd, "Enable " desc "support") \
 { \
struct osmocom_ms *ms = vty->index; \
struct gsm_settings *set = >settings; \
@@ -2058,8 +2069,10 @@
return CMD_SUCCESS; \
 }

-#define SET_DI(cfg, cfg_cmd, item, cmd, desc, restart) \
-DEFUN(cfg, cfg_cmd, "no " cmd, NO_STR "Disable " desc " support") \
+#define SET_DI(item, cmd, desc, restart) \
+DEFUN(cfg_ms_set_di_##item, \
+  cfg_ms_set_di_##item##_cmd, \
+  "no " cmd, NO_STR "Disable " desc " support") \
 { \
struct osmocom_ms *ms = vty->index; \
struct gsm_settings *set = >settings; \
@@ -2069,52 +2082,28 @@
return CMD_SUCCESS; \
 }

-SET_EN(cfg_ms_sup_dtmf, cfg_ms_sup_dtmf_cmd, cc_dtmf, "dtmf", "DTMF", 0);
-SET_DI(cfg_ms_sup_no_dtmf, cfg_ms_sup_no_dtmf_cmd, cc_dtmf, "dtmf", "DTMF", 0);
-SUP_EN(cfg_ms_sup_sms, cfg_ms_sup_sms_cmd, sms_ptp, "sms", "SMS", 0);
-SUP_DI(cfg_ms_sup_no_sms, cfg_ms_sup_no_sms_cmd, sms_ptp, "sms", "SMS", 0);
-SUP_EN(cfg_ms_sup_a5_1, cfg_ms_sup_a5_1_cmd, a5_1, "a5/1", "A5/1", 0);
-SUP_DI(cfg_ms_sup_no_a5_1, cfg_ms_sup_no_a5_1_cmd, a5_1, "a5/1", "A5/1", 0);
-SUP_EN(cfg_ms_sup_a5_2, cfg_ms_sup_a5_2_cmd, a5_2, "a5/2", "A5/2", 0);
-SUP_DI(cfg_ms_sup_no_a5_2, cfg_ms_sup_no_a5_2_cmd, a5_2, "a5/2", "A5/2", 0);
-SUP_EN(cfg_ms_sup_a5_3, cfg_ms_sup_a5_3_cmd, a5_3, "a5/3", "A5/3", 0);
-SUP_DI(cfg_ms_sup_no_a5_3, cfg_ms_sup_no_a5_3_cmd, a5_3, "a5/3", "A5/3", 0);
-SUP_EN(cfg_ms_sup_a5_4, cfg_ms_sup_a5_4_cmd, a5_4, "a5/4", "A5/4", 0);
-SUP_DI(cfg_ms_sup_no_a5_4, cfg_ms_sup_no_a5_4_cmd, a5_4, "a5/4", "A5/4", 0);
-SUP_EN(cfg_ms_sup_a5_5, cfg_ms_sup_a5_5_cmd, a5_5, "a5/5", "A5/5", 0);
-SUP_DI(cfg_ms_sup_no_a5_5, cfg_ms_sup_no_a5_5_cmd, a5_5, "a5/5", "A5/5", 0);
-SUP_EN(cfg_ms_sup_a5_6, cfg_ms_sup_a5_6_cmd, a5_6, "a5/6", "A5/6", 0);
-SUP_DI(cfg_ms_sup_no_a5_6, cfg_ms_sup_no_a5_6_cmd, a5_6, "a5/6", "A5/6", 0);
-SUP_EN(cfg_ms_sup_a5_7, cfg_ms_sup_a5_7_cmd, a5_7, "a5/7", "A5/7", 0);
-SUP_DI(cfg_ms_sup_no_a5_7, cfg_ms_sup_no_a5_7_cmd, a5_7, "a5/7", "A5/7", 0);
-SUP_EN(cfg_ms_sup_p_gsm, cfg_ms_sup_p_gsm_cmd, p_gsm, "p-gsm", "P-GSM (900)",
-   1);
-SUP_DI(cfg_ms_sup_no_p_gsm, cfg_ms_sup_no_p_gsm_cmd, p_gsm, "p-gsm",
-   "P-GSM (900)", 1);
-SUP_EN(cfg_ms_sup_e_gsm, cfg_ms_sup_e_gsm_cmd, e_gsm, "e-gsm", "E-GSM (850)",
-   1);
-SUP_DI(cfg_ms_sup_no_e_gsm, cfg_ms_sup_no_e_gsm_cmd, e_gsm, "e-gsm",
-   "E-GSM (850)", 1);
-SUP_EN(cfg_ms_sup_r_gsm, cfg_ms_sup_r_gsm_cmd, r_gsm, "r-gsm", "R-GSM (850)",
-   1);
-SUP_DI(cfg_ms_sup_no_r_gsm, cfg_ms_sup_no_r_gsm_cmd, r_gsm, "r-gsm",
-   "R-GSM (850)", 1);
-SUP_EN(cfg_ms_sup_dcs, cfg_ms_sup_dcs_cmd, dcs, "dcs", "DCS (1800)", 1);
-SUP_DI(cfg_ms_sup_no_dcs, cfg_ms_sup_no_dcs_cmd, dcs, "dcs", "DCS (1800)", 1);
-SUP_EN(cfg_ms_sup_gsm_850, cfg_ms_sup_gsm_850_cmd,

[M] Change in osmocom-bb[master]: mobile: vty: rework support enable/disable commands

2023-10-20 Thread fixeria

Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email )

Change subject: mobile: vty: rework support enable/disable commands
..


Patch Set 1: Code-Review+2

(1 comment)

File src/host/layer23/src/mobile/vty_interface.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34811/comment/210be6a8_b01f7aea
PS1, Line 2019: struct osmocom_ms *ms = vty->index; \
> Did you think about having all this code in a single helper function where 
> you pass a bool* to it? T […]
I didn't think of it, but now that you raised this topic... Not only we need to 
pass a bool, but also **a field name**. What we can move to the common part is 
a) checking `if (!sup->item) { ... }` and b) `if (restart) ...`. The actual 
field assignment would remain here. Though I don't see much benefit of doing so 
because part a) returns in two places...

Oh wait, we could actually pass pointers! Here is my attempt:

https://gerrit.osmocom.org/c/osmocom-bb/+/34836 [WIP]

This patch works, but there are problems to be resolved (e.g. some fields are 
`uint8_t` and some are `bool`). I marked it WIP, feel free to take over if you 
wish. I will not be spending more time on it because there is still plenty of 
things to do apart from improving the VTY commands...



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34811?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ibfef31f6dd7694dad535ad07fdf47bd32571b7b2
Gerrit-Change-Number: 34811
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: jolly 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 09:05:52 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[M] Change in osmocom-bb[master]: fixup! mobile: vty: rework support enable/disable commands

2023-10-20 Thread fixeria

fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/34836?usp=email )


Change subject: fixup! mobile: vty: rework support enable/disable commands
..

fixup! mobile: vty: rework support enable/disable commands

FIXME: pass the item description (as a 'char *' pointer?)
TODO: some fields are uint8_t, some bool

Change-Id: Ie47d2eadf8e9736280fd75f52f2956910585d131
---
M src/host/layer23/src/mobile/vty_interface.c
1 file changed, 41 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/36/34836/1

diff --git a/src/host/layer23/src/mobile/vty_interface.c 
b/src/host/layer23/src/mobile/vty_interface.c
index 1766071..ff2ffd5 100644
--- a/src/host/layer23/src/mobile/vty_interface.c
+++ b/src/host/layer23/src/mobile/vty_interface.c
@@ -2011,24 +2011,37 @@
return CMD_SUCCESS;
 }

+/* helper function for SUP_{EN,DI} macros */
+static int _cfg_ms_sup_en_di(struct vty *vty,
+uint8_t *sup_field, uint8_t *set_field,
+uint8_t en_di_val, bool restart)
+{
+   struct osmocom_ms *ms = vty->index;
+
+   if (!*sup_field) {
+   vty_out(vty, "FIXME not supported%s", VTY_NEWLINE);
+   if (l23_vty_reading)
+   return CMD_SUCCESS;
+   return CMD_WARNING;
+   }
+
+   if (restart)
+   vty_restart(vty, ms);
+   *set_field = en_di_val;
+
+   return CMD_SUCCESS;
+}
+
 #define SUP_EN(item, cmd, desc, restart) \
 DEFUN(cfg_ms_sup_en_##item, \
   cfg_ms_sup_en_##item##_cmd, \
   cmd, "Enable " desc "support") \
 { \
struct osmocom_ms *ms = vty->index; \
-   struct gsm_settings *set = >settings; \
-   struct gsm_support *sup = >support; \
-   if (!sup->item) { \
-   vty_out(vty, desc " not supported%s", VTY_NEWLINE); \
-   if (l23_vty_reading) \
-   return CMD_SUCCESS; \
-   return CMD_WARNING; \
-   } \
-   if (restart) \
-   vty_restart(vty, ms); \
-   set->item = 1; \
-   return CMD_SUCCESS; \
+   return _cfg_ms_sup_en_di(vty, \
+>support.item, \
+>settings.item, \
+1, restart); \
 }

 #define SUP_DI(item, cmd, desc, restart) \
@@ -2037,18 +2050,10 @@
   "no " cmd, NO_STR "Disable " desc " support") \
 { \
struct osmocom_ms *ms = vty->index; \
-   struct gsm_settings *set = >settings; \
-   struct gsm_support *sup = >support; \
-   if (!sup->item) { \
-   vty_out(vty, desc " not supported%s", VTY_NEWLINE); \
-   if (l23_vty_reading) \
-   return CMD_SUCCESS; \
-   return CMD_WARNING; \
-   } \
-   if (restart) \
-   vty_restart(vty, ms); \
-   set->item = 0; \
-   return CMD_SUCCESS; \
+   return _cfg_ms_sup_en_di(vty, \
+>support.item, \
+>settings.item, \
+0, restart); \
 }

 #define SUP_EN_DI(item, cmd, desc, restart) \

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34836?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie47d2eadf8e9736280fd75f52f2956910585d131
Gerrit-Change-Number: 34836
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

[S] Change in libosmocore[master]: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE

2023-10-20 Thread fixeria

Attention is currently required from: arehbein, daniel.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email )

Change subject: osmo_io_poll: Handle -EAGAIN in case of OSMO_FD_WRITE
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34835?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I59c86370d13f2bb33c289d1b177df895726975cb
Gerrit-Change-Number: 34835
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: arehbein 
Gerrit-Attention: daniel 
Gerrit-Comment-Date: Fri, 20 Oct 2023 08:31:15 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: GSUP_Types: Add EDPG_Tunnel messages

2023-10-20 Thread fixeria

Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email )

Change subject: GSUP_Types: Add EDPG_Tunnel messages
..


Patch Set 1: Code-Review+1

(1 comment)

File library/GSUP_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832/comment/56ee7d49_c78173e0
PS1, Line 695: template
missing `(value)`



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34832?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadba149e6d299e5e666b2debdc23a00d37e78da5
Gerrit-Change-Number: 34832
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 08:30:39 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[M] Change in osmo-ttcn3-hacks[master]: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req

2023-10-20 Thread fixeria

Attention is currently required from: lynxis lazus, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email )

Change subject: epdg: Test GTPv2C CreateSession triggerd by EPDG_Tunnel Req
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34833?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f18c927b1897806233cc9d049c25694c1e639d4
Gerrit-Change-Number: 34833
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Reviewer: osmith 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 08:29:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[L] Change in ...osmo-epdg[master]: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp

2023-10-20 Thread fixeria

Attention is currently required from: laforge, lynxis lazus, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email )

Change subject: Handle GSUP EPDG_Tunnel through GTPv2C CreateSession Req+Resp
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34804?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I6f00b7fce2d5fcdc484bfd45629b9141f16bc579
Gerrit-Change-Number: 34804
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Fri, 20 Oct 2023 08:28:35 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in docker-playground[master]: ttcn3-epdg-test: Update config file to set up GTPv2C socket

2023-10-20 Thread fixeria

Attention is currently required from: pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email )

Change subject: ttcn3-epdg-test: Update config file to set up GTPv2C socket
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34834?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I05ae2d87e16cef9772bc5c3690f687e5ecbd5f51
Gerrit-Change-Number: 34834
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 20 Oct 2023 08:27:24 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

76 matches

Mail list logo