Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: OK, that's the same behaviour I encountered. Harald Welte mentioned in the IRC that the first RTP packet is just a NAT Keep-Alive packet. It can probably be ignored. I think there's something else happening with the sockets. I see UDP RDP traffic from my asterisk on the lo interface, which the kernel is replying to with an ICMP unreachable message, as if the osmo-mgw isn't even listening. Do you have another method of contact like IRC or mail? We probably shouldn't spam this thread :) -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel Gerrit-Reviewer: Tobias Mädel Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: kamilner Gerrit-Reviewer: lynxis lazus Gerrit-CC: Harald Welte Gerrit-Comment-Date: Thu, 16 Aug 2018 14:37:20 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Hello kamilner, thanks for testing! Could you vote +1 instead of -1? Does audio work for you yet? I wasn't able to get a codec negotiated yet. Thanks, Tobias -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel Gerrit-Reviewer: Tobias Mädel Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: kamilner Gerrit-Reviewer: lynxis lazus Gerrit-CC: Harald Welte Gerrit-Comment-Date: Thu, 16 Aug 2018 14:21:13 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr
Tobias Mädel has posted comments on this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Patch Set 2: Good idea. I just did that. Should be better now. -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Tobias Mädel Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-CC: Harald Welte Gerrit-Comment-Date: Wed, 15 Aug 2018 16:18:00 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr
Tobias Mädel has removed Jenkins Builder from this change. ( https://gerrit.osmocom.org/10452 ) Change subject: sdp: remove htonl() from in_addr .. Removed reviewer Jenkins Builder. -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel Gerrit-Reviewer: Tobias Mädel Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-CC: Harald Welte
Change in osmo-sip-connector[master]: sdp: remove htonl() from in_addr
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/10452 to look at the new patch set (#2). Change subject: sdp: remove htonl() from in_addr .. sdp: remove htonl() from in_addr Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 --- M src/sdp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/52/10452/2 -- To view, visit https://gerrit.osmocom.org/10452 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806 Gerrit-Change-Number: 10452 Gerrit-PatchSet: 2 Gerrit-Owner: Tobias Mädel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: lynxis lazus Gerrit-CC: Harald Welte
Change in osmo-sip-connector[master]: merges commit from lynxis - changes byte order for IPv4 address in SDP
Tobias Mädel has uploaded this change for review. (
https://gerrit.osmocom.org/10452
Change subject: merges commit from lynxis - changes byte order for IPv4 address
in SDP
..
merges commit from lynxis - changes byte order for IPv4 address in SDP
Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806
---
M src/sdp.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector
refs/changes/52/10452/1
diff --git a/src/sdp.c b/src/sdp.c
index 213e979..2824378 100644
--- a/src/sdp.c
+++ b/src/sdp.c
@@ -165,7 +165,7 @@
char *sdp_create_file(struct sip_call_leg *leg, struct call_leg *other)
{
- struct in_addr net = { .s_addr = ntohl(other->ip) };
+ struct in_addr net = { .s_addr = other->ip };
char *fmtp_str = NULL, *sdp;
leg->wanted_codec = app_media_name(other->payload_msg_type);
--
To view, visit https://gerrit.osmocom.org/10452
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sip-connector
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2bebfb905afc91afc01770df8532b749f494806
Gerrit-Change-Number: 10452
Gerrit-PatchSet: 1
Gerrit-Owner: Tobias Mädel
