[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec

2024-02-22 Thread pespin 
pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email )

Change subject: s2b: Reorder some CreateSessionReq according to spec
..

s2b: Reorder some CreateSessionReq according to spec

Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
---
M src/epdg_gtpc_s2b.erl
1 file changed, 14 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved




diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl
index 309ed79..f635036 100644
--- a/src/epdg_gtpc_s2b.erl
+++ b/src/epdg_gtpc_s2b.erl
@@ -482,8 +482,10 @@
 ipv4 = conv:ip_to_bin(LocalAddrGtpu)
   }
 ],
-IEs = [#v2_recovery{restart_counter = RCnt},
-   #v2_international_mobile_subscriber_identity{imsi = Imsi},
+IEs = [#v2_international_mobile_subscriber_identity{imsi = Imsi},
+   #v2_serving_network{
+plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE)
+   },
#v2_rat_type{rat_type = 3}, %% 3 = WLAN
#v2_fully_qualified_tunnel_endpoint_identifier{
 instance = 0,
@@ -495,9 +497,7 @@
 #v2_selection_mode{mode = 0},
 #v2_pdn_address_allocation{type = ipv4, address = <<0,0,0,0>>},
 #v2_bearer_context{group = BearersIE},
-#v2_serving_network{
-plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE)
-}
+#v2_recovery{restart_counter = RCnt}
   ],
 #gtp{version = v2, type = create_session_request, tei = 0, seq_no = SeqNo, 
ie = IEs}.


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
Gerrit-Change-Number: 36051
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec

2024-02-22 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email )

Change subject: s2b: Reorder some CreateSessionReq according to spec
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
Gerrit-Change-Number: 36051
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 22 Feb 2024 16:11:58 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec

2024-02-22 Thread laforge 
Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email )

Change subject: s2b: Reorder some CreateSessionReq according to spec
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
Gerrit-Change-Number: 36051
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 22 Feb 2024 10:21:02 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in ...osmo-epdg[master]: s2b: Reorder some CreateSessionReq according to spec

2024-02-21 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email )


Change subject: s2b: Reorder some CreateSessionReq according to spec
..

s2b: Reorder some CreateSessionReq according to spec

Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
---
M src/epdg_gtpc_s2b.erl
1 file changed, 14 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg 
refs/changes/51/36051/1

diff --git a/src/epdg_gtpc_s2b.erl b/src/epdg_gtpc_s2b.erl
index 309ed79..f635036 100644
--- a/src/epdg_gtpc_s2b.erl
+++ b/src/epdg_gtpc_s2b.erl
@@ -482,8 +482,10 @@
 ipv4 = conv:ip_to_bin(LocalAddrGtpu)
   }
 ],
-IEs = [#v2_recovery{restart_counter = RCnt},
-   #v2_international_mobile_subscriber_identity{imsi = Imsi},
+IEs = [#v2_international_mobile_subscriber_identity{imsi = Imsi},
+   #v2_serving_network{
+plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE)
+   },
#v2_rat_type{rat_type = 3}, %% 3 = WLAN
#v2_fully_qualified_tunnel_endpoint_identifier{
 instance = 0,
@@ -495,9 +497,7 @@
 #v2_selection_mode{mode = 0},
 #v2_pdn_address_allocation{type = ipv4, address = <<0,0,0,0>>},
 #v2_bearer_context{group = BearersIE},
-#v2_serving_network{
-plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, ?MNC_SIZE)
-}
+#v2_recovery{restart_counter = RCnt}
   ],
 #gtp{version = v2, type = create_session_request, tei = 0, seq_no = SeqNo, 
ie = IEs}.


--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36051?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I5f9d4de12038cc3627bf6341ae1cf4d3655a5251
Gerrit-Change-Number: 36051
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange