[S] Change in libosmo-abis[master]: ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

2024-02-21 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email )

Change subject: ipaccess: Log ERROR message if IPA keep-alive FSM allocation 
fails
..

ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

This is a rather serious and unexpected event, it shouldn't go quiet.

Related: SYS#6801

Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
---
M src/input/ipaccess.c
1 file changed, 19 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve




diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 48a1d40..7c91e70 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -160,8 +160,10 @@

ka_fsm = ipa_generic_conn_alloc_keepalive_fsm(tall_ipa_ctx, bfd, 
line->ipa_kap, id);
e1i_ts->driver.ipaccess.ka_fsm = ka_fsm;
-   if (!ka_fsm)
+   if (!ka_fsm) {
+   LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA 
keepalive FSM\n");
return;
+   }

ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bsc_keepalive_timeout_cb);
ipa_keepalive_fsm_set_send_cb(ka_fsm, 
ipa_bsc_keepalive_write_server_cb);
@@ -198,8 +200,10 @@

ka_fsm = ipa_client_conn_alloc_keepalive_fsm(client, line->ipa_kap, id);
e1i_ts->driver.ipaccess.ka_fsm = ka_fsm;
-   if (!ka_fsm)
+   if (!ka_fsm) {
+   LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA 
keepalive FSM\n");
return;
+   }

ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bts_keepalive_timeout_cb);
ipa_keepalive_fsm_set_send_cb(ka_fsm, 
ipa_bts_keepalive_write_client_cb);

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
Gerrit-Change-Number: 36035
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

[S] Change in libosmo-abis[master]: ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

2024-02-21 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email )

Change subject: ipaccess: Log ERROR message if IPA keep-alive FSM allocation 
fails
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
Gerrit-Change-Number: 36035
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Wed, 21 Feb 2024 17:10:44 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmo-abis[master]: ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

2024-02-21 Thread pespin 
Attention is currently required from: laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email )

Change subject: ipaccess: Log ERROR message if IPA keep-alive FSM allocation 
fails
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
Gerrit-Change-Number: 36035
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: laforge 
Gerrit-Comment-Date: Wed, 21 Feb 2024 16:57:43 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmo-abis[master]: ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

2024-02-21 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email )


Change subject: ipaccess: Log ERROR message if IPA keep-alive FSM allocation 
fails
..

ipaccess: Log ERROR message if IPA keep-alive FSM allocation fails

This is a rather serious and unexpected event, it shouldn't go quiet.

Related: SYS#6801

Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
---
M src/input/ipaccess.c
1 file changed, 19 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/35/36035/1

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index 48a1d40..7c91e70 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -160,8 +160,10 @@

ka_fsm = ipa_generic_conn_alloc_keepalive_fsm(tall_ipa_ctx, bfd, 
line->ipa_kap, id);
e1i_ts->driver.ipaccess.ka_fsm = ka_fsm;
-   if (!ka_fsm)
+   if (!ka_fsm) {
+   LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA 
keepalive FSM\n");
return;
+   }

ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bsc_keepalive_timeout_cb);
ipa_keepalive_fsm_set_send_cb(ka_fsm, 
ipa_bsc_keepalive_write_server_cb);
@@ -198,8 +200,10 @@

ka_fsm = ipa_client_conn_alloc_keepalive_fsm(client, line->ipa_kap, id);
e1i_ts->driver.ipaccess.ka_fsm = ka_fsm;
-   if (!ka_fsm)
+   if (!ka_fsm) {
+   LOGPITS(e1i_ts, DLINP, LOGL_ERROR, "Failed to allocate IPA 
keepalive FSM\n");
return;
+   }

ipa_keepalive_fsm_set_timeout_cb(ka_fsm, ipa_bts_keepalive_timeout_cb);
ipa_keepalive_fsm_set_send_cb(ka_fsm, 
ipa_bts_keepalive_write_client_cb);

--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36035?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ic310b3544ae817e26247facf30ece617fefa82eb
Gerrit-Change-Number: 36035
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange