[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email )
Change subject: LAPDM: Use correct offset to short header on recevied frame
..
LAPDM: Use correct offset to short header on recevied frame
The offset of the short header on main DCCH is 0, not 2.
Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
---
M src/gsm/lapdm.c
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index 9f795c6..86dc242 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -754,7 +754,7 @@
msg->l2h += 2;
} else {
/* A Short L3 header has both bits == 0. */
- if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0) {
+ if (LAPDm_ADDR_SHORT_L2(msg->l2h[0]) == 0) {
mctx.lapdm_fmt = LAPDm_FMT_Bter;
n201 = N201_Bter_SDCCH;
sapi = 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
Gerrit-Change-Number: 34362
Gerrit-PatchSet: 2
Gerrit-Owner: jolly
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email ) Change subject: LAPDM: Use correct offset to short header on recevied frame .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc Gerrit-Change-Number: 34362 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 12 Sep 2023 09:12:37 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email ) Change subject: LAPDM: Use correct offset to short header on recevied frame .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc Gerrit-Change-Number: 34362 Gerrit-PatchSet: 1 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Attention: jolly Gerrit-Comment-Date: Mon, 11 Sep 2023 17:24:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: LAPDM: Use correct offset to short header on recevied frame
jolly has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email )
Change subject: LAPDM: Use correct offset to short header on recevied frame
..
LAPDM: Use correct offset to short header on recevied frame
The offset of the short header on main DCCH is 0, not 2.
Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
---
M src/gsm/lapdm.c
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/34362/1
diff --git a/src/gsm/lapdm.c b/src/gsm/lapdm.c
index 9f795c6..86dc242 100644
--- a/src/gsm/lapdm.c
+++ b/src/gsm/lapdm.c
@@ -754,7 +754,7 @@
msg->l2h += 2;
} else {
/* A Short L3 header has both bits == 0. */
- if (LAPDm_ADDR_SHORT_L2(msg->l2h[2]) == 0) {
+ if (LAPDm_ADDR_SHORT_L2(msg->l2h[0]) == 0) {
mctx.lapdm_fmt = LAPDm_FMT_Bter;
n201 = N201_Bter_SDCCH;
sapi = 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34362?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I8345776768fdf2a700b2ca1d117f9ef4b15777cc
Gerrit-Change-Number: 34362
Gerrit-PatchSet: 1
Gerrit-Owner: jolly
Gerrit-MessageType: newchange
