[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-10-24 Thread laforge 
Attention is currently required from: lynxis lazus.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email )

Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..


Patch Set 1:

(1 comment)

File src/gsm/gsup.c:

https://gerrit.osmocom.org/c/libosmocore/+/32033/comment/d64ac1ef_11a8cf04
PS1, Line 918: EPDG
cosmetic: I think the correct capitalization of the respective acronyms is 
"IPsec" and "ePDG"



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Tue, 24 Oct 2023 19:29:37 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-10-19 Thread pespin 
Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email )

Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
> Duplicate of https://gerrit.osmocom. […]
I abandoned by duplicate patch. @lyn...@fe80.eu said he wanted to send an email 
to the ML requesting for comments on which message types to (re)use.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 19 Oct 2023 14:59:50 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin 
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-10-17 Thread pespin 
Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email )

Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
Duplicate of https://gerrit.osmocom.org/c/libosmocore/+/34784



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-CC: pespin 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Tue, 17 Oct 2023 16:48:35 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-06-11 Thread laforge 
Attention is currently required from: lynxis lazus.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033 )

Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..


Patch Set 1:

(1 comment)

Patchset:

PS1:
still has a "WIP" label in the subject - but not marked as WIP in gerit.  
Should we still merge this, lynxis?



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Sun, 11 Jun 2023 19:44:19 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-03-23 Thread laforge 
Attention is currently required from: lynxis lazus.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033 )

Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Attention: lynxis lazus 
Gerrit-Comment-Date: Thu, 23 Mar 2023 19:25:32 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in libosmocore[master]: WIP: gsup: add message type for osmo-epdg CEIA interface

2023-03-23 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/32033 )


Change subject: WIP: gsup: add message type for osmo-epdg CEIA interface
..

WIP: gsup: add message type for osmo-epdg CEIA interface

The CEIA interface is an interface between osmo-epdg and
strongswan.
It is used by the osmo-epdg to synchronize state.

Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
---
M include/osmocom/gsm/gsup.h
M src/gsm/gsup.c
2 files changed, 23 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/33/32033/1

diff --git a/include/osmocom/gsm/gsup.h b/include/osmocom/gsm/gsup.h
index 56d7a30..6e7fcf0 100644
--- a/include/osmocom/gsm/gsup.h
+++ b/include/osmocom/gsm/gsup.h
@@ -198,6 +198,10 @@
OSMO_GSUP_MSGT_E_ABORT  = 0b01001011,

OSMO_GSUP_MSGT_ROUTING_ERROR= 0b01001110,
+
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST  = 0b0101,
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR= 0b01010001,
+   OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT   = 0b01010010,
 };

 #define OSMO_GSUP_MSGT_E_ROUTING_ERROR OSMO_GSUP_MSGT_ROUTING_ERROR
@@ -281,6 +285,7 @@
OSMO_GSUP_MESSAGE_CLASS_SMS = 2,
OSMO_GSUP_MESSAGE_CLASS_USSD = 3,
OSMO_GSUP_MESSAGE_CLASS_INTER_MSC = 4,
+   OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG = 5,
/* Keep this as last entry with a value of max(enum 
osmo_gsup_message_class) + 1.
 * This value shall serve as the size for an array to aid de-muxing all 
known GSUP classes. */
OSMO_GSUP_MESSAGE_CLASS_ARRAYSIZE
diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c
index ef33ed0..58ead06 100644
--- a/src/gsm/gsup.c
+++ b/src/gsm/gsup.c
@@ -103,6 +103,10 @@

OSMO_VALUE_STRING(OSMO_GSUP_MSGT_ROUTING_ERROR),

+   OSMO_VALUE_STRING(OSMO_GSUP_MSGT_EPDG_TUNNEL_REQUEST),
+   OSMO_VALUE_STRING(OSMO_GSUP_MSGT_EPDG_TUNNEL_RESULT),
+   OSMO_VALUE_STRING(OSMO_GSUP_MSGT_EPDG_TUNNEL_ERROR),
+
{ 0, NULL }
 };

@@ -911,6 +915,7 @@
{ OSMO_GSUP_MESSAGE_CLASS_SMS, "SMS" },
{ OSMO_GSUP_MESSAGE_CLASS_USSD, "USSD" },
{ OSMO_GSUP_MESSAGE_CLASS_INTER_MSC, "Inter-MSC" },
+   { OSMO_GSUP_MESSAGE_CLASS_IPSEC_EPDG, "IPSEC-EPDG" },
{}
 };


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/32033
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6f7c20340c99f94b1326a8a7dc99c86cf6a0dbc3
Gerrit-Change-Number: 32033
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange