[S] Change in libosmocore[master]: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email ) Change subject: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 .. coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 This patch brings decoding of the CS1 in consistency with the other three coding schemes, for which we support decoding USF independently. Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 --- M src/coding/gsm0503_coding.c 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 5b78502..1f409d6 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -1042,6 +1042,10 @@ osmo_conv_decode_ber(_xcch, cB, conv, n_errors, n_bits_total); + /* the three USF bits d(0),d(1),d(2) are *not* precoded */ + if (usf_p) + *usf_p = (conv[0] << 2) | (conv[1] << 1) | (conv[2] << 0); + rv = osmo_crc64gen_check_bits(_fire_crc40, conv, 184, conv + 184); if (rv) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 Gerrit-Change-Number: 35258 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in libosmocore[master]: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email ) Change subject: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 Gerrit-Change-Number: 35258 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 07 Dec 2023 23:12:14 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email ) Change subject: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 Gerrit-Change-Number: 35258 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Attention: fixeria Gerrit-Comment-Date: Thu, 07 Dec 2023 22:35:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email ) Change subject: coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 .. coding: gsm0503_pdtch_decode(): implement USF decoding for CS1 This patch brings decoding of the CS1 in consistency with the other three coding schemes, for which we support decoding USF independently. Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 --- M src/coding/gsm0503_coding.c 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/58/35258/1 diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 5b78502..1f409d6 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -1042,6 +1042,10 @@ osmo_conv_decode_ber(_xcch, cB, conv, n_errors, n_bits_total); + /* the three USF bits d(0),d(1),d(2) are *not* precoded */ + if (usf_p) + *usf_p = (conv[0] << 2) | (conv[1] << 1) | (conv[2] << 0); + rv = osmo_crc64gen_check_bits(_fire_crc40, conv, 184, conv + 184); if (rv) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35258?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I61a3628741c0ac68374fc7f077cf3a07e51277c3 Gerrit-Change-Number: 35258 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
