[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test .. tests: rename logging_test_gsmtap -> logging_gsmtap_test This way the naming is consistent with existing tests and matches the 'tests/*/*_test' pattern in .gitignore. Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 --- M tests/Makefile.am R tests/logging/logging_gsmtap_test.c R tests/logging/logging_gsmtap_test.err M tests/testsuite.at 4 files changed, 19 insertions(+), 7 deletions(-) Approvals: osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/Makefile.am b/tests/Makefile.am index 45490f2..3b4325e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,7 +15,7 @@ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ -logging/logging_test_gsmtap\ +logging/logging_gsmtap_test\ loggingrb/loggingrb_test strrb/strrb_test \ comp128/comp128_test \ bitvec/bitvec_test msgb/msgb_test bits/bitcomp_test\ @@ -246,7 +246,7 @@ logging_logging_vty_test_SOURCES = logging/logging_vty_test.c logging_logging_vty_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) -logging_logging_test_gsmtap_SOURCES = logging/logging_test_gsmtap.c +logging_logging_gsmtap_test_SOURCES = logging/logging_gsmtap_test.c vty_vty_transcript_test_SOURCES = vty/vty_transcript_test.c vty_vty_transcript_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) @@ -431,7 +431,7 @@ msgfile/msgfile_test.ok msgfile/msgconfig.cfg \ logging/logging_test.ok logging/logging_test.err \ logging/logging_vty_test.vty \ -logging/logging_test_gsmtap.err\ +logging/logging_gsmtap_test.err\ fr/fr_test.ok loggingrb/logging_test.ok \ loggingrb/logging_test.errstrrb/strrb_test.ok \ codec/codec_test.ok \ @@ -589,8 +589,8 @@ logging/logging_test \ >$(srcdir)/logging/logging_test.ok \ 2>$(srcdir)/logging/logging_test.err - logging/logging_test_gsmtap \ - 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_test_gsmtap.err + logging/logging_gsmtap_test \ + 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_gsmtap_test.err codec/codec_test \ >$(srcdir)/codec/codec_test.ok codec/codec_ecu_fr_test \ diff --git a/tests/logging/logging_test_gsmtap.c b/tests/logging/logging_gsmtap_test.c similarity index 100% rename from tests/logging/logging_test_gsmtap.c rename to tests/logging/logging_gsmtap_test.c diff --git a/tests/logging/logging_test_gsmtap.err b/tests/logging/logging_gsmtap_test.err similarity index 100% rename from tests/logging/logging_test_gsmtap.err rename to tests/logging/logging_gsmtap_test.err diff --git a/tests/testsuite.at b/tests/testsuite.at index 9f17ba3..e721b93 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -202,8 +202,8 @@ AT_SETUP([logging_gsmtap]) AT_KEYWORDS([logging_gsmtap]) -cat $abs_srcdir/logging/logging_test_gsmtap.err > experr -AT_CHECK([$abs_top_builddir/tests/logging/logging_test_gsmtap 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) +cat $abs_srcdir/logging/logging_gsmtap_test.err > experr +AT_CHECK([$abs_top_builddir/tests/logging/logging_gsmtap_test 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) AT_CLEANUP AT_SETUP([codec]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged
[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Tue, 23 Apr 2024 09:28:41 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: fixeria Gerrit-Comment-Date: Mon, 22 Apr 2024 09:09:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in libosmocore[master]: tests: rename logging_test_gsmtap -> logging_gsmtap_test
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email ) Change subject: tests: rename logging_test_gsmtap -> logging_gsmtap_test .. tests: rename logging_test_gsmtap -> logging_gsmtap_test This way the naming is consistent with existing tests and matches the 'tests/*/*_test' pattern in .gitignore. Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 --- M tests/Makefile.am R tests/logging/logging_gsmtap_test.c R tests/logging/logging_gsmtap_test.err M tests/testsuite.at 4 files changed, 19 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/36615/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index 45490f2..3b4325e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -15,7 +15,7 @@ gsm0808/gsm0808_test gsm0408/gsm0408_test \ gprs/gprs_test kasumi/kasumi_test gea/gea_test \ logging/logging_test codec/codec_test \ -logging/logging_test_gsmtap\ +logging/logging_gsmtap_test\ loggingrb/loggingrb_test strrb/strrb_test \ comp128/comp128_test \ bitvec/bitvec_test msgb/msgb_test bits/bitcomp_test\ @@ -246,7 +246,7 @@ logging_logging_vty_test_SOURCES = logging/logging_vty_test.c logging_logging_vty_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) -logging_logging_test_gsmtap_SOURCES = logging/logging_test_gsmtap.c +logging_logging_gsmtap_test_SOURCES = logging/logging_gsmtap_test.c vty_vty_transcript_test_SOURCES = vty/vty_transcript_test.c vty_vty_transcript_test_LDADD = $(top_builddir)/src/vty/libosmovty.la $(LDADD) @@ -431,7 +431,7 @@ msgfile/msgfile_test.ok msgfile/msgconfig.cfg \ logging/logging_test.ok logging/logging_test.err \ logging/logging_vty_test.vty \ -logging/logging_test_gsmtap.err\ +logging/logging_gsmtap_test.err\ fr/fr_test.ok loggingrb/logging_test.ok \ loggingrb/logging_test.errstrrb/strrb_test.ok \ codec/codec_test.ok \ @@ -589,8 +589,8 @@ logging/logging_test \ >$(srcdir)/logging/logging_test.ok \ 2>$(srcdir)/logging/logging_test.err - logging/logging_test_gsmtap \ - 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_test_gsmtap.err + logging/logging_gsmtap_test \ + 2>&1 |grep -v "enqueueing message failed" >$(srcdir)/logging/logging_gsmtap_test.err codec/codec_test \ >$(srcdir)/codec/codec_test.ok codec/codec_ecu_fr_test \ diff --git a/tests/logging/logging_test_gsmtap.c b/tests/logging/logging_gsmtap_test.c similarity index 100% rename from tests/logging/logging_test_gsmtap.c rename to tests/logging/logging_gsmtap_test.c diff --git a/tests/logging/logging_test_gsmtap.err b/tests/logging/logging_gsmtap_test.err similarity index 100% rename from tests/logging/logging_test_gsmtap.err rename to tests/logging/logging_gsmtap_test.err diff --git a/tests/testsuite.at b/tests/testsuite.at index 9f17ba3..e721b93 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -202,8 +202,8 @@ AT_SETUP([logging_gsmtap]) AT_KEYWORDS([logging_gsmtap]) -cat $abs_srcdir/logging/logging_test_gsmtap.err > experr -AT_CHECK([$abs_top_builddir/tests/logging/logging_test_gsmtap 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) +cat $abs_srcdir/logging/logging_gsmtap_test.err > experr +AT_CHECK([$abs_top_builddir/tests/logging/logging_gsmtap_test 3>&1 1>&2 2>&3 |grep -v "enqueueing message failed" 3>&1 1>&2 2>&3 ], [], [ignore], [experr]) AT_CLEANUP AT_SETUP([codec]) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36615?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I280fc0cc1bda9ba445af71f00bc8f1ccfd2b2091 Gerrit-Change-Number: 36615 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange