[S] Change in osmo-e1d[master]: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame loss stats)

2023-12-04 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email )

Change subject: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame 
loss stats)
..

[cosmetic] e1oip.h: Update TODO comment (we have RTT, frame loss stats)

Change-Id: I837676cb3905c0113307ebc400974c3d8cf3a3c7
---
M src/octoi/e1oip.h
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved




diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h
index 9357d48..a17c257 100644
--- a/src/octoi/e1oip.h
+++ b/src/octoi/e1oip.h
@@ -48,6 +48,7 @@

struct rate_ctr_group *ctrs;
struct osmo_stat_item_group *stats;
+   /* TODO: statistics (std deviation, alarms) */

/* configuration data */
struct {
@@ -70,8 +71,6 @@
uint32_t next_fn32; /* next expected frame 
number */
bool primed_rx_tdm; /* Was RX RIFO primed */
} e1t;
-
-   /* TODO: statistics (RTT, frame loss, std deviation, alarms */
 };

 /* get the rate of the given counter during the last second */

--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I837676cb3905c0113307ebc400974c3d8cf3a3c7
Gerrit-Change-Number: 35201
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-MessageType: merged

[S] Change in osmo-e1d[master]: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame loss stats)

2023-12-04 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email )

Change subject: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame 
loss stats)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I837676cb3905c0113307ebc400974c3d8cf3a3c7
Gerrit-Change-Number: 35201
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Comment-Date: Mon, 04 Dec 2023 09:03:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-e1d[master]: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame loss stats)

2023-12-03 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email )


Change subject: [cosmetic] e1oip.h: Update TODO comment (we have RTT, frame 
loss stats)
..

[cosmetic] e1oip.h: Update TODO comment (we have RTT, frame loss stats)

Change-Id: I837676cb3905c0113307ebc400974c3d8cf3a3c7
---
M src/octoi/e1oip.h
1 file changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/01/35201/1

diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h
index 9357d48..a17c257 100644
--- a/src/octoi/e1oip.h
+++ b/src/octoi/e1oip.h
@@ -48,6 +48,7 @@

struct rate_ctr_group *ctrs;
struct osmo_stat_item_group *stats;
+   /* TODO: statistics (std deviation, alarms) */

/* configuration data */
struct {
@@ -70,8 +71,6 @@
uint32_t next_fn32; /* next expected frame 
number */
bool primed_rx_tdm; /* Was RX RIFO primed */
} e1t;
-
-   /* TODO: statistics (RTT, frame loss, std deviation, alarms */
 };

 /* get the rate of the given counter during the last second */

--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35201?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I837676cb3905c0113307ebc400974c3d8cf3a3c7
Gerrit-Change-Number: 35201
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange