[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp Since recent libosmo-mgcp-client update (see Depends), we can now pass fmtp for each individual codec entry to be sent in the SDP. Use that new feature to pass any fmtp from rtp_stream.c to the MGW via MGCP. In effect, this adds the 'octet-align=1', defined in codec_mapping.c as the default for AMR, which was missing from the SDP/MGCP that osmo-msc sends out. A 2G to 2G call worked out OK without it, because omitting the 'octet-align' setting from MGCP disables all octet-align payload checks in osmo-mgw. Both 2G call legs use octet-align=1, and things work out. Running a call from 3G to 2G before this patch would result in osmo-mgw dropping the RTP with logging like: DRTP NOTICE (rtpbridge/1@bsc0 I:B38CF524) rx_rtp(44 bytes): Expected RTP AMR octet-aligned=1 but got octet-aligned=0. check the config of your call-agent! (mgcp_network.c:1527) ...because osmo-bsc's MGW was instructed to expect octet-align=1, while osmo-msc's MGW emits octet-align=0. This happens because converting the 3G IuUP to 2G AMR heeds the RFC 6871 specified default of octet-align=0. Depends: osmo-mgw If58590bda8627519ff07e0b6f43aa47a274f052b Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 --- M src/libmsc/rtp_stream.c 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/35307/1 diff --git a/src/libmsc/rtp_stream.c b/src/libmsc/rtp_stream.c index 1f885c5..38bf2ba 100644 --- a/src/libmsc/rtp_stream.c +++ b/src/libmsc/rtp_stream.c @@ -334,6 +334,7 @@ .codec = m->mgcp, .pt = codec->payload_type, }; + OSMO_STRLCPY_ARRAY(verb_info.ptmap[i].fmtp, codec->fmtp); i++; verb_info.codecs_len = i; verb_info.ptmap_len = i; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 1: (1 comment) Patchset: PS1: needs to merge the mgw patch first, see 'Depends' -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 10 Dec 2023 06:48:12 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Mon, 11 Dec 2023 10:03:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Mon, 11 Dec 2023 15:16:43 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/35307/comment/4fa8d9ab_04d75cad PS2, Line 30: Depends: osmo-mgw If58590bda8627519ff07e0b6f43aa47a274f052b update TODO-RELEASE? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 13 Dec 2023 07:51:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: fixeria, neels, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by pespin, Code-Review+2 by fixeria, Verified-1 by Jenkins Builder Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp Since recent libosmo-mgcp-client update (see Depends), we can now pass fmtp for each individual codec entry to be sent in the SDP. Use that new feature to pass any fmtp from rtp_stream.c to the MGW via MGCP. In effect, this adds the 'octet-align=1', defined in codec_mapping.c as the default for AMR, which was missing from the SDP/MGCP that osmo-msc sends out. A 2G to 2G call worked out OK without it, because omitting the 'octet-align' setting from MGCP disables all octet-align payload checks in osmo-mgw. Both 2G call legs use octet-align=1, and things work out. Running a call from 3G to 2G before this patch would result in osmo-mgw dropping the RTP with logging like: DRTP NOTICE (rtpbridge/1@bsc0 I:B38CF524) rx_rtp(44 bytes): Expected RTP AMR octet-aligned=1 but got octet-aligned=0. check the config of your call-agent! (mgcp_network.c:1527) ...because osmo-bsc's MGW was instructed to expect octet-align=1, while osmo-msc's MGW emits octet-align=0. This happens because converting the 3G IuUP to 2G AMR heeds the RFC 6871 specified default of octet-align=0. So, after this patch, we accurately send "octet-align=1", and make the IuUP-to-AMR conversion emit octet-align=1 to match 2G. Side note: 3GPP specifies AoIP to use bandwidth-efficient AMR only; however, in all known Osmocom world, our 2G BTS emit octet-aligned AMR instead -- so in practice it makes most sense to run osmo-msc with octet-align=1 as the default. osmo-msc shall at some point feature a .cfg option to switch to octet-align=0 to conform with 3GPP, but until then, osmo-msc now configures all AMR to be octet-align=1. Depends: osmo-mgw If58590bda8627519ff07e0b6f43aa47a274f052b Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 --- M TODO-RELEASE M configure.ac M src/libmsc/rtp_stream.c 3 files changed, 44 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/07/35307/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/35307/comment/ca1a5fe7_ae5f24b8 PS2, Line 30: Depends: osmo-mgw If58590bda8627519ff07e0b6f43aa47a274f052b > update TODO-RELEASE? thx! File configure.ac: https://gerrit.osmocom.org/c/osmo-msc/+/35307/comment/0845b657_634afdc3 PS3, Line 48: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.13.0) now this ... it needs the next non-patch release from osmo-mgw.git. There is no 1.13.0 tag yet in osmo-mgw, so master builds will fail with this. But >1.12 is also not sufficient, because 1.12.1 and 1.12.2 will not work. Also >1.12.2 will only work until we do another 1.12.3 patch release. so should I omit this and leave it to release management? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: osmith Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 25 Jan 2024 01:37:47 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith Gerrit-MessageType: comment
[S] Change in osmo-msc[master]: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp
Attention is currently required from: fixeria, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email ) Change subject: SDP/MGCP: pass octet-align=1 for AMR / pass all fmtp .. Patch Set 3: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-msc/+/35307/comment/519b1ac7_5c305e1f PS3, Line 48: PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.13.0) > now this ... […] yes. just mention it in the TODO-RELEASE, and don't change the PKG_CHECK_MODULES line in configure.ac, doing that is part of the release process. https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release#How-to-make-a-new-release -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35307?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ief9225c9bcf7525a9a0a07c282ffb8cc0d092186 Gerrit-Change-Number: 35307 Gerrit-PatchSet: 3 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: osmith Gerrit-Attention: neels Gerrit-Attention: fixeria Gerrit-Attention: pespin Gerrit-Comment-Date: Thu, 25 Jan 2024 07:47:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
