[S] Change in osmo-trx[master]: ms: reduce rx burst queue size

2023-09-20 Thread Hoernchen 
Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email )

Change subject: ms: reduce rx burst queue size
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53
Gerrit-Change-Number: 34272
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 20 Sep 2023 17:50:16 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmo-trx[master]: ms: reduce rx burst queue size

2023-09-20 Thread pespin 
Attention is currently required from: Hoernchen.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email )

Change subject: ms: reduce rx burst queue size
..


Patch Set 5: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53
Gerrit-Change-Number: 34272
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Attention: Hoernchen 
Gerrit-Comment-Date: Wed, 20 Sep 2023 17:52:05 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-trx[master]: ms: reduce rx burst queue size

2023-09-26 Thread fixeria 
Attention is currently required from: Hoernchen.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email )

Change subject: ms: reduce rx burst queue size
..


Patch Set 5: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53
Gerrit-Change-Number: 34272
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-Attention: Hoernchen 
Gerrit-Comment-Date: Tue, 26 Sep 2023 20:36:29 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-trx[master]: ms: reduce rx burst queue size

2023-10-04 Thread Hoernchen 
Hoernchen has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email )

Change subject: ms: reduce rx burst queue size
..

ms: reduce rx burst queue size

This should be fine, because we can at most receive 1.5 bursts of data
at once and produce 2 bursts with previous data, so if this is insufficent the 
usb buffers are late or the upper layer is stuck and we're in trouble anyway.

Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53
---
M Transceiver52M/ms/ms.h
1 file changed, 13 insertions(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  fixeria: Looks good to me, approved




diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h
index 4d0f0cd..18a6954 100644
--- a/Transceiver52M/ms/ms.h
+++ b/Transceiver52M/ms/ms.h
@@ -44,7 +44,6 @@
 #include "threadpool.h"

 const unsigned int ONE_TS_BURST_LEN = (3 + 58 + 26 + 58 + 3 + 8.25) * 4 
/*sps*/;
-const unsigned int NUM_RXQ_FRAMES = 1; // rx thread <-> upper rx queue
 const unsigned int SCH_LEN_SPS = (ONE_TS_BURST_LEN * 8 /*ts*/ * 12 /*frames*/);

 template 
@@ -133,7 +132,7 @@
};
 };

-using rx_queue_t = spsc_cond_timeout<8 * NUM_RXQ_FRAMES, one_burst, true, 
false>;
+using rx_queue_t = spsc_cond_timeout<4, one_burst, true, false>;

 enum class SCH_STATE { SEARCHING, FOUND };


--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34272?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ifb8bf2894c87e4234e3d3f65d66c1e98c8f63c53
Gerrit-Change-Number: 34272
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen 
Gerrit-Reviewer: Hoernchen 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged