[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email ) Change subject: IuUP_Emulation: fix AMR SID SDU size .. IuUP_Emulation: fix AMR SID SDU size See 3GPP TS 26.102 Table 6-2, an AMR SID should have 39 bits. Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b --- M library/IuUP_Emulation.ttcn 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/34537/1 diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn index b649e44..3bda958 100644 --- a/library/IuUP_Emulation.ttcn +++ b/library/IuUP_Emulation.ttcn @@ -35,7 +35,7 @@ } template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_12_2(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {81, 103, 60}, 1); -template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {34, 0, 0}, 7); +template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {39, 0, 0}, 7); template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_NO_DATA(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {0, 0, 0}, 1); @@ -46,7 +46,7 @@ ipti := 1 }, { rfci := 1, - sub_flow_bits := {34, 0, 0}, + sub_flow_bits := {39, 0, 0}, ipti := 7 }, { rfci := 2, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b Gerrit-Change-Number: 34537 Gerrit-PatchSet: 1 Gerrit-Owner: neels Gerrit-MessageType: newchange
[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email ) Change subject: IuUP_Emulation: fix AMR SID SDU size .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b Gerrit-Change-Number: 34537 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 27 Sep 2023 10:29:45 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email ) Change subject: IuUP_Emulation: fix AMR SID SDU size .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b Gerrit-Change-Number: 34537 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 27 Sep 2023 10:44:59 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email ) Change subject: IuUP_Emulation: fix AMR SID SDU size .. Patch Set 2: (1 comment) Patchset: PS2: merging this one on purpose to make it easier to work on the followup patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b Gerrit-Change-Number: 34537 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-Attention: neels Gerrit-Comment-Date: Wed, 27 Sep 2023 10:58:38 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: IuUP_Emulation: fix AMR SID SDU size
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email ) Change subject: IuUP_Emulation: fix AMR SID SDU size .. IuUP_Emulation: fix AMR SID SDU size See 3GPP TS 26.102 Table 6-2, an AMR SID should have 39 bits. Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b --- M library/IuUP_Emulation.ttcn 1 file changed, 13 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/IuUP_Emulation.ttcn b/library/IuUP_Emulation.ttcn index b649e44..3bda958 100644 --- a/library/IuUP_Emulation.ttcn +++ b/library/IuUP_Emulation.ttcn @@ -35,7 +35,7 @@ } template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_12_2(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {81, 103, 60}, 1); -template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {34, 0, 0}, 7); +template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_SID(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {39, 0, 0}, 7); template (value) IuUP_RabFlowCombination t_IuUP_RFC_AMR_NO_DATA(IuUP_RFCI rfci) := t_IuUP_RFC(rfci, {0, 0, 0}, 1); @@ -46,7 +46,7 @@ ipti := 1 }, { rfci := 1, - sub_flow_bits := {34, 0, 0}, + sub_flow_bits := {39, 0, 0}, ipti := 7 }, { rfci := 2, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34537?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9afb28ca6e23f7976edcc130ea012be34e04eb4b Gerrit-Change-Number: 34537 Gerrit-PatchSet: 2 Gerrit-Owner: neels Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Reviewer: pespin Gerrit-MessageType: merged