[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: make PCUIF_info_ind field bts_model optional
dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email )
Change subject: PCUIF_Types: make PCUIF_info_ind field bts_model optional
..
PCUIF_Types: make PCUIF_info_ind field bts_model optional
The field bts_model has been introduced with PCUIF v12, which is now
used in master. In latest we still use PCUIF v11, where the bts_model
field is not present. This means that when we test against osmo-bts
latest there will be an error parsing PCUIF_info_ind. A solution to this
problem is to declare the bts_model field as an optional field until
PCUIF v12 is also used in latest.
Related: OS#6191
Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a
---
M library/PCUIF_Types.ttcn
1 file changed, 24 insertions(+), 2 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 12c704f..33b454f 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -212,7 +212,11 @@
record length(2) of uint16_tremote_port,
PCUIF_RemoteAddrremote_addr,
- PCUIF_bts_model bts_model
+ /* The bts_model field was introduced with PCUIF v12 as a new mandatory
field. This also means that when we
+* use the testsuite to test against latest builds (still uses PCUIF
v11) this field is not included in
+* the PCUIF_info_ind message. Since the testsuite does not check on
this field we decided to declare the
+* field as an optional field until PCUIF v12 is also used in the
latest builds.*/
+ PCUIF_bts_model bts_model optional
} with { variant "" };
type enumerated PCUIF_AddrType {
@@ -992,7 +996,8 @@
local_port := ?,
remote_port := ?,
remote_addr := ?,
- bts_model := ?
+ /* See note in record PCUIF_info_ind */
+ bts_model := *
}
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a
Gerrit-Change-Number: 35090
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: laforge
Gerrit-Reviewer: osmith
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: make PCUIF_info_ind field bts_model optional
Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email ) Change subject: PCUIF_Types: make PCUIF_info_ind field bts_model optional .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a Gerrit-Change-Number: 35090 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 22 Nov 2023 15:54:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: make PCUIF_info_ind field bts_model optional
Attention is currently required from: dexter, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email ) Change subject: PCUIF_Types: make PCUIF_info_ind field bts_model optional .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a Gerrit-Change-Number: 35090 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: osmith Gerrit-Attention: osmith Gerrit-Attention: dexter Gerrit-Comment-Date: Wed, 22 Nov 2023 15:17:27 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: PCUIF_Types: make PCUIF_info_ind field bts_model optional
dexter has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email )
Change subject: PCUIF_Types: make PCUIF_info_ind field bts_model optional
..
PCUIF_Types: make PCUIF_info_ind field bts_model optional
The field bts_model has been introduced with PCUIF v12, which is now
used in master. In latest we still use PCUIF v11, where the bts_model
field is not present. This means that when we test against osmo-bts
latest there will be an error parsing PCUIF_info_ind. A solution to this
problem is to declare the bts_model field as an optional field until
PCUIF v12 is also used in latest.
Related: OS#6191
Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a
---
M library/PCUIF_Types.ttcn
1 file changed, 24 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/90/35090/1
diff --git a/library/PCUIF_Types.ttcn b/library/PCUIF_Types.ttcn
index 12c704f..33b454f 100644
--- a/library/PCUIF_Types.ttcn
+++ b/library/PCUIF_Types.ttcn
@@ -212,7 +212,11 @@
record length(2) of uint16_tremote_port,
PCUIF_RemoteAddrremote_addr,
- PCUIF_bts_model bts_model
+ /* The bts_model field was introduced with PCUIF v12 as a new mandatory
field. This also means that when we
+* use the testsuite to test against latest builds (still uses PCUIF
v11) this field is not included in
+* the PCUIF_info_ind message. Since the testsuite does not check on
this field we decided to declare the
+* field as an optional field until PCUIF v12 is also used in the
latest builds.*/
+ PCUIF_bts_model bts_model optional
} with { variant "" };
type enumerated PCUIF_AddrType {
@@ -992,7 +996,8 @@
local_port := ?,
remote_port := ?,
remote_addr := ?,
- bts_model := ?
+ /* See note in record PCUIF_info_ind */
+ bts_model := *
}
}
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35090?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I45947f3bddaccafee82824ebb1b8494eabc67e7a
Gerrit-Change-Number: 35090
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
Gerrit-MessageType: newchange
