[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-02 Thread pespin 
pespin has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email )


Change subject: hnbgw: Introduce mp_hnbgw_timer_x31
..

hnbgw: Introduce mp_hnbgw_timer_x31

The default value of the timer changed recently, and made some tests
which were using some timer hardcoded values fail.
Add this configurable option to adapt the test behavior to the
osmo-hnbgw configuration. This way we can also set it to lower values in
order to avoid waiting too much time.

Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
---
M hnbgw/HNBGW_Tests.ttcn
M hnbgw/osmo-hnbgw.cfg
2 files changed, 21 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/51/34951/1

diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index 4afb8dd..505beab 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -194,6 +194,10 @@
charstring mp_pfcp_ip_remote := "127.0.0.2";

boolean mp_validate_talloc_asn1 := true;
+
+   /* The X31 timer configured at osmo-hnbgw (seconds). This provided an 
idea on
+* minimum time the test must wait to consider this timer triggered */
+   integer mp_hnbgw_timer_x31 := 5;
 }

 function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return 
template RANAP_PDU {
@@ -763,7 +767,7 @@
 template RANAP_PDU exp_rx := omit)
 runs on ConnHdlr return RANAP_PDU {
var RANAP_PDU rx
-   timer T := 10.0;
+   timer T := int2float(mp_hnbgw_timer_x31) + 1.0;

if (istemplatekind(exp_rx, "omit")) {
exp_rx := tx;
diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg
index 3ccc28d..edd8c21 100644
--- a/hnbgw/osmo-hnbgw.cfg
+++ b/hnbgw/osmo-hnbgw.cfg
@@ -49,6 +49,7 @@
   local-ip 127.0.0.1
   local-port 29169
   hnbap-allow-tmsi 1
+ timer hnbgw x31 5
  # don't spam RANAP RESET messages for up to eight CN links across all tests
  timer hnbgw T4 60


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
Gerrit-Change-Number: 34951
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-MessageType: newchange

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-02 Thread osmith 
Attention is currently required from: laforge, neels, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email )

Change subject: hnbgw: Introduce mp_hnbgw_timer_x31
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
Gerrit-Change-Number: 34951
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Attention: neels 
Gerrit-Attention: laforge 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Thu, 02 Nov 2023 11:57:12 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-03 Thread laforge 
Attention is currently required from: neels, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email )

Change subject: hnbgw: Introduce mp_hnbgw_timer_x31
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
Gerrit-Change-Number: 34951
Gerrit-PatchSet: 1
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-Attention: neels 
Gerrit-Attention: pespin 
Gerrit-Comment-Date: Fri, 03 Nov 2023 19:43:07 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce mp_hnbgw_timer_x31

2023-11-03 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email )

Change subject: hnbgw: Introduce mp_hnbgw_timer_x31
..

hnbgw: Introduce mp_hnbgw_timer_x31

The default value of the timer changed recently, and made some tests
which were using some timer hardcoded values fail.
Add this configurable option to adapt the test behavior to the
osmo-hnbgw configuration. This way we can also set it to lower values in
order to avoid waiting too much time.

Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
---
M hnbgw/HNBGW_Tests.ttcn
M hnbgw/osmo-hnbgw.cfg
2 files changed, 21 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve




diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn
index 4afb8dd..505beab 100644
--- a/hnbgw/HNBGW_Tests.ttcn
+++ b/hnbgw/HNBGW_Tests.ttcn
@@ -194,6 +194,10 @@
charstring mp_pfcp_ip_remote := "127.0.0.2";

boolean mp_validate_talloc_asn1 := true;
+
+   /* The X31 timer configured at osmo-hnbgw (seconds). This provided an 
idea on
+* minimum time the test must wait to consider this timer triggered */
+   integer mp_hnbgw_timer_x31 := 5;
 }

 function MSC_UnitdataCallback(RANAP_PDU ranap) runs on RAN_Emulation_CT return 
template RANAP_PDU {
@@ -763,7 +767,7 @@
 template RANAP_PDU exp_rx := omit)
 runs on ConnHdlr return RANAP_PDU {
var RANAP_PDU rx
-   timer T := 10.0;
+   timer T := int2float(mp_hnbgw_timer_x31) + 1.0;

if (istemplatekind(exp_rx, "omit")) {
exp_rx := tx;
diff --git a/hnbgw/osmo-hnbgw.cfg b/hnbgw/osmo-hnbgw.cfg
index 3ccc28d..edd8c21 100644
--- a/hnbgw/osmo-hnbgw.cfg
+++ b/hnbgw/osmo-hnbgw.cfg
@@ -49,6 +49,7 @@
   local-ip 127.0.0.1
   local-port 29169
   hnbap-allow-tmsi 1
+ timer hnbgw x31 5
  # don't spam RANAP RESET messages for up to eight CN links across all tests
  timer hnbgw T4 60


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34951?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I176ef96e193f2ca39077bcee3a2187768ddb45ce
Gerrit-Change-Number: 34951
Gerrit-PatchSet: 2
Gerrit-Owner: pespin 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: neels 
Gerrit-Reviewer: osmith 
Gerrit-MessageType: merged