[S] Change in osmo-ttcn3-hacks[master]: pcu: Fail immediately in TC_n3105_max_t3195
pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email )
Change subject: pcu: Fail immediately in TC_n3105_max_t3195
..
pcu: Fail immediately in TC_n3105_max_t3195
Change-Id: I55b97037c014478451790e1943c617a634fe2457
---
M pcu/PCU_Tests.ttcn
1 file changed, 19 insertions(+), 4 deletions(-)
Approvals:
osmith: Looks good to me, but someone else must approve
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 012a0be..ffad7e6 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1955,7 +1955,6 @@
var integer N3105 := 0;
timer T_3195 := 1.0;
var integer num_poll_recv := 0;
- var template RlcmacDlBlock dl_block_exp;
/* Initialize NS/BSSGP side */
f_init_bssgp();
@@ -2041,10 +2040,17 @@
log("T_3195 timeout");
/* Done in alt, wait for pending RTS initiated previously in
* above case before continuing (expect empty block): */
- dl_block_exp := omit;
- BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ alt {
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
- dl_block_exp));
+ omit)); /* DONE, continue after
altstep. */
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
+ tr_RLCMAC_DL_DUMMY_CTRL)) {
+ setverdict(fail, "Rx unexpected DUMMY message, expected
empty data block");
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ }
}
[] BTS.receive {
setverdict(fail, "Unexpected BTS message");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I55b97037c014478451790e1943c617a634fe2457
Gerrit-Change-Number: 34536
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: osmith
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
[S] Change in osmo-ttcn3-hacks[master]: pcu: Fail immediately in TC_n3105_max_t3195
Attention is currently required from: dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email ) Change subject: pcu: Fail immediately in TC_n3105_max_t3195 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I55b97037c014478451790e1943c617a634fe2457 Gerrit-Change-Number: 34536 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter Gerrit-Reviewer: fixeria Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Attention: dexter Gerrit-Comment-Date: Thu, 28 Sep 2023 15:04:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: pcu: Fail immediately in TC_n3105_max_t3195
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email ) Change subject: pcu: Fail immediately in TC_n3105_max_t3195 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I55b97037c014478451790e1943c617a634fe2457 Gerrit-Change-Number: 34536 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith Gerrit-Attention: pespin Gerrit-Comment-Date: Wed, 27 Sep 2023 10:32:30 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[S] Change in osmo-ttcn3-hacks[master]: pcu: Fail immediately in TC_n3105_max_t3195
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email )
Change subject: pcu: Fail immediately in TC_n3105_max_t3195
..
pcu: Fail immediately in TC_n3105_max_t3195
Change-Id: I55b97037c014478451790e1943c617a634fe2457
---
M pcu/PCU_Tests.ttcn
1 file changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/36/34536/1
diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn
index 6917404..45b1883 100644
--- a/pcu/PCU_Tests.ttcn
+++ b/pcu/PCU_Tests.ttcn
@@ -1955,7 +1955,6 @@
var integer N3105 := 0;
timer T_3195 := 1.0 + 0.1; /* 0.1: some extra time to avoid race
conditions between test and IUT */
var integer num_poll_recv := 0;
- var template RlcmacDlBlock dl_block_exp;
/* Initialize NS/BSSGP side */
f_init_bssgp();
@@ -2041,10 +2040,17 @@
log("T_3195 timeout");
/* Done in alt, wait for pending RTS initiated previously in
* above case before continuing (expect empty block): */
- dl_block_exp := omit;
- BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ alt {
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
- dl_block_exp));
+ omit)); /* DONE, continue after
altstep. */
+ [] BTS.receive(tr_PCUIF_DATA_PDTCH(nr.bts_nr,
+ tr_PCUIF_DATA(nr.trx_nr,
nr.ts_nr, sapi := PCU_IF_SAPI_PDTCH),
+ tr_RLCMAC_DL_DUMMY_CTRL)) {
+ setverdict(fail, "Rx unexpected DUMMY message, expected
empty data block");
+ f_shutdown(__BFILE__, __LINE__);
+ }
+ }
}
[] BTS.receive {
setverdict(fail, "Unexpected BTS message");
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34536?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I55b97037c014478451790e1943c617a634fe2457
Gerrit-Change-Number: 34536
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
