[S] Change in osmocom-bb[master]: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH transmissions

2024-02-01 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email )


Change subject: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH 
transmissions
..

[HACK] trxcon/l1sched: warn about incomplete UL PDTCH transmissions

Change-Id: Id485c919ca87a9edfb8bc974d73fb88638bfc510
---
M src/host/trxcon/src/sched_trx.c
1 file changed, 21 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/68/35768/1

diff --git a/src/host/trxcon/src/sched_trx.c b/src/host/trxcon/src/sched_trx.c
index f412400..bb6fbd8 100644
--- a/src/host/trxcon/src/sched_trx.c
+++ b/src/host/trxcon/src/sched_trx.c
@@ -513,6 +513,18 @@
lchan->tdma.last_proc);
}

+#if 1
+   /* XXX: GPRS specific logic in generic code path */
+   if (lchan->type == L1SCHED_PDTCH) {
+   uint32_t mask = lchan->tx_burst_mask & 0x0f;
+   if (mask != 0x00 && mask != 0x0f) {
+   LOGP_LCHANC(lchan, LOGL_ERROR,
+   "%s(): current Tx prim not fully 
transmitted\n",
+   __func__);
+   }
+   }
+#endif
+
/* Reset internal state variables */
lchan->rx_burst_mask = 0x00;
lchan->tx_burst_mask = 0x00;

--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id485c919ca87a9edfb8bc974d73fb88638bfc510
Gerrit-Change-Number: 35768
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

[S] Change in osmocom-bb[master]: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH transmissions

2024-02-01 Thread Jenkins Builder 
Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email )

Change subject: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH 
transmissions
..


Patch Set 1:

(1 comment)

File src/host/trxcon/src/sched_trx.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13977):
https://gerrit.osmocom.org/c/osmocom-bb/+/35768/comment/24da1436_54105de5
PS1, Line 516: #if 1
Consider removing the #if 1 and its #endif



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id485c919ca87a9edfb8bc974d73fb88638bfc510
Gerrit-Change-Number: 35768
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Feb 2024 17:37:02 +
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[S] Change in osmocom-bb[master]: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH transmissions

2024-02-14 Thread fixeria 
fixeria has abandoned this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email )

Change subject: [HACK] trxcon/l1sched: warn about incomplete UL PDTCH 
transmissions
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35768?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id485c919ca87a9edfb8bc974d73fb88638bfc510
Gerrit-Change-Number: 35768
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: abandon