[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#16). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- M src/host/layer23/include/osmocom/bb/mobile/Makefile.am A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,069 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/16 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 16 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#15). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- M src/host/layer23/include/osmocom/bb/mobile/Makefile.am A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,069 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/15 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 15 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 14: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 14 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Sat, 30 Sep 2023 09:13:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 9 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Tue, 26 Sep 2023 12:31:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 7: (1 comment) File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/7650cb61_d05e4ddc PS6, Line 74: LOGP((trans->protocol == GSM48_PDISC_GROUP_CC) ? DGCC : DBCC, level, \ > missing () around trans. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: pespin Gerrit-Comment-Date: Tue, 26 Sep 2023 10:26:48 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- M src/host/layer23/include/osmocom/bb/mobile/Makefile.am A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,069 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/7 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 7 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Attention: pespin Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 6: Code-Review+1 (1 comment) File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/64e18480_e548a755 PS6, Line 74: LOGP((trans->protocol == GSM48_PDISC_GROUP_CC) ? DGCC : DBCC, level, \ missing () around trans. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 6 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: jolly Gerrit-Comment-Date: Thu, 21 Sep 2023 14:31:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- M src/host/layer23/include/osmocom/bb/mobile/Makefile.am A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,069 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/5 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 5 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 10 files changed, 2,068 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 4 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 3: (1 comment) File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11211): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/4c564705_f5ac7ed5 PS3, Line 74: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 3 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-Comment-Date: Thu, 21 Sep 2023 11:05:13 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email ) Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. Patch Set 2: (1 comment) File src/host/layer23/include/osmocom/bb/mobile/transaction.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11192): https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ce16c824_c2806631 PS2, Line 74: /* Flag to tell the state machine that call changes from seperate link to group receive mode. */ 'seperate' may be misspelled - perhaps 'separate'? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-Comment-Date: Thu, 21 Sep 2023 10:35:07 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Attention is currently required from: jolly. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls .. ASCI: Add GCC/BCC layer to support voice group/broadcast calls Related: OS#5364 Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d --- A src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h M src/host/layer23/include/osmocom/bb/mobile/gsm48_mm.h M src/host/layer23/include/osmocom/bb/mobile/transaction.h M src/host/layer23/src/mobile/Makefile.am M src/host/layer23/src/mobile/app_mobile.c M src/host/layer23/src/mobile/gsm411_sms.c A src/host/layer23/src/mobile/gsm44068_gcc_bcc.c M src/host/layer23/src/mobile/gsm480_ss.c M src/host/layer23/src/mobile/gsm48_cc.c M src/host/layer23/src/mobile/gsm48_mm.c M src/host/layer23/src/mobile/transaction.c 11 files changed, 2,072 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/34494/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I22eacd018f18c18ba83dbd3dd874cf029344674d Gerrit-Change-Number: 34494 Gerrit-PatchSet: 2 Gerrit-Owner: jolly Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: jolly Gerrit-MessageType: newpatchset
[XL] Change in osmocom-bb[master]: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/34494?usp=email )
Change subject: ASCI: Add GCC/BCC layer to support voice group/broadcast calls
..
Patch Set 1:
(29 comments)
File src/host/layer23/include/osmocom/bb/mobile/gsm44068_gcc_bcc.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/bd9081a1_6a2e5fb0
PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE,
GSM44068_ALLOC_HEADROOM, name);
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/da7d76ca_023201c4
PS1, Line 30: return msgb_alloc_headroom(GSM44068_ALLOC_SIZE,
GSM44068_ALLOC_HEADROOM, name);
please, no spaces at the start of a line
File src/host/layer23/include/osmocom/bb/mobile/transaction.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b77e959c_d23480de
PS1, Line 75: /* Flag to tell the state machine that call
changes from seperate link to group receive mode. */
'seperate' may be misspelled - perhaps 'separate'?
File src/host/layer23/src/mobile/gsm411_sms.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5b0fda21_e73c440d
PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) {
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68a1ede4_e07fd5cb
PS1, Line 656: if (trans_find_ongoing_gcc_bcc(ms)) {
please, no spaces at the start of a line
File src/host/layer23/src/mobile/gsm44068_gcc_bcc.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/793eab65_fca6b0b5
PS1, Line 31: * If it comes avaiable, the establishment is performed and the
U4 is entered.
'avaiable' may be misspelled - perhaps 'available'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/293fbff0_2a0edf29
PS1, Line 545: struct gsm48_uplink_release *ur = (struct
gsm48_uplink_release *) msgb_put(msg, sizeof(*ur));
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/4eaf8fe2_9d4b2b9f
PS1, Line 545: struct gsm48_uplink_release *ur = (struct
gsm48_uplink_release *) msgb_put(msg, sizeof(*ur));
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/0b6c939a_ae98a37c
PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/68779e83_d9c3ce5b
PS1, Line 549: gh->proto_discr = GSM48_PDISC_RR;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/02fe4002_39714356
PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/54f8e44c_086c229c
PS1, Line 550: gh->msg_type = GSM48_MT_RR_UPLINK_RELEASE;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ebbbc15c_c45ccc08
PS1, Line 551: ur->rr_cause = cause;
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/ad95be92_82937a54
PS1, Line 551: ur->rr_cause = cause;
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/b7d10ada_814a4bbd
PS1, Line 691: /* Change to GROUP CALL ACTIVE (seperate link) state. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/6a758d03_9d6fefc2
PS1, Line 780: /* Set flag that we change to group receive mode after
seperate link. */
'seperate' may be misspelled - perhaps 'separate'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11177):
https://gerrit.osmocom.org/c/osmocom-bb/+/34494/comment/5d26883b_e9a84ed8
PS1, Line 821: /* Reset flag
