Change in ...libosmo-sccp[master]: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 ) Change subject: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae Gerrit-Change-Number: 15062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 29 Aug 2019 05:28:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-sccp[master]: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 ) Change subject: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 .. osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 When using osmo_sccp_simple_client(), it will create an sccp instance if none exists. The sccp instance identifier starts with 0. The implicit created instance should use sccp instance 0 (the first connection). Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae --- M src/sccp_user.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved neels: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sccp_user.c b/src/sccp_user.c index 63eba2a..ff5eb08 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -635,7 +635,7 @@ * the only difference is that the ID of the CS7 instance will be * set to 1 statically */ - return osmo_sccp_simple_client_on_ss7_id(ctx, 1, name, default_pc, prot, + return osmo_sccp_simple_client_on_ss7_id(ctx, 0, name, default_pc, prot, default_local_port, default_local_ip, default_remote_port, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae Gerrit-Change-Number: 15062 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: merged
Change in ...libosmo-sccp[master]: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 ) Change subject: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae Gerrit-Change-Number: 15062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-Comment-Date: Thu, 29 Aug 2019 04:05:16 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...libosmo-sccp[master]: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1
Hello neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 to look at the new patch set (#2). Change subject: osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 .. osmo_sccp_simple_client(): use sccp instance index 0 instead of 1 When using osmo_sccp_simple_client(), it will create an sccp instance if none exists. The sccp instance identifier starts with 0. The implicit created instance should use sccp instance 0 (the first connection). Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae --- M src/sccp_user.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/62/15062/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9d9f6b9cdc1e3c697c8b834528d51878e1ae Gerrit-Change-Number: 15062 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: neels Gerrit-MessageType: newpatchset
