Change in ...osmo-bsc[master]: bsc: Append Osmux Support IE only on AoIP
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14384 ) Change subject: bsc: Append Osmux Support IE only on AoIP .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I802fc65c593e42aaa7a15cecab7a2f2b77ade3ea Gerrit-Change-Number: 14384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Jun 2019 19:43:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-bsc[master]: bsc: Append Osmux Support IE only on AoIP
laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14384 ) Change subject: bsc: Append Osmux Support IE only on AoIP .. bsc: Append Osmux Support IE only on AoIP Since in SCCPlite the BSC-attached MGW is controlled by the MSC, we don't need this kind of signalling. It's only needed for AoIP. Related: OS#2551 Change-Id: I802fc65c593e42aaa7a15cecab7a2f2b77ade3ea --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 8303c4f..18f269d 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -101,7 +101,7 @@ LOGP(DMSC, LOGL_NOTICE, "Sending RESET to MSC: %s\n", osmo_sccp_addr_name(ss7, >a.msc_addr)); msg = gsm0808_create_reset(); - if (msc->use_osmux != OSMUX_USAGE_OFF) + if (msc_is_aoip(msc) && msc->use_osmux != OSMUX_USAGE_OFF) _gsm0808_extend_announce_osmux(msg); osmo_sccp_tx_unitdata_msg(msc->a.sccp_user, >a.bsc_addr, @@ -120,7 +120,7 @@ LOGP(DMSC, LOGL_NOTICE, "Sending RESET ACK to MSC: %s\n", osmo_sccp_addr_name(ss7, >a.msc_addr)); msg = gsm0808_create_reset_ack(); - if (msc->use_osmux != OSMUX_USAGE_OFF) + if (msc_is_aoip(msc) && msc->use_osmux != OSMUX_USAGE_OFF) _gsm0808_extend_announce_osmux(msg); osmo_sccp_tx_unitdata_msg(msc->a.sccp_user, >a.bsc_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I802fc65c593e42aaa7a15cecab7a2f2b77ade3ea Gerrit-Change-Number: 14384 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in ...osmo-bsc[master]: bsc: Append Osmux Support IE only on AoIP
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14384 Change subject: bsc: Append Osmux Support IE only on AoIP .. bsc: Append Osmux Support IE only on AoIP Since in SCCPlite the BSC-attached MGW is controlled by the MSC, we don't need this kind of signalling. It's only needed for AoIP. Related: OS#2551 Change-Id: I802fc65c593e42aaa7a15cecab7a2f2b77ade3ea --- M src/osmo-bsc/osmo_bsc_sigtran.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/84/14384/1 diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index 8303c4f..18f269d 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -101,7 +101,7 @@ LOGP(DMSC, LOGL_NOTICE, "Sending RESET to MSC: %s\n", osmo_sccp_addr_name(ss7, >a.msc_addr)); msg = gsm0808_create_reset(); - if (msc->use_osmux != OSMUX_USAGE_OFF) + if (msc_is_aoip(msc) && msc->use_osmux != OSMUX_USAGE_OFF) _gsm0808_extend_announce_osmux(msg); osmo_sccp_tx_unitdata_msg(msc->a.sccp_user, >a.bsc_addr, @@ -120,7 +120,7 @@ LOGP(DMSC, LOGL_NOTICE, "Sending RESET ACK to MSC: %s\n", osmo_sccp_addr_name(ss7, >a.msc_addr)); msg = gsm0808_create_reset_ack(); - if (msc->use_osmux != OSMUX_USAGE_OFF) + if (msc_is_aoip(msc) && msc->use_osmux != OSMUX_USAGE_OFF) _gsm0808_extend_announce_osmux(msg); osmo_sccp_tx_unitdata_msg(msc->a.sccp_user, >a.bsc_addr, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/14384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I802fc65c593e42aaa7a15cecab7a2f2b77ade3ea Gerrit-Change-Number: 14384 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
