Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
Hoernchen has submitted this change and it was merged. (
https://gerrit.osmocom.org/c/osmo-msc/+/14448 )
Change subject: libvlr: fix sgsn tmsi creation, replace constant with define
..
libvlr: fix sgsn tmsi creation, replace constant with define
reported by _dev_zero in #osmocom
Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba
Depends-On: libosmocore I52b9f6b5f3e96d85a390ba2af21d7814df8aaeec
---
M src/libvlr/vlr.c
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Hoernchen: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 2753096..5610cfb 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -336,11 +336,11 @@
/* Section 2.4 of 23.003: MSC has two MSB 00/01/10, SGSN 11 */
if (vlr->cfg.is_ps) {
/* SGSN */
- tmsi |= 0xC00;
+ tmsi |= GSM23003_TMSI_SGSN_MASK;
} else {
/* MSC */
- if ((tmsi & 0xC000) == 0xC000)
- tmsi &= ~0xC000;
+ if ((tmsi & GSM23003_TMSI_SGSN_MASK) ==
GSM23003_TMSI_SGSN_MASK)
+ tmsi &= ~GSM23003_TMSI_SGSN_MASK;
}
/* If this TMSI is already in use, try another one. */
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba
Gerrit-Change-Number: 14448
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen
Gerrit-Reviewer: Hoernchen
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: pespin
Gerrit-CC: laforge
Gerrit-MessageType: merged
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 17 Jun 2019 12:51:25 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 17 Jun 2019 12:18:56 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 to look at the new patch set (#5). Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. libvlr: fix sgsn tmsi creation, replace constant with define reported by _dev_zero in #osmocom Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Depends-On: libosmocore I52b9f6b5f3e96d85a390ba2af21d7814df8aaeec --- M src/libvlr/vlr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/14448/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
Hello fixeria, pespin, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 to look at the new patch set (#4). Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. libvlr: fix sgsn tmsi creation, replace constant with define reported by _dev_zero in #osmocom Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Depends: libosmocore I52b9f6b5f3e96d85a390ba2af21d7814df8aaeec --- M src/libvlr/vlr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/14448/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/14448/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/14448/3//COMMIT_MSG@11 PS3, Line 11: Change-Id BTW: feel free to specify the related change in libosmocore here using: 'Depends-On: ', right after 'Change-Id'. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 17 Jun 2019 11:51:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 17 Jun 2019 11:49:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: laforge Gerrit-Comment-Date: Mon, 17 Jun 2019 10:13:22 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with define
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 to look at the new patch set (#3). Change subject: libvlr: fix sgsn tmsi creation, replace constant with define .. libvlr: fix sgsn tmsi creation, replace constant with define reported by _dev_zero in #osmocom Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba --- M src/libvlr/vlr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/14448/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation, replace constant with
Hello fixeria, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 to look at the new patch set (#2). Change subject: libvlr: fix sgsn tmsi creation, replace constant with .. libvlr: fix sgsn tmsi creation, replace constant with reported by _dev_zero in #osmocom Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba --- M src/libvlr/vlr.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/14448/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-MessageType: newpatchset
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation .. Patch Set 1: gsm_23_003.h -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 14 Jun 2019 16:39:17 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c@339 PS1, Line 339: 0xC000 > Nice catch of course, but where does this magic constant comes from? I also > see it's used in OsmoSG […] Indeed, we should add this to include/osmocom/gsm/protocol/gms_23003.h and then use it here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-CC: laforge Gerrit-Comment-Date: Fri, 14 Jun 2019 16:38:56 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/14448/1/src/libvlr/vlr.c@339 PS1, Line 339: 0xC000 Nice catch of course, but where does this magic constant comes from? I also see it's used in OsmoSGSN, so maybe we should introduce some #define in libosmocore? We already have GSM_RESERVED_TMSI there. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba Gerrit-Change-Number: 14448 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen Gerrit-Reviewer: Hoernchen Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 14 Jun 2019 15:13:39 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation
Hoernchen has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-msc/+/14448
Change subject: libvlr: fix sgsn tmsi creation
..
libvlr: fix sgsn tmsi creation
reported by _dev_zero in #osmocom
Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba
---
M src/libvlr/vlr.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/14448/1
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 2753096..63f156d 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -336,7 +336,7 @@
/* Section 2.4 of 23.003: MSC has two MSB 00/01/10, SGSN 11 */
if (vlr->cfg.is_ps) {
/* SGSN */
- tmsi |= 0xC00;
+ tmsi |= 0xC000;
} else {
/* MSC */
if ((tmsi & 0xC000) == 0xC000)
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/14448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib5679ab5d06b6ef735725b4a68eeb1e9cbcc11ba
Gerrit-Change-Number: 14448
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen
Gerrit-MessageType: newchange
