Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 Change subject: radioInterface: Mark setRxGain as virtual .. radioInterface: Mark setRxGain as virtual Otherwise the parent function is always called even if the iface is radioInterfaceMult. Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a --- M Transceiver52M/radioInterface.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/41/15541/1 diff --git a/Transceiver52M/radioInterface.h b/Transceiver52M/radioInterface.h index 6f4deaa..d72fb69 100644 --- a/Transceiver52M/radioInterface.h +++ b/Transceiver52M/radioInterface.h @@ -107,7 +107,7 @@ virtual bool tuneRx(double freq, size_t chan = 0); /** set receive gain */ - double setRxGain(double dB, size_t chan = 0); + virtual double setRxGain(double dB, size_t chan = 0); /** drive transmission of GSM bursts */ void driveTransmitRadio(std::vector &bursts, @@ -182,5 +182,5 @@ bool tuneTx(double freq, size_t chan); bool tuneRx(double freq, size_t chan); - double setRxGain(double dB, size_t chan); + virtual double setRxGain(double dB, size_t chan); }; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a Gerrit-Change-Number: 15541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-MessageType: newchange
Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a Gerrit-Change-Number: 15541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Comment-Date: Wed, 18 Sep 2019 13:17:23 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a Gerrit-Change-Number: 15541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Wed, 18 Sep 2019 17:50:12 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a Gerrit-Change-Number: 15541 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Comment-Date: Fri, 20 Sep 2019 15:07:08 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in ...osmo-trx[master]: radioInterface: Mark setRxGain as virtual
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-trx/+/15541 ) Change subject: radioInterface: Mark setRxGain as virtual .. radioInterface: Mark setRxGain as virtual Otherwise the parent function is always called even if the iface is radioInterfaceMult. Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a --- M Transceiver52M/radioInterface.h 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/Transceiver52M/radioInterface.h b/Transceiver52M/radioInterface.h index 83e00b9..b12c187 100644 --- a/Transceiver52M/radioInterface.h +++ b/Transceiver52M/radioInterface.h @@ -107,7 +107,7 @@ virtual bool tuneRx(double freq, size_t chan = 0); /** set receive gain */ - double setRxGain(double dB, size_t chan = 0); + virtual double setRxGain(double dB, size_t chan = 0); /** drive transmission of GSM bursts */ void driveTransmitRadio(std::vector &bursts, @@ -182,5 +182,5 @@ bool tuneTx(double freq, size_t chan); bool tuneRx(double freq, size_t chan); - double setRxGain(double dB, size_t chan); + virtual double setRxGain(double dB, size_t chan); }; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/15541 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie41efab1e60b88677bbd1ec333ea656794503a5a Gerrit-Change-Number: 15541 Gerrit-PatchSet: 2 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
