Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

2019-08-19 Thread osmith 
osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157 )

Change subject: RAN_Adapter: invert check for RAN_ops == omit
..


Patch Set 2:

Unfortunately this patch broke the bsc tests. Reverted: 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15233


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-CC: osmith 
Gerrit-Comment-Date: Mon, 19 Aug 2019 11:51:47 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

2019-08-18 Thread laforge 
laforge has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157 )

Change subject: RAN_Adapter: invert check for RAN_ops == omit
..

RAN_Adapter: invert check for RAN_ops == omit

The SGSN_Tests.ttcn run into bugs when doing the isvalue() check on a const 
object.
Check explicit for "omit" to skip creation of the vc_RAN object

Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
---
M library/RAN_Adapter.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index e995e8d..8e19241 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -90,7 +90,7 @@

/* create components */
ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");
-   if (isvalue(ops)) {
+   if (not istemplatekind(ops, "omit")) {
ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN");
}
select (cfg.transport) {
@@ -142,7 +142,7 @@
}
}

-   if (isvalue(ops)) {
+   if (not istemplatekind(ops, "omit")) {
timer T := 5.0;
T.start;
//T.timeout;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

2019-08-13 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157 )

Change subject: RAN_Adapter: invert check for RAN_ops == omit
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Tue, 13 Aug 2019 10:50:30 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

2019-08-12 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157 )

Change subject: RAN_Adapter: invert check for RAN_ops == omit
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 12 Aug 2019 13:41:50 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...osmo-ttcn3-hacks[master]: RAN_Adapter: invert check for RAN_ops == omit

2019-08-12 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157


Change subject: RAN_Adapter: invert check for RAN_ops == omit
..

RAN_Adapter: invert check for RAN_ops == omit

The SGSN_Tests.ttcn run into bugs when doing the isvalue() check on a const 
object.
Check explicit for "omit" to skip creation of the vc_RAN object

Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
---
M library/RAN_Adapter.ttcnpp
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/57/15157/1

diff --git a/library/RAN_Adapter.ttcnpp b/library/RAN_Adapter.ttcnpp
index e995e8d..8e19241 100644
--- a/library/RAN_Adapter.ttcnpp
+++ b/library/RAN_Adapter.ttcnpp
@@ -90,7 +90,7 @@

/* create components */
ba.vc_SCCP := SCCP_CT.create(id & "-SCCP");
-   if (isvalue(ops)) {
+   if (not istemplatekind(ops, "omit")) {
ba.vc_RAN := RAN_Emulation_CT.create(id & "-RAN");
}
select (cfg.transport) {
@@ -142,7 +142,7 @@
}
}

-   if (isvalue(ops)) {
+   if (not istemplatekind(ops, "omit")) {
timer T := 5.0;
T.start;
//T.timeout;

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15157
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I639ab6d0586174c0f20b93a53169f0aa254970fa
Gerrit-Change-Number: 15157
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange