Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
osmith has submitted this change and it was merged. (
https://gerrit.osmocom.org/11041 )
Change subject: debian-repo-install-test: UNKNOWN in --version?
..
debian-repo-install-test: UNKNOWN in --version?
With this patch, the debian-repo-install-test script checks if
the Osmocom programs as installed from the Debian repository have
"UNKNOWN" in their --version output.
Relates: OS#3555
Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 36 insertions(+), 13 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
osmith: Verified
diff --git a/debian-repo-install-test/testdata/repo-install-test.sh
b/debian-repo-install-test/testdata/repo-install-test.sh
index ea1c5fb..3ef88e8 100755
--- a/debian-repo-install-test/testdata/repo-install-test.sh
+++ b/debian-repo-install-test/testdata/repo-install-test.sh
@@ -44,25 +44,48 @@
apt install -y $(cat /data/osmocom_packages.txt)
}
+test_binaries_version() {
+ # Make sure --version runs and does not output UNKNOWN
+ failed=""
+ for program in $@; do
+ # Make sure it runs at all
+ $program --version
+
+ # Check for UNKNOWN
+ if $program --version | grep -q UNKNOWN; then
+ failed="$failed $program"
+ echo "ERROR: this program prints UNKNOWN in --version!"
+ fi
+ done
+
+ if [ -n "$failed" ]; then
+ echo "ERROR: the following program(s) print UNKNOWN in
--version:"
+ echo "$failed"
+ return 1
+ fi
+}
+
test_binaries() {
# Make sure the binaries are not broken (run -h or --version)
- osmo-bsc --version
- osmo-bts-trx --version
- osmo-bts-virtual --version
- osmo-gbproxy --version
- osmo-ggsn --version
osmo-gtphub -h
- osmo-hlr --version
- osmo-hlr-db-tool --version
- osmo-hnbgw --version
- osmo-mgw --version
- osmo-msc --version
- osmo-pcu --version
- osmo-sgsn --version
osmo-sip-connector -h
- osmo-stp --version
osmo-trx-uhd -h
osmo-trx-usrp1 -h
+
+ test_binaries_version \
+ osmo-bsc \
+ osmo-bts-trx \
+ osmo-bts-virtual \
+ osmo-gbproxy \
+ osmo-ggsn \
+ osmo-hlr \
+ osmo-hlr-db-tool \
+ osmo-hnbgw \
+ osmo-mgw \
+ osmo-msc \
+ osmo-pcu \
+ osmo-sgsn \
+ osmo-stp
}
finish() {
--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 2
Gerrit-Owner: osmith
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Neels Hofmeyr
Gerrit-Reviewer: osmith
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 ) Change subject: debian-repo-install-test: UNKNOWN in --version? .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 21 Sep 2018 08:19:26 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 ) Change subject: debian-repo-install-test: UNKNOWN in --version? .. Patch Set 2: Thanks for the review, updated. -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 21 Sep 2018 08:18:53 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11041 ) Change subject: debian-repo-install-test: UNKNOWN in --version? .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-Comment-Date: Fri, 21 Sep 2018 08:18:01 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
Hello Neels Hofmeyr, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11041 to look at the new patch set (#2). Change subject: debian-repo-install-test: UNKNOWN in --version? .. debian-repo-install-test: UNKNOWN in --version? With this patch, the debian-repo-install-test script checks if the Osmocom programs as installed from the Debian repository have "UNKNOWN" in their --version output. Relates: OS#3555 Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 --- M debian-repo-install-test/testdata/repo-install-test.sh 1 file changed, 36 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/41/11041/2 -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11041 ) Change subject: debian-repo-install-test: UNKNOWN in --version? .. Patch Set 1: Code-Review+2 (3 comments) https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh File debian-repo-install-test/testdata/repo-install-test.sh: https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@57 PS1, Line 57: echo "ERROR: this program had UNKNOWN in --version!" s/had/prints https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@62 PS1, Line 62: echo "ERROR: the following program(s) had UNKNOWN in --version:" s/had/print https://gerrit.osmocom.org/#/c/11041/1/debian-repo-install-test/testdata/repo-install-test.sh@73 PS1, Line 73: osmo-trx-usrp1 -h created issues that ask for --version to be added: OS#3576 OS#3577 OS#3578 -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 20 Sep 2018 15:38:18 + Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
osmith has posted comments on this change. ( https://gerrit.osmocom.org/11041 ) Change subject: debian-repo-install-test: UNKNOWN in --version? .. Patch Set 1: Verified+1 Tested locally with nightly and latest. Nightly does not have UNKNOWN in their version string, but latest does (how useful for testing this patch!). --- output from latest: + echo ERROR: the following program(s) had UNKNOWN in --version: ERROR: the following program(s) had UNKNOWN in --version: + echo osmo-bsc osmo-gbproxy osmo-hlr osmo-hlr-db-tool osmo-msc osmo-sgsn osmo-bsc osmo-gbproxy osmo-hlr osmo-hlr-db-tool osmo-msc osmo-sgsn -- To view, visit https://gerrit.osmocom.org/11041 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8 Gerrit-Change-Number: 11041 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: osmith Gerrit-Comment-Date: Thu, 20 Sep 2018 14:13:31 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in docker-playground[master]: debian-repo-install-test: UNKNOWN in --version?
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11041
Change subject: debian-repo-install-test: UNKNOWN in --version?
..
debian-repo-install-test: UNKNOWN in --version?
With this patch, the debian-repo-install-test script checks if
the Osmocom programs as installed from the Debian repository have
"UNKNOWN" in their --version output.
Relates: OS#3555
Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
---
M debian-repo-install-test/testdata/repo-install-test.sh
1 file changed, 36 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground
refs/changes/41/11041/1
diff --git a/debian-repo-install-test/testdata/repo-install-test.sh
b/debian-repo-install-test/testdata/repo-install-test.sh
index ea1c5fb..fdd0e3e 100755
--- a/debian-repo-install-test/testdata/repo-install-test.sh
+++ b/debian-repo-install-test/testdata/repo-install-test.sh
@@ -44,25 +44,48 @@
apt install -y $(cat /data/osmocom_packages.txt)
}
+test_binaries_version() {
+ # Make sure --version runs and does not output UNKNOWN
+ failed=""
+ for program in $@; do
+ # Make sure it runs at all
+ $program --version
+
+ # Check for UNKNOWN
+ if $program --version | grep -q UNKNOWN; then
+ failed="$failed $program"
+ echo "ERROR: this program had UNKNOWN in --version!"
+ fi
+ done
+
+ if [ -n "$failed" ]; then
+ echo "ERROR: the following program(s) had UNKNOWN in --version:"
+ echo "$failed"
+ return 1
+ fi
+}
+
test_binaries() {
# Make sure the binaries are not broken (run -h or --version)
- osmo-bsc --version
- osmo-bts-trx --version
- osmo-bts-virtual --version
- osmo-gbproxy --version
- osmo-ggsn --version
osmo-gtphub -h
- osmo-hlr --version
- osmo-hlr-db-tool --version
- osmo-hnbgw --version
- osmo-mgw --version
- osmo-msc --version
- osmo-pcu --version
- osmo-sgsn --version
osmo-sip-connector -h
- osmo-stp --version
osmo-trx-uhd -h
osmo-trx-usrp1 -h
+
+ test_binaries_version \
+ osmo-bsc \
+ osmo-bts-trx \
+ osmo-bts-virtual \
+ osmo-gbproxy \
+ osmo-ggsn \
+ osmo-hlr \
+ osmo-hlr-db-tool \
+ osmo-hnbgw \
+ osmo-mgw \
+ osmo-msc \
+ osmo-pcu \
+ osmo-sgsn \
+ osmo-stp
}
finish() {
--
To view, visit https://gerrit.osmocom.org/11041
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46f18dc86d3e257c772a6db8539027aad26e24a8
Gerrit-Change-Number: 11041
Gerrit-PatchSet: 1
Gerrit-Owner: osmith
