Change in gr-gsm[master]: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278
ptrkrysik has submitted this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/24089 ) Change subject: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278 .. tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278 Change-Id: Ib9ad4384388e480b8fa2f91e02359c85c749e802 --- M tests/scripts/decode.sh M tests/scripts/decrypt.sh 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: ptrkrysik: Looks good to me, approved; Verified diff --git a/tests/scripts/decode.sh b/tests/scripts/decode.sh index 1ec7bf8..402e818 100755 --- a/tests/scripts/decode.sh +++ b/tests/scripts/decode.sh @@ -25,7 +25,13 @@ cd "$TEST_DIR" || exit 1 head -c 600 $CAPFILE > $SHORTENED_CAPFILE +# VOLK_GENERIC=1 is a temporary workaround for the following VOLK's bug +# https://github.com/gnuradio/volk/pull/278 +# https://github.com/gnuradio/gnuradio/issues/2748 +export VOLK_GENERIC=1 + $RUNLINE | grep -A 99 "860933 1329237: 59 06 1a 8f 6d 18 10 80 00 00 00 00 00 00 00 00 00 00 00 78 b9 00 00" | tee $RESULT_OBTAINED + diff $RESULT_EXPECTED $RESULT_OBTAINED TEST_RESULT=$? diff --git a/tests/scripts/decrypt.sh b/tests/scripts/decrypt.sh index 5c33537..335528a 100755 --- a/tests/scripts/decrypt.sh +++ b/tests/scripts/decrypt.sh @@ -25,6 +25,11 @@ cd "$TEST_DIR" || exit 1 head -c -3700 $CAPFILE | head -c 3580 > $SHORTENED_CAPFILE +# VOLK_GENERIC=1 is a temporary workaround for the following VOLK's bug +# https://github.com/gnuradio/volk/pull/278 +# https://github.com/gnuradio/gnuradio/issues/2748 +export VOLK_GENERIC=1 + $RUNLINE | grep -A 99 "862210 1331352: 03 03 01 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b" | tee $RESULT_OBTAINED diff -u $RESULT_EXPECTED $RESULT_OBTAINED TEST_RESULT=$? -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ib9ad4384388e480b8fa2f91e02359c85c749e802 Gerrit-Change-Number: 24089 Gerrit-PatchSet: 1 Gerrit-Owner: ptrkrysik Gerrit-Reviewer: ptrkrysik Gerrit-Reviewer: vvvelichkov Gerrit-MessageType: merged
Change in gr-gsm[master]: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278
ptrkrysik has posted comments on this change. ( https://gerrit.osmocom.org/c/gr-gsm/+/24089 ) Change subject: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278 .. Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ib9ad4384388e480b8fa2f91e02359c85c749e802 Gerrit-Change-Number: 24089 Gerrit-PatchSet: 1 Gerrit-Owner: ptrkrysik Gerrit-Reviewer: ptrkrysik Gerrit-Reviewer: vvvelichkov Gerrit-Comment-Date: Mon, 03 May 2021 10:29:58 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in gr-gsm[master]: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278
Hello vvvelichkov, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/gr-gsm/+/24089 to review the following change. Change subject: tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278 .. tests: export VOLK_GENERIC=1 to workaround VOLK's bug 278 Change-Id: Ib9ad4384388e480b8fa2f91e02359c85c749e802 --- M tests/scripts/decode.sh M tests/scripts/decrypt.sh 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/gr-gsm refs/changes/89/24089/1 diff --git a/tests/scripts/decode.sh b/tests/scripts/decode.sh index 1ec7bf8..402e818 100755 --- a/tests/scripts/decode.sh +++ b/tests/scripts/decode.sh @@ -25,7 +25,13 @@ cd "$TEST_DIR" || exit 1 head -c 600 $CAPFILE > $SHORTENED_CAPFILE +# VOLK_GENERIC=1 is a temporary workaround for the following VOLK's bug +# https://github.com/gnuradio/volk/pull/278 +# https://github.com/gnuradio/gnuradio/issues/2748 +export VOLK_GENERIC=1 + $RUNLINE | grep -A 99 "860933 1329237: 59 06 1a 8f 6d 18 10 80 00 00 00 00 00 00 00 00 00 00 00 78 b9 00 00" | tee $RESULT_OBTAINED + diff $RESULT_EXPECTED $RESULT_OBTAINED TEST_RESULT=$? diff --git a/tests/scripts/decrypt.sh b/tests/scripts/decrypt.sh index 5c33537..335528a 100755 --- a/tests/scripts/decrypt.sh +++ b/tests/scripts/decrypt.sh @@ -25,6 +25,11 @@ cd "$TEST_DIR" || exit 1 head -c -3700 $CAPFILE | head -c 3580 > $SHORTENED_CAPFILE +# VOLK_GENERIC=1 is a temporary workaround for the following VOLK's bug +# https://github.com/gnuradio/volk/pull/278 +# https://github.com/gnuradio/gnuradio/issues/2748 +export VOLK_GENERIC=1 + $RUNLINE | grep -A 99 "862210 1331352: 03 03 01 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b 2b" | tee $RESULT_OBTAINED diff -u $RESULT_EXPECTED $RESULT_OBTAINED TEST_RESULT=$? -- To view, visit https://gerrit.osmocom.org/c/gr-gsm/+/24089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-Change-Id: Ib9ad4384388e480b8fa2f91e02359c85c749e802 Gerrit-Change-Number: 24089 Gerrit-PatchSet: 1 Gerrit-Owner: ptrkrysik Gerrit-Reviewer: vvvelichkov Gerrit-MessageType: newchange
