Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Thu, 06 Aug 2020 10:05:29 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. trau_frame: Add missing break statement in osmo_trau_frame_encode() Change-Id: I986781218a844e043b6206124696452b3afec7fd Closes: CID#211592 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 1159bb1..9c9baa7 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1249,6 +1249,7 @@ /* timing alignment may happen: increased space requirement */ if (n_bits < 2 * 20 * 8 - 1) return -ENOSPC; + break; case OSMO_TRAU8_DATA: case OSMO_TRAU8_OAM: if (n_bits < 1 * 20 * 8) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in libosmo-abis[master]: trau_frame: Add missing break statement in osmo_trau_frame_encode()
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19540 ) Change subject: trau_frame: Add missing break statement in osmo_trau_frame_encode() .. trau_frame: Add missing break statement in osmo_trau_frame_encode() Change-Id: I986781218a844e043b6206124696452b3afec7fd Closes: CID#211592 --- M src/trau/trau_frame.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/40/19540/1 diff --git a/src/trau/trau_frame.c b/src/trau/trau_frame.c index 1159bb1..9c9baa7 100644 --- a/src/trau/trau_frame.c +++ b/src/trau/trau_frame.c @@ -1249,6 +1249,7 @@ /* timing alignment may happen: increased space requirement */ if (n_bits < 2 * 20 * 8 - 1) return -ENOSPC; + break; case OSMO_TRAU8_DATA: case OSMO_TRAU8_OAM: if (n_bits < 1 * 20 * 8) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I986781218a844e043b6206124696452b3afec7fd Gerrit-Change-Number: 19540 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-MessageType: newchange