Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-18 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11708 )

Change subject: Log ip:port for created SS7 server
..


Patch Set 3: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
Gerrit-Change-Number: 11708
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 19 Nov 2018 05:49:51 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11708 )

Change subject: Log ip:port for created SS7 server
..

Log ip:port for created SS7 server

Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
---
M src/osmo_ss7.c
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 73f8127..6fb8180 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -23,7 +23,7 @@
 #include 
 #include 
 #include 
-
+#include 
 #include 
 #include 
 #include 
@@ -1829,6 +1829,9 @@
osmo_stream_srv_link_set_port(oxs->server, oxs->cfg.local.port);
osmo_stream_srv_link_set_proto(oxs->server, 
asp_proto_to_ip_proto(proto));

+   LOGP(DLSS7, LOGL_INFO, "Created %s server on %s:%" PRIu16 "\n",
+   get_value_string(osmo_ss7_asp_protocol_vals, proto), 
local_host, local_port);
+
oxs->inst = inst;
llist_add_tail(>list, >xua_servers);


--
To view, visit https://gerrit.osmocom.org/11708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
Gerrit-Change-Number: 11708
Gerrit-PatchSet: 4
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 


Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-18 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11708 )

Change subject: Log ip:port for created SS7 server
..


Set Ready For Review


--
To view, visit https://gerrit.osmocom.org/11708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
Gerrit-Change-Number: 11708
Gerrit-PatchSet: 3
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sun, 18 Nov 2018 21:44:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-12 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11708 )

Change subject: Log ip:port for created SS7 server
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/11708/2/src/osmo_ss7.c
File src/osmo_ss7.c:

https://gerrit.osmocom.org/#/c/11708/2/src/osmo_ss7.c@1828
PS2, Line 1828: LOGP(DLSS7, LOGL_INFO, "Created %s server on %s:%u\n",
inttypes.h
%u -> %" PRIu16"



--
To view, visit https://gerrit.osmocom.org/11708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
Gerrit-Change-Number: 11708
Gerrit-PatchSet: 2
Gerrit-Owner: Max 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Mon, 12 Nov 2018 09:21:46 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes


Change in libosmo-sccp[master]: Log ip:port for created SS7 server

2018-11-09 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/11708


Change subject: Log ip:port for created SS7 server
..

Log ip:port for created SS7 server

Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
---
M src/osmo_ss7.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/08/11708/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index c493672..e7cbd03 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1826,6 +1826,9 @@
osmo_stream_srv_link_set_port(oxs->server, oxs->cfg.local.port);
osmo_stream_srv_link_set_proto(oxs->server, 
asp_proto_to_ip_proto(proto));

+   LOGP(DLSS7, LOGL_INFO, "Created %s server on %s:%u\n",
+   get_value_string(osmo_ss7_asp_protocol_vals, proto), 
local_host, local_port);
+
oxs->inst = inst;
llist_add_tail(>list, >xua_servers);


--
To view, visit https://gerrit.osmocom.org/11708
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If2ae093175d64000490a2be31ecfea265ca3853d
Gerrit-Change-Number: 11708
Gerrit-PatchSet: 1
Gerrit-Owner: Max