Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
pespin has submitted this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )
Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..
ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
Similar to what we do with local address. Should fix creating the stream
when no remote address is provided on an ASP configured through VTY.
Related: OS#4260
Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
---
M src/osmo_ss7_vty.c
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
neels: Looks good to me, approved
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 35640df..1a246db 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1775,6 +1775,11 @@
asp->cfg.local.host[0] = NULL;
asp->cfg.local.host_cnt = 1;
}
+ /* If no remote addr was set */
+ if (!asp->cfg.remote.host_cnt) {
+ asp->cfg.remote.host[0] = "127.0.0.1";
+ asp->cfg.remote.host_cnt = 1;
+ }
osmo_ss7_asp_restart(asp);
vty->node = L_CS7_NODE;
vty->index = asp->inst;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 ) Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce Gerrit-Change-Number: 16011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: neels Gerrit-Comment-Date: Fri, 08 Nov 2019 14:54:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 ) Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce Gerrit-Change-Number: 16011 Gerrit-PatchSet: 1 Gerrit-Owner: pespin Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Comment-Date: Fri, 08 Nov 2019 14:20:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmo-sccp[master]: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/16011 )
Change subject: ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
..
ss7: Set ASP default remote addr to 127.0.0.1 if none set in VTY
Similar to what we do with local address. Should fix creating the stream
when no remote address is provided on an ASP configured through VTY.
Related: OS#4260
Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
---
M src/osmo_ss7_vty.c
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/11/16011/1
diff --git a/src/osmo_ss7_vty.c b/src/osmo_ss7_vty.c
index 35640df..1a246db 100644
--- a/src/osmo_ss7_vty.c
+++ b/src/osmo_ss7_vty.c
@@ -1775,6 +1775,11 @@
asp->cfg.local.host[0] = NULL;
asp->cfg.local.host_cnt = 1;
}
+ /* If no remote addr was set */
+ if (!asp->cfg.remote.host_cnt) {
+ asp->cfg.remote.host[0] = "127.0.0.1";
+ asp->cfg.remote.host_cnt = 1;
+ }
osmo_ss7_asp_restart(asp);
vty->node = L_CS7_NODE;
vty->index = asp->inst;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16011
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I33672e76a51a5d5a483906749d30e4c4e08b66ce
Gerrit-Change-Number: 16011
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
Gerrit-MessageType: newchange
