Change in libosmocore[master]: fix spelling in 'value_string' arrays: existAnt -> existEnt

2020-11-02 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20961 )

Change subject: fix spelling in 'value_string' arrays: existAnt -> existEnt
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 02 Nov 2020 09:45:08 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: fix spelling in 'value_string' arrays: existAnt -> existEnt

2020-11-02 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20961 )

Change subject: fix spelling in 'value_string' arrays: existAnt -> existEnt
..

fix spelling in 'value_string' arrays: existAnt -> existEnt

It could be that this spelling variant was originally used in the
specs., but now at least in 3GPP TS 44.018 they use 'existEnt'.

Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
---
M src/gsm/gsm0411_smr.c
M src/gsm/gsm48.c
M src/gsm/gsm_04_08_gprs.c
3 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c
index 02b4199..03cf005 100644
--- a/src/gsm/gsm0411_smr.c
+++ b/src/gsm/gsm0411_smr.c
@@ -131,7 +131,7 @@
{ GSM411_RP_CAUSE_INV_TRANS_REF, "Invalid Transaction Reference" },
{ GSM411_RP_CAUSE_SEMANT_INC_MSG, "Semantically Incorrect Message" },
{ GSM411_RP_CAUSE_INV_MAND_INF, "Invalid Mandatory Information" },
-   { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existant" },
+   { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existent" },
{ GSM411_RP_CAUSE_MSG_INCOMP_STATE, "Message incompatible with protocol 
state" },
{ GSM411_RP_CAUSE_IE_NOTEXIST, "Information Element not existing" },
{ GSM411_RP_CAUSE_PROTOCOL_ERR, "Protocol Error" },
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index eb1d055..fab7213 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -170,7 +170,7 @@
{ GSM48_RR_CAUSE_CALL_CLEARED,  "Call already cleared" },
{ GSM48_RR_CAUSE_SEMANT_INCORR, "Semantically incorrect 
message" },
{ GSM48_RR_CAUSE_INVALID_MAND_INF,  "Invalid mandatory information" 
},
-   { GSM48_RR_CAUSE_MSG_TYPE_N,"Message type non-existant or 
not implemented" },
+   { GSM48_RR_CAUSE_MSG_TYPE_N,"Message type non-existent or 
not implemented" },
{ GSM48_RR_CAUSE_MSG_TYPE_N_COMPAT, "Message type not compatible 
with protocol state" },
{ GSM48_RR_CAUSE_COND_IE_ERROR, "Conditional IE error" },
{ GSM48_RR_CAUSE_NO_CELL_ALLOC_A,   "No cell allocation available" 
},
diff --git a/src/gsm/gsm_04_08_gprs.c b/src/gsm/gsm_04_08_gprs.c
index 608fa8c..8032593 100644
--- a/src/gsm/gsm_04_08_gprs.c
+++ b/src/gsm/gsm_04_08_gprs.c
@@ -65,7 +65,7 @@
{ GMM_CAUSE_SEM_INCORR_MSG, "Semantically incorrect message" },
{ GMM_CAUSE_INV_MAND_INFO, "Invalid mandatory information" },
{ GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL,
-   "Message type non-existant or not implemented" },
+   "Message type non-existent or not implemented" },
{ GMM_CAUSE_MSGT_INCOMP_P_STATE,
"Message type not compatible with protocol state" },
{ GMM_CAUSE_IE_NOTEXIST_NOTIMPL,
@@ -105,7 +105,7 @@
{ GSM_CAUSE_SEM_INCORR_MSG, "Semantically incorrect message" },
{ GSM_CAUSE_INV_MAND_INFO, "Invalid mandatory information" },
{ GSM_CAUSE_MSGT_NOTEXIST_NOTIMPL,
-   "Message type non-existant or not implemented" },
+   "Message type non-existent or not implemented" },
{ GSM_CAUSE_MSGT_INCOMP_P_STATE,
"Message type not compatible with protocol state" },
{ GSM_CAUSE_IE_NOTEXIST_NOTIMPL,

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged

Change in libosmocore[master]: fix spelling in 'value_string' arrays: existAnt -> existEnt

2020-10-29 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20961 )

Change subject: fix spelling in 'value_string' arrays: existAnt -> existEnt
..


Patch Set 1: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Thu, 29 Oct 2020 11:27:04 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: fix spelling in 'value_string' arrays: existAnt -> existEnt

2020-10-29 Thread fixeria 
fixeria has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/20961 )


Change subject: fix spelling in 'value_string' arrays: existAnt -> existEnt
..

fix spelling in 'value_string' arrays: existAnt -> existEnt

It could be that this spelling variant was originally used in the
specs., but now at least in 3GPP TS 44.018 they use 'existEnt'.

Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
---
M src/gsm/gsm0411_smr.c
M src/gsm/gsm48.c
M src/gsm/gsm_04_08_gprs.c
3 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/61/20961/1

diff --git a/src/gsm/gsm0411_smr.c b/src/gsm/gsm0411_smr.c
index 02b4199..03cf005 100644
--- a/src/gsm/gsm0411_smr.c
+++ b/src/gsm/gsm0411_smr.c
@@ -131,7 +131,7 @@
{ GSM411_RP_CAUSE_INV_TRANS_REF, "Invalid Transaction Reference" },
{ GSM411_RP_CAUSE_SEMANT_INC_MSG, "Semantically Incorrect Message" },
{ GSM411_RP_CAUSE_INV_MAND_INF, "Invalid Mandatory Information" },
-   { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existant" },
+   { GSM411_RP_CAUSE_MSGTYPE_NOTEXIST, "Message Type non-existent" },
{ GSM411_RP_CAUSE_MSG_INCOMP_STATE, "Message incompatible with protocol 
state" },
{ GSM411_RP_CAUSE_IE_NOTEXIST, "Information Element not existing" },
{ GSM411_RP_CAUSE_PROTOCOL_ERR, "Protocol Error" },
diff --git a/src/gsm/gsm48.c b/src/gsm/gsm48.c
index eb1d055..fab7213 100644
--- a/src/gsm/gsm48.c
+++ b/src/gsm/gsm48.c
@@ -170,7 +170,7 @@
{ GSM48_RR_CAUSE_CALL_CLEARED,  "Call already cleared" },
{ GSM48_RR_CAUSE_SEMANT_INCORR, "Semantically incorrect 
message" },
{ GSM48_RR_CAUSE_INVALID_MAND_INF,  "Invalid mandatory information" 
},
-   { GSM48_RR_CAUSE_MSG_TYPE_N,"Message type non-existant or 
not implemented" },
+   { GSM48_RR_CAUSE_MSG_TYPE_N,"Message type non-existent or 
not implemented" },
{ GSM48_RR_CAUSE_MSG_TYPE_N_COMPAT, "Message type not compatible 
with protocol state" },
{ GSM48_RR_CAUSE_COND_IE_ERROR, "Conditional IE error" },
{ GSM48_RR_CAUSE_NO_CELL_ALLOC_A,   "No cell allocation available" 
},
diff --git a/src/gsm/gsm_04_08_gprs.c b/src/gsm/gsm_04_08_gprs.c
index 608fa8c..8032593 100644
--- a/src/gsm/gsm_04_08_gprs.c
+++ b/src/gsm/gsm_04_08_gprs.c
@@ -65,7 +65,7 @@
{ GMM_CAUSE_SEM_INCORR_MSG, "Semantically incorrect message" },
{ GMM_CAUSE_INV_MAND_INFO, "Invalid mandatory information" },
{ GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL,
-   "Message type non-existant or not implemented" },
+   "Message type non-existent or not implemented" },
{ GMM_CAUSE_MSGT_INCOMP_P_STATE,
"Message type not compatible with protocol state" },
{ GMM_CAUSE_IE_NOTEXIST_NOTIMPL,
@@ -105,7 +105,7 @@
{ GSM_CAUSE_SEM_INCORR_MSG, "Semantically incorrect message" },
{ GSM_CAUSE_INV_MAND_INFO, "Invalid mandatory information" },
{ GSM_CAUSE_MSGT_NOTEXIST_NOTIMPL,
-   "Message type non-existant or not implemented" },
+   "Message type non-existent or not implemented" },
{ GSM_CAUSE_MSGT_INCOMP_P_STATE,
"Message type not compatible with protocol state" },
{ GSM_CAUSE_IE_NOTEXIST_NOTIMPL,

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20961
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I847de910411f2edf7cc45b8c296b43e65fed5447
Gerrit-Change-Number: 20961
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria 
Gerrit-MessageType: newchange

Change in libosmocore[master]: fix spelling

2018-05-15 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9166 )

Change subject: fix spelling
..

fix spelling

Change-Id: I3ac92217f83279d5f987ab34eb18b2e6cb1c7812
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 5d2864f..b699080 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -316,7 +316,7 @@
GSM0808_CAUSE_REDUCE_LOAD_IN_SERVING_CELL   = 0x10,
GSM0808_CAUSE_TRAFFIC_LOAD_IN_TGT_HIGHER_THAN_IN_SRC_CELL   = 0x11,
GSM0808_CAUSE_RELOCATION_TRIGGERED  = 0x12,
-   GSM0808_CAUSE_REQUSTED_OPT_NOT_AUTHORISED   = 0x14,
+   GSM0808_CAUSE_REQUESTED_OPT_NOT_AUTHORISED  = 0x14,
GSM0808_CAUSE_ALT_CHAN_CONFIG_REQUESTED = 0x15,
GSM0808_CAUSE_RESP_TO_INT_HO_ENQ_MSG= 0x16,
GSM0808_CAUSE_INT_HO_ENQUIRY_REJECT = 0x17,
@@ -358,7 +358,7 @@
GSM0808_CAUSE_DTM_HO_INVALID_PS_IND = 0x56,
GSM0808_CAUSE_CALL_ID_ALREADY_ALLOC = 0x57,
GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC= 96,
-   GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTANT= 0x61,
+   GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTENT= 0x61,
GSM0808_CAUSE_DTM_HO_TIMER_EXPIRY   = 0x62,
 };

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index e6a581c..4743175 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -936,7 +936,7 @@
{ GSM0808_CAUSE_REDUCE_LOAD_IN_SERVING_CELL, "REDUCE LOAD IN SERVING 
CELL" },
{ GSM0808_CAUSE_TRAFFIC_LOAD_IN_TGT_HIGHER_THAN_IN_SRC_CELL, "TRAFFIC 
LOAD IN TGT HIGHER THAN IN SRC CELL" },
{ GSM0808_CAUSE_RELOCATION_TRIGGERED, "RELOCATION TRIGGERED" },
-   { GSM0808_CAUSE_REQUSTED_OPT_NOT_AUTHORISED, "REQUSTED OPT NOT 
AUTHORISED" },
+   { GSM0808_CAUSE_REQUESTED_OPT_NOT_AUTHORISED, "REQUESTED OPT NOT 
AUTHORISED" },
{ GSM0808_CAUSE_ALT_CHAN_CONFIG_REQUESTED, "ALT CHAN CONFIG REQUESTED" 
},
{ GSM0808_CAUSE_RESP_TO_INT_HO_ENQ_MSG, "RESP TO INT HO ENQ MSG" },
{ GSM0808_CAUSE_INT_HO_ENQUIRY_REJECT, "INT HO ENQUIRY REJECT" },
@@ -978,7 +978,7 @@
{ GSM0808_CAUSE_DTM_HO_INVALID_PS_IND, "DTM HO INVALID PS IND" },
{ GSM0808_CAUSE_CALL_ID_ALREADY_ALLOC, "CALL ID ALREADY ALLOC" },
{ GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC, "PROTOCOL ERROR 
BETWEEN BSS AND MSC" },
-   { GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTANT, "VGCS VBS CALL NON 
EXISTANT" },
+   { GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTENT, "VGCS VBS CALL NON 
EXISTENT" },
{ GSM0808_CAUSE_DTM_HO_TIMER_EXPIRY, "DTM HO TIMER EXPIRY" },
{ 0, NULL }
 };

--
To view, visit https://gerrit.osmocom.org/9166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ac92217f83279d5f987ab34eb18b2e6cb1c7812
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 2
Gerrit-Owner: Thorsten Alteholz 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in libosmocore[master]: fix spelling

2018-05-15 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9166 )

Change subject: fix spelling
..


Patch Set 1: Code-Review+2

the question is if anyone has already used the old / wrong spelling.  At least 
in the osmocom code base, the answer is no, so we should be safe to change it 
without adding a backwards-compatible #define.


--
To view, visit https://gerrit.osmocom.org/9166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3ac92217f83279d5f987ab34eb18b2e6cb1c7812
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 1
Gerrit-Owner: Thorsten Alteholz 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Tue, 15 May 2018 13:48:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in libosmocore[master]: fix spelling

2018-05-15 Thread Thorsten Alteholz 
Thorsten Alteholz has uploaded this change for review. ( 
https://gerrit.osmocom.org/9166


Change subject: fix spelling
..

fix spelling

Change-Id: I3ac92217f83279d5f987ab34eb18b2e6cb1c7812
---
M include/osmocom/gsm/protocol/gsm_08_08.h
M src/gsm/gsm0808.c
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/9166/1

diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h 
b/include/osmocom/gsm/protocol/gsm_08_08.h
index 5d2864f..b699080 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -316,7 +316,7 @@
GSM0808_CAUSE_REDUCE_LOAD_IN_SERVING_CELL   = 0x10,
GSM0808_CAUSE_TRAFFIC_LOAD_IN_TGT_HIGHER_THAN_IN_SRC_CELL   = 0x11,
GSM0808_CAUSE_RELOCATION_TRIGGERED  = 0x12,
-   GSM0808_CAUSE_REQUSTED_OPT_NOT_AUTHORISED   = 0x14,
+   GSM0808_CAUSE_REQUESTED_OPT_NOT_AUTHORISED  = 0x14,
GSM0808_CAUSE_ALT_CHAN_CONFIG_REQUESTED = 0x15,
GSM0808_CAUSE_RESP_TO_INT_HO_ENQ_MSG= 0x16,
GSM0808_CAUSE_INT_HO_ENQUIRY_REJECT = 0x17,
@@ -358,7 +358,7 @@
GSM0808_CAUSE_DTM_HO_INVALID_PS_IND = 0x56,
GSM0808_CAUSE_CALL_ID_ALREADY_ALLOC = 0x57,
GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC= 96,
-   GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTANT= 0x61,
+   GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTENT= 0x61,
GSM0808_CAUSE_DTM_HO_TIMER_EXPIRY   = 0x62,
 };

diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c
index e6a581c..4743175 100644
--- a/src/gsm/gsm0808.c
+++ b/src/gsm/gsm0808.c
@@ -936,7 +936,7 @@
{ GSM0808_CAUSE_REDUCE_LOAD_IN_SERVING_CELL, "REDUCE LOAD IN SERVING 
CELL" },
{ GSM0808_CAUSE_TRAFFIC_LOAD_IN_TGT_HIGHER_THAN_IN_SRC_CELL, "TRAFFIC 
LOAD IN TGT HIGHER THAN IN SRC CELL" },
{ GSM0808_CAUSE_RELOCATION_TRIGGERED, "RELOCATION TRIGGERED" },
-   { GSM0808_CAUSE_REQUSTED_OPT_NOT_AUTHORISED, "REQUSTED OPT NOT 
AUTHORISED" },
+   { GSM0808_CAUSE_REQUESTED_OPT_NOT_AUTHORISED, "REQUESTED OPT NOT 
AUTHORISED" },
{ GSM0808_CAUSE_ALT_CHAN_CONFIG_REQUESTED, "ALT CHAN CONFIG REQUESTED" 
},
{ GSM0808_CAUSE_RESP_TO_INT_HO_ENQ_MSG, "RESP TO INT HO ENQ MSG" },
{ GSM0808_CAUSE_INT_HO_ENQUIRY_REJECT, "INT HO ENQUIRY REJECT" },
@@ -978,7 +978,7 @@
{ GSM0808_CAUSE_DTM_HO_INVALID_PS_IND, "DTM HO INVALID PS IND" },
{ GSM0808_CAUSE_CALL_ID_ALREADY_ALLOC, "CALL ID ALREADY ALLOC" },
{ GSM0808_CAUSE_PROTOCOL_ERROR_BETWEEN_BSS_AND_MSC, "PROTOCOL ERROR 
BETWEEN BSS AND MSC" },
-   { GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTANT, "VGCS VBS CALL NON 
EXISTANT" },
+   { GSM0808_CAUSE_VGCS_VBS_CALL_NON_EXISTENT, "VGCS VBS CALL NON 
EXISTENT" },
{ GSM0808_CAUSE_DTM_HO_TIMER_EXPIRY, "DTM HO TIMER EXPIRY" },
{ 0, NULL }
 };

--
To view, visit https://gerrit.osmocom.org/9166
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3ac92217f83279d5f987ab34eb18b2e6cb1c7812
Gerrit-Change-Number: 9166
Gerrit-PatchSet: 1
Gerrit-Owner: Thorsten Alteholz