Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!
laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28128 )
Change subject: fsm_vty: use unsigned int when left-shifting 31 bits!
..
fsm_vty: use unsigned int when left-shifting 31 bits!
fsm_vty.c:64:8: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'
Change-Id: I637bce52fae947922cbb8642a0313d174c827422
---
M src/vty/fsm_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c
index 025d0d8..777d38c 100644
--- a/src/vty/fsm_vty.c
+++ b/src/vty/fsm_vty.c
@@ -61,7 +61,7 @@
if (fsm->event_names) {
for (evt_name = fsm->event_names; evt_name->str != NULL;
evt_name++) {
vty_out(vty, "%s Event %02u (0x%08x): '%s'%s", prefix,
evt_name->value,
- (1 << evt_name->value), evt_name->str,
VTY_NEWLINE);
+ (1U << evt_name->value), evt_name->str,
VTY_NEWLINE);
}
} else
vty_out(vty, "%s No event names are defined for this FSM!
Please fix!%s", prefix, VTY_NEWLINE);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422
Gerrit-Change-Number: 28128
Gerrit-PatchSet: 2
Gerrit-Owner: laforge
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
Gerrit-Reviewer: laforge
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!
Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28128 ) Change subject: fsm_vty: use unsigned int when left-shifting 31 bits! .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422 Gerrit-Change-Number: 28128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Comment-Date: Tue, 17 May 2022 00:56:09 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!
Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28128 ) Change subject: fsm_vty: use unsigned int when left-shifting 31 bits! .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422 Gerrit-Change-Number: 28128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Attention: laforge Gerrit-Comment-Date: Mon, 16 May 2022 20:46:40 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!
laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/libosmocore/+/28128 )
Change subject: fsm_vty: use unsigned int when left-shifting 31 bits!
..
fsm_vty: use unsigned int when left-shifting 31 bits!
fsm_vty.c:64:8: runtime error: left shift of 1 by 31 places cannot be
represented in type 'int'
Change-Id: I637bce52fae947922cbb8642a0313d174c827422
---
M src/vty/fsm_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/28/28128/1
diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c
index 025d0d8..777d38c 100644
--- a/src/vty/fsm_vty.c
+++ b/src/vty/fsm_vty.c
@@ -61,7 +61,7 @@
if (fsm->event_names) {
for (evt_name = fsm->event_names; evt_name->str != NULL;
evt_name++) {
vty_out(vty, "%s Event %02u (0x%08x): '%s'%s", prefix,
evt_name->value,
- (1 << evt_name->value), evt_name->str,
VTY_NEWLINE);
+ (1U << evt_name->value), evt_name->str,
VTY_NEWLINE);
}
} else
vty_out(vty, "%s No event names are defined for this FSM!
Please fix!%s", prefix, VTY_NEWLINE);
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422
Gerrit-Change-Number: 28128
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
Gerrit-MessageType: newchange
