Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

2021-06-06 Thread lynxis lazus 
lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24590 )


Change subject: gprs_ns2_sns: bss: set gss->family
..

gprs_ns2_sns: bss: set gss->family

gss->family (and gss->ip) was never set.
So IPv6 should have never worked.

Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote")
Related: OS#5036
Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/24590/1

diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index ec4bd87..588dd02 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1598,6 +1598,7 @@
gss->initial = llist_entry(gss->initial->list.next, 
struct sns_endpoint, list);
}

+   gss->family = gss->initial->saddr.u.sa.sa_family;
gss->reselection_running = false;
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_BSS_SIZE, 
nse->nsi->timeout[NS_TOUT_TSNS_PROV], 1);
break;

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-MessageType: newchange

Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

2021-06-07 Thread dexter 
dexter has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24590 )

Change subject: gprs_ns2_sns: bss: set gss->family
..


Patch Set 1: Code-Review+1

Looks good to me. I guess this used by the SGSN only, which we seem not to have 
any ipv6 tests for. Maybe Pau can also have a look at this.


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 08:14:37 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

2021-06-07 Thread pespin 
pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24590 )

Change subject: gprs_ns2_sns: bss: set gss->family
..


Patch Set 1: Code-Review+2

So we aren't testing IPv6 in TTCN3 SNS tests?


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 09:37:13 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

2021-06-07 Thread laforge 
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24590 )

Change subject: gprs_ns2_sns: bss: set gss->family
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-Comment-Date: Mon, 07 Jun 2021 12:41:41 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: gprs_ns2_sns: bss: set gss->family

2021-06-13 Thread laforge 
laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/24590 )

Change subject: gprs_ns2_sns: bss: set gss->family
..

gprs_ns2_sns: bss: set gss->family

gss->family (and gss->ip) was never set.
So IPv6 should have never worked.

Fixes: e769f5226be6 ("gprs_ns2_sns: rework IP-SNS initial remote")
Related: OS#5036
Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
---
M src/gb/gprs_ns2_sns.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  dexter: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gb/gprs_ns2_sns.c b/src/gb/gprs_ns2_sns.c
index 3f09054..367f77c 100644
--- a/src/gb/gprs_ns2_sns.c
+++ b/src/gb/gprs_ns2_sns.c
@@ -1600,6 +1600,7 @@
gss->initial = llist_entry(gss->initial->list.next, 
struct sns_endpoint, list);
}

+   gss->family = gss->initial->saddr.u.sa.sa_family;
gss->reselection_running = false;
osmo_fsm_inst_state_chg(fi, GPRS_SNS_ST_BSS_SIZE, 
nse->nsi->timeout[NS_TOUT_TSNS_PROV], 1);
break;

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24590
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4e39dc5c7f766a7040645ceb62afdf6a9cfad00f
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-Reviewer: laforge 
Gerrit-Reviewer: pespin 
Gerrit-MessageType: merged