Change in libosmocore[master]: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12666 ) Change subject: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/12666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 Gerrit-Change-Number: 12666 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 21 Jan 2019 16:34:48 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/12666 ) Change subject: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK .. gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK Add new define for the 14 digit IMEI without the Luhn checksum, as it is used in OsmoHLR. Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 --- M include/osmocom/gsm/protocol/gsm_23_003.h 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved osmith: Verified diff --git a/include/osmocom/gsm/protocol/gsm_23_003.h b/include/osmocom/gsm/protocol/gsm_23_003.h index ee697ff..babd0f4 100644 --- a/include/osmocom/gsm/protocol/gsm_23_003.h +++ b/include/osmocom/gsm/protocol/gsm_23_003.h @@ -24,6 +24,9 @@ GSM23003_IMEI_SNR_NUM_DIGITS + 1) #define GSM23003_IMEISV_NUM_DIGITS (GSM23003_IMEI_TAC_NUM_DIGITS + \ GSM23003_IMEI_SNR_NUM_DIGITS + 2) +/* IMEI without Luhn checksum */ +#define GSM23003_IMEI_NUM_DIGITS_NO_CHK(GSM23003_IMEI_TAC_NUM_DIGITS + \ +GSM23003_IMEI_SNR_NUM_DIGITS) /* Chapter 19.2 "epc.mnc000.mcc000.3gppnetwork.org" */ #define GSM23003_HOME_NETWORK_DOMAIN_LEN 33 -- To view, visit https://gerrit.osmocom.org/12666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 Gerrit-Change-Number: 12666 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
Change in libosmocore[master]: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12666 ) Change subject: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/12666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 Gerrit-Change-Number: 12666 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith Gerrit-Comment-Date: Mon, 21 Jan 2019 16:33:49 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK
Hello Vadim Yanitskiy, Max, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/12666 to look at the new patch set (#2). Change subject: gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK .. gsm_23_003.h: add GSM23003_IMEI_NUM_DIGITS_NO_CHK Add new define for the 14 digit IMEI without the Luhn checksum, as it is used in OsmoHLR. Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 --- M include/osmocom/gsm/protocol/gsm_23_003.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/66/12666/2 -- To view, visit https://gerrit.osmocom.org/12666 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I02b54cf01a674a1911c5c897fbec02240f88b521 Gerrit-Change-Number: 12666 Gerrit-PatchSet: 2 Gerrit-Owner: osmith Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
