Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. libosmogsm/gsup.c: fix error code in osmo_gsup_encode() Missing (unset) type of to be encoded message is not a memory allocation failure (-ENOMEM), this is definitely a mistake. Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f --- M src/gsm/gsup.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/gsup.c b/src/gsm/gsup.c index 9c2f817..18b3580 100644 --- a/src/gsm/gsup.c +++ b/src/gsm/gsup.c @@ -535,7 +535,7 @@ /* generic part */ if(!gsup_msg->message_type) - return -ENOMEM; + return -EINVAL; msgb_v_put(msg, gsup_msg->message_type); -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max
Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-Comment-Date: Sun, 21 Oct 2018 12:56:53 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()
Max has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. Patch Set 2: We can use __attribute__((warn_unused_result)) to force caller to check for return value. -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte Gerrit-Comment-Date: Sun, 21 Oct 2018 12:43:48 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11325 to look at the new patch set (#2). Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. libosmogsm/gsup.c: fix error code in osmo_gsup_encode() Missing (unset) type of to be encoded message is not a memory allocation failure (-ENOMEM), this is definitely a mistake. Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f --- M src/gsm/gsup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/11325/2 -- To view, visit https://gerrit.osmocom.org/11325 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibbac18e2b68b765c17c2bc959c4c085037953a7f Gerrit-Change-Number: 11325 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Max Gerrit-CC: Harald Welte
