Change in libosmocore[master]: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters

2021-04-03 Thread laforge 
laforge has abandoned this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22563 )

Change subject: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters
..


Abandoned
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22563
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadb4baee6d459e2db7b16a64a213164572774a2e
Gerrit-Change-Number: 22563
Gerrit-PatchSet: 4
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-MessageType: abandon

Change in libosmocore[master]: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters

2021-01-31 Thread lynxis lazus 
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22563 )

Change subject: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters
..


Patch Set 2: Code-Review-1


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22563
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadb4baee6d459e2db7b16a64a213164572774a2e
Gerrit-Change-Number: 22563
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 01 Feb 2021 02:19:27 +
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in libosmocore[master]: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters

2021-01-31 Thread lynxis lazus 
lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22563 )

Change subject: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters
..


Patch Set 2:

You can receive an invalid packet (wrong NSEI/wrong NSVCI) on a specific NSVC. 
The question is where do we want to track it?


--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22563
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadb4baee6d459e2db7b16a64a213164572774a2e
Gerrit-Change-Number: 22563
Gerrit-PatchSet: 2
Gerrit-Owner: laforge 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel 
Gerrit-Reviewer: lynxis lazus 
Gerrit-Comment-Date: Mon, 01 Feb 2021 01:09:52 +
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in libosmocore[master]: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters

2021-01-30 Thread laforge 
laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/libosmocore/+/22563 )


Change subject: ns2: remove "invalid NSEI" and "invalid NS-VCI" counters
..

ns2: remove "invalid NSEI" and "invalid NS-VCI" counters

Those counters don't make sense as per-NSVC counters.  They would
need to be introduced as per-NSE counters, if so desired.

Change-Id: Iadb4baee6d459e2db7b16a64a213164572774a2e
---
M src/gb/gprs_ns2.c
M src/gb/gprs_ns2_internal.h
2 files changed, 0 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/63/22563/1

diff --git a/src/gb/gprs_ns2.c b/src/gb/gprs_ns2.c
index f1d4da9..511c4e7 100644
--- a/src/gb/gprs_ns2.c
+++ b/src/gb/gprs_ns2.c
@@ -171,8 +171,6 @@
[NS_CTR_DEAD]   = { "dead", "NS-VC gone dead count  
   " },
[NS_CTR_REPLACED]   = { "replaced", "NS-VC replaced other 
count" },
[NS_CTR_NSEI_CHG]   = { "nsei-chg", "NS-VC changed NSEI 
count  " },
-   [NS_CTR_INV_VCI]= { "inv-nsvci","NS-VCI was invalid 
count  " },
-   [NS_CTR_INV_NSEI]   = { "inv-nsei", "NSEI was invalid count 
   " },
[NS_CTR_LOST_ALIVE] = { "lost:alive",   "ALIVE ACK missing 
count   " },
[NS_CTR_LOST_RESET] = { "lost:reset",   "RESET ACK missing 
count   " },
 };
diff --git a/src/gb/gprs_ns2_internal.h b/src/gb/gprs_ns2_internal.h
index e149767..0b264b6 100644
--- a/src/gb/gprs_ns2_internal.h
+++ b/src/gb/gprs_ns2_internal.h
@@ -97,8 +97,6 @@
NS_CTR_DEAD,
NS_CTR_REPLACED,
NS_CTR_NSEI_CHG,
-   NS_CTR_INV_VCI,
-   NS_CTR_INV_NSEI,
NS_CTR_LOST_ALIVE,
NS_CTR_LOST_RESET,
 };

--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/22563
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadb4baee6d459e2db7b16a64a213164572774a2e
Gerrit-Change-Number: 22563
Gerrit-PatchSet: 1
Gerrit-Owner: laforge 
Gerrit-MessageType: newchange