Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
lynxis lazus has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/19415 )
Change subject: socket: add osmo_sockaddr_cmp()
..
socket: add osmo_sockaddr_cmp()
Compare two osmo_sockaddr.
Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6
---
M include/osmocom/core/socket.h
M src/socket.c
2 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
pespin: Looks good to me, approved
daniel: Looks good to me, but someone else must approve
diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h
index 4441449..e417f42 100644
--- a/include/osmocom/core/socket.h
+++ b/include/osmocom/core/socket.h
@@ -113,5 +113,7 @@
int osmo_sock_local_ip(char *local_ip, const char *remote_ip);
+int osmo_sockaddr_cmp(struct osmo_sockaddr *a, struct osmo_sockaddr *b);
+
#endif /* (!EMBEDDED) */
/*! @} */
diff --git a/src/socket.c b/src/socket.c
index 6c06063..803af31 100644
--- a/src/socket.c
+++ b/src/socket.c
@@ -1662,6 +1662,35 @@
return 0;
}
+/*! Compare two osmo_sockaddr.
+ * \param[in] a
+ * \param[in] b
+ * \return 0 if a and b are equal. Otherwise it follows memcmp()
+ */
+int osmo_sockaddr_cmp(struct osmo_sockaddr *a, struct osmo_sockaddr *b)
+{
+ if (a == b)
+ return 0;
+ if (!a)
+ return 1;
+ if (!b)
+ return -1;
+
+ if (a->u.sa.sa_family != b->u.sa.sa_family) {
+ return OSMO_CMP(a->u.sa.sa_family, b->u.sa.sa_family);
+ }
+
+ switch (a->u.sa.sa_family) {
+ case AF_INET:
+ return memcmp(>u.sin, >u.sin, sizeof(struct sockaddr_in));
+ case AF_INET6:
+ return memcmp(>u.sin6, >u.sin6, sizeof(struct
sockaddr_in6));
+ default:
+ /* fallback to memcmp for remaining AF over the full
osmo_sockaddr length */
+ return memcmp(a, b, sizeof(struct osmo_sockaddr));
+ }
+}
+
#endif /* HAVE_SYS_SOCKET_H */
/*! @} */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6
Gerrit-Change-Number: 19415
Gerrit-PatchSet: 19
Gerrit-Owner: lynxis lazus
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
Gerrit-Reviewer: laforge
Gerrit-Reviewer: lynxis lazus
Gerrit-Reviewer: neels
Gerrit-Reviewer: pespin
Gerrit-MessageType: merged
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 04 Sep 2020 11:36:35 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 19: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 19 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 04 Sep 2020 07:38:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 18: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 18 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 02 Sep 2020 16:36:44 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19415 to look at the new patch set (#17). Change subject: socket: add osmo_sockaddr_cmp() .. socket: add osmo_sockaddr_cmp() Compare two osmo_sockaddr. Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/19415/17 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 17 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 16: (9 comments) https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1562 PS11, Line 1562: /*! Compare two osmo_sockaddr. Return 0 if they are same > "the same". End with a ".". Actually the \return is already below. Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1563 PS11, Line 1563: * \brief osmo_sockaddr_cmp > we use AUTO_BRIEF, so drop this \brief line Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1566 PS11, Line 1566: * \return 0 if a and b are equal. > the naming of "cmp" implies being able to use the return code for sorting. […] Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1570 PS11, Line 1570:if (!a && !b) > this could be just […] Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1573 PS11, Line 1573:return 1; > -1 Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1577 PS11, Line 1577:return 1; > return OSMO_CMP(a->.., b->.. […] Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1583 PS11, Line 1583: a->u.sin.sin_port == b->u.sin.sin_port); > cleaner, type wise, would be to return ? 0 : 1 […] Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1585 PS11, Line 1585:/* AF_INET6 usally not contain any padding */ > "does not" Done https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1588 PS11, Line 1588:/* fallback to memcmp for remaing AF */ > "remaining" Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 16 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 02 Sep 2020 16:31:24 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19415 to look at the new patch set (#15). Change subject: socket: add osmo_sockaddr_cmp() .. socket: add osmo_sockaddr_cmp() Compare two osmo_sockaddr. Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/19415/15 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
Hello pespin, neels, laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19415 to look at the new patch set (#14). Change subject: socket: add osmo_sockaddr_cmp() .. socket: add osmo_sockaddr_cmp() Compare two osmo_sockaddr. Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/19415/14 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 14 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 12: (what, why do i keep posting on an older patch set? sorry about that) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 27 Aug 2020 11:14:51 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 12: Code-Review-1 (10 comments) https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1562 PS11, Line 1562: /*! Compare two osmo_sockaddr. Return 0 if they are same "the same". End with a ".". Actually the \return is already below. https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1563 PS11, Line 1563: * \brief osmo_sockaddr_cmp we use AUTO_BRIEF, so drop this \brief line https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1566 PS11, Line 1566: * \return 0 if a and b are equal. the naming of "cmp" implies being able to use the return code for sorting. So please return 1 if a > b and -1 if a < b. If you don't want to do that, s/_cmp/_same https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1568 PS11, Line 1568: int osmo_sockaddr_cmp(struct osmo_sockaddr *a, struct osmo_sockaddr *b) > As usual, I see no point in checking and returning stuff for NULL pointers. > […] I strongly favor generic cmp functions being useful with NULL args as well, it's not much effort and gives a warm and comfortable peace of mind https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1570 PS11, Line 1570:if (!a && !b) this could be just if (a == b) return 0; https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1573 PS11, Line 1573:return 1; -1 https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1577 PS11, Line 1577:return 1; return OSMO_CMP(a->.., b->..) https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1583 PS11, Line 1583: a->u.sin.sin_port == b->u.sin.sin_port); cleaner, type wise, would be to return ? 0 : 1 not sure how to do proper cmp rc of -1/1 here... at least the port could use OSMO_CMP() https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1585 PS11, Line 1585:/* AF_INET6 usally not contain any padding */ "does not" https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1588 PS11, Line 1588:/* fallback to memcmp for remaing AF */ "remaining" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: neels Gerrit-Reviewer: pespin Gerrit-Comment-Date: Thu, 27 Aug 2020 11:14:20 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 11: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1568 PS11, Line 1568: int osmo_sockaddr_cmp(struct osmo_sockaddr *a, struct osmo_sockaddr *b) As usual, I see no point in checking and returning stuff for NULL pointers. What's the point comparing a sockaddr with NULL? Are we comparing apples and pears here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 17 Aug 2020 11:17:49 + Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 10: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 10 Aug 2020 20:13:51 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 10: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c@1589 PS7, Line 1589: /* fallback to memcmp for remaing AF */ : return memcmp(a, b, sizeof(struct osmo_sockaddr)); > Ack Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 10 Aug 2020 00:58:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19415 to look at the new patch set (#10). Change subject: socket: add osmo_sockaddr_cmp() .. socket: add osmo_sockaddr_cmp() Compare two osmo_sockaddr. Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/19415/10 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-MessageType: newpatchset
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 9: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/7/src/socket.c@1589 PS7, Line 1589: /* fallback to memcmp for remaing AF */ : return memcmp(a, b, sizeof(struct osmo_sockaddr)); > might be worth moving this into a "default:" clause of the switch statement > to clearly see it's thre […] Ack -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: lynxis lazus Gerrit-Comment-Date: Mon, 10 Aug 2020 00:03:00 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 ) Change subject: socket: add osmo_sockaddr_cmp() .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 03 Aug 2020 01:42:31 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in libosmocore[master]: socket: add osmo_sockaddr_cmp()
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/19415 to look at the new patch set (#8). Change subject: socket: add osmo_sockaddr_cmp() .. socket: add osmo_sockaddr_cmp() Compare two osmo_sockaddr. Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 --- M include/osmocom/core/socket.h M src/socket.c 2 files changed, 34 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/15/19415/8 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 8 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset
