Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11417 )

Change subject: vty.c: Set vty->fd to -1 after closing the FD
..

vty.c: Set vty->fd to -1 after closing the FD

Change-Id: I07d105f4a810dd809fbf6feb5c04e7410020c887
---
M src/vty/vty.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/vty/vty.c b/src/vty/vty.c
index ad53537..70f6811 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -221,8 +221,10 @@
vector_unset(vtyvec, vty->fd);

/* Close socket. */
-   if (vty->fd > 0)
+   if (vty->fd > 0) {
close(vty->fd);
+   vty->fd = -1;
+   }

if (vty->buf) {
talloc_free(vty->buf);

--
To view, visit https://gerrit.osmocom.org/11417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I07d105f4a810dd809fbf6feb5c04e7410020c887
Gerrit-Change-Number: 11417
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)


Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11417 )

Change subject: vty.c: Set vty->fd to -1 after closing the FD
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I07d105f4a810dd809fbf6feb5c04e7410020c887
Gerrit-Change-Number: 11417
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Comment-Date: Sun, 21 Oct 2018 11:44:36 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11417


Change subject: vty.c: Set vty->fd to -1 after closing the FD
..

vty.c: Set vty->fd to -1 after closing the FD

Change-Id: I07d105f4a810dd809fbf6feb5c04e7410020c887
---
M src/vty/vty.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/11417/1

diff --git a/src/vty/vty.c b/src/vty/vty.c
index ad53537..70f6811 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -221,8 +221,10 @@
vector_unset(vtyvec, vty->fd);

/* Close socket. */
-   if (vty->fd > 0)
+   if (vty->fd > 0) {
close(vty->fd);
+   vty->fd = -1;
+   }

if (vty->buf) {
talloc_free(vty->buf);

--
To view, visit https://gerrit.osmocom.org/11417
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I07d105f4a810dd809fbf6feb5c04e7410020c887
Gerrit-Change-Number: 11417
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte