Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

2018-09-14 Thread Pau Espin Pedrol 
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10956


Change subject: osmo-bsc: handle systemd and cfg files through autotools
..

osmo-bsc: handle systemd and cfg files through autotools

Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 5 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/56/10956/1

diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc 
b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
index d066a58..484a779 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
@@ -5,18 +5,14 @@

 DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif 
osmo-mgw"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-bsc/osmo-bsc.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find"
 SYSTEMD_PACKAGES = "osmo-bsc"

--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

2018-09-14 Thread Pau Espin Pedrol 
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 14 Sep 2018 16:21:24 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

2018-09-15 Thread Harald Welte 
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 15 Sep 2018 08:01:56 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in meta-telephony[laforge/nightly]: osmo-bsc: handle systemd and cfg files through autotools

2018-09-15 Thread Harald Welte 
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10956 )

Change subject: osmo-bsc: handle systemd and cfg files through autotools
..

osmo-bsc: handle systemd and cfg files through autotools

Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
---
M recipes-osmocom/osmo-bsc/osmo-bsc.inc
1 file changed, 5 insertions(+), 9 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-bsc/osmo-bsc.inc 
b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
index d066a58..484a779 100644
--- a/recipes-osmocom/osmo-bsc/osmo-bsc.inc
+++ b/recipes-osmocom/osmo-bsc/osmo-bsc.inc
@@ -5,18 +5,14 @@

 DEPENDS = "sqlite3 libpcap libosmocore libosmo-abis libosmo-sccp libosmo-netif 
osmo-mgw"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd

-do_install_append() {
-   install -d ${D}${systemd_system_unitdir}/
-   install -d ${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/doc/examples/osmo-bsc/osmo-bsc.cfg 
${D}${sysconfdir}/osmocom/
-
-   install -m 0644 ${S}/contrib/systemd/osmo-bsc.service 
${D}${systemd_system_unitdir}/
-}
+PACKAGECONFIG ??= "\
+${@bb.utils.filter('DISTRO_FEATURES', 'systemd', d)} \
+"
+PACKAGECONFIG[systemd] = 
"--with-systemdsystemunitdir=${systemd_system_unitdir},--without-systemdsystemunitdir"

 PACKAGES =+ "meas-utils ipaccess-utils bs11-utils abisip-find"
 SYSTEMD_PACKAGES = "osmo-bsc"

--
To view, visit https://gerrit.osmocom.org/10956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I752503f1ad7562ead50ec2bb7be49a958b9dc0f0
Gerrit-Change-Number: 10956
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol