Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..

osmo-msc: Depend on osmo-hlr

Since a while ago, osmo-msc depends on libosmo-gsup-client which is
provided by osmo-hlr.

Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Pau Espin Pedrol: Verified
  Harald Welte: Looks good to me, approved



diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index 06f5b10..e5364cd 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -3,9 +3,9 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw"
+DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: merged
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:32:06 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1:

> actually, I think you should first split the libosmo-gsup-client
 > sub-package and then depend on that?

No, afaik you DEPEND on recipes, not on packages. You RDEPEND on packages, but 
that's done automatically by OE in most cases (through linker analysis).


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:24:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: -Code-Review

actually, I think you should first split the libosmo-gsup-client sub-package 
and then depend on that?


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:15:23 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 15:14:50 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/10841 )

Change subject: osmo-msc: Depend on osmo-hlr
..


Patch Set 1: Verified+1


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: comment
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Fri, 07 Sep 2018 14:44:27 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in meta-telephony[laforge/nightly]: osmo-msc: Depend on osmo-hlr

2018-09-07 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( 
https://gerrit.osmocom.org/10841


Change subject: osmo-msc: Depend on osmo-hlr
..

osmo-msc: Depend on osmo-hlr

Since a while ago, osmo-msc depends on libosmo-gsup-client which is
provided by osmo-hlr.

Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
---
M recipes-osmocom/osmo-msc/osmo-msc.inc
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/41/10841/1

diff --git a/recipes-osmocom/osmo-msc/osmo-msc.inc 
b/recipes-osmocom/osmo-msc/osmo-msc.inc
index 06f5b10..e5364cd 100644
--- a/recipes-osmocom/osmo-msc/osmo-msc.inc
+++ b/recipes-osmocom/osmo-msc/osmo-msc.inc
@@ -3,9 +3,9 @@
 LICENSE = "AGPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=73f1eb20517c55bf9493b7dd6e480788"

-DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw"
+DEPENDS = "libdbi libosmocore libosmo-abis libosmo-sccp libosmo-netif osmo-mgw 
osmo-hlr"

-INC_PR="r0.${META_TELEPHONY_OSMO_INC}"
+INC_PR="r1.${META_TELEPHONY_OSMO_INC}"

 inherit autotools pkgconfig systemd


--
To view, visit https://gerrit.osmocom.org/10841
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66866d90b4e107d6d5a1bbb82e4ff16932d849d9
Gerrit-Change-Number: 10841
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol