Change in openbsc[master]: CTRL: remove boilerplate

2018-12-12 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/1576 )

Change subject: CTRL: remove boilerplate
..


Patch Set 5:

> Easiest to get rid of them is to just "Reply", so bear with me

You mean you've saved yourself 2 mouse clicks to publish instead of discard? In 
future, please try to choose slightly less easy solution to avoid spamming 
people - clicking couple of times is hardly a backbreaking effort.


--
To view, visit https://gerrit.osmocom.org/1576
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bcea0b4f4b8f535bef2b423f2013b8b4a218b5b
Gerrit-Change-Number: 1576
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Wed, 12 Dec 2018 10:06:09 +
Gerrit-HasComments: No
Gerrit-HasLabels: No


Change in openbsc[master]: CTRL: remove boilerplate

2018-12-11 Thread Neels Hofmeyr
Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/1576 )

Change subject: CTRL: remove boilerplate
..


Patch Set 5:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to 
get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/1576/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/1576/2//COMMIT_MSG@9
PS2, Line 9: Use CTRL_CMD_DEFINE_RO(), CTRL_CMD_DEFINE_WO() and
would be nice to have this line as the summary line above (without "where" of 
course)



--
To view, visit https://gerrit.osmocom.org/1576
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bcea0b4f4b8f535bef2b423f2013b8b4a218b5b
Gerrit-Change-Number: 1576
Gerrit-PatchSet: 5
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-Reviewer: Max 
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:12:03 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No