Change in osmo-bsc[master]: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23650 ) Change subject: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again .. [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again It's already being called in inp_sig_cb(), once the A-bis/OML link is established. There is no need to do this on the A-bis/RSL link establishment again. Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/23650/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 2b4224f..5426b1e 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -357,7 +357,6 @@ for (i = 0; i < ARRAY_SIZE(trx->ts); i++) { struct gsm_bts_trx_ts *ts = &trx->ts[i]; - generate_ma_for_ts(ts); OSMO_ASSERT(ts->fi); osmo_fsm_inst_dispatch(ts->fi, TS_EV_RSL_READY, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce Gerrit-Change-Number: 23650 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-bsc[master]: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23650 ) Change subject: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce Gerrit-Change-Number: 23650 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 12 Apr 2021 08:24:01 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23650 ) Change subject: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce Gerrit-Change-Number: 23650 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 12 Apr 2021 09:11:19 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23650 ) Change subject: [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again .. [hopping] bootstrap_rsl(): do not call generate_ma_for_ts() again It's already being called in inp_sig_cb(), once the A-bis/OML link is established. There is no need to do this on the A-bis/RSL link establishment again. Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index 2b4224f..5426b1e 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -357,7 +357,6 @@ for (i = 0; i < ARRAY_SIZE(trx->ts); i++) { struct gsm_bts_trx_ts *ts = &trx->ts[i]; - generate_ma_for_ts(ts); OSMO_ASSERT(ts->fi); osmo_fsm_inst_dispatch(ts->fi, TS_EV_RSL_READY, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23650 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I435018f439181cdd046ca99fe7e01ac85e226cce Gerrit-Change-Number: 23650 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged