Change in osmo-bsc[master]: [hopping] generate_ma_for_ts() returns no meaningful value
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23648 ) Change subject: [hopping] generate_ma_for_ts() returns no meaningful value .. [hopping] generate_ma_for_ts() returns no meaningful value Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/48/23648/1 diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index ec07410..6c7c275 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -256,7 +256,7 @@ } /* Produce a MA as specified in 10.5.2.21 */ -static int generate_ma_for_ts(struct gsm_bts_trx_ts *ts) +static void generate_ma_for_ts(struct gsm_bts_trx_ts *ts) { /* we have three bitvecs: the per-timeslot ARFCNs, the cell chan ARFCNs * and the MA */ @@ -271,7 +271,7 @@ memset(ma->data, 0, ma->data_len); if (!ts->hopping.enabled) - return 0; + return; /* count the number of ARFCNs in the cell channel allocation */ num_cell_arfcns = 0; @@ -303,8 +303,6 @@ else bitvec_set_bit_pos(ma, ma->cur_bit, 0); } - - return 0; } static void bootstrap_rsl(struct gsm_bts_trx *trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 Gerrit-Change-Number: 23648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-MessageType: newchange
Change in osmo-bsc[master]: [hopping] generate_ma_for_ts() returns no meaningful value
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23648 ) Change subject: [hopping] generate_ma_for_ts() returns no meaningful value .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 Gerrit-Change-Number: 23648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Wed, 07 Apr 2021 16:27:28 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: [hopping] generate_ma_for_ts() returns no meaningful value
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/23648 ) Change subject: [hopping] generate_ma_for_ts() returns no meaningful value .. [hopping] generate_ma_for_ts() returns no meaningful value Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 --- M src/osmo-bsc/osmo_bsc_main.c 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/osmo_bsc_main.c b/src/osmo-bsc/osmo_bsc_main.c index ec07410..6c7c275 100644 --- a/src/osmo-bsc/osmo_bsc_main.c +++ b/src/osmo-bsc/osmo_bsc_main.c @@ -256,7 +256,7 @@ } /* Produce a MA as specified in 10.5.2.21 */ -static int generate_ma_for_ts(struct gsm_bts_trx_ts *ts) +static void generate_ma_for_ts(struct gsm_bts_trx_ts *ts) { /* we have three bitvecs: the per-timeslot ARFCNs, the cell chan ARFCNs * and the MA */ @@ -271,7 +271,7 @@ memset(ma->data, 0, ma->data_len); if (!ts->hopping.enabled) - return 0; + return; /* count the number of ARFCNs in the cell channel allocation */ num_cell_arfcns = 0; @@ -303,8 +303,6 @@ else bitvec_set_bit_pos(ma, ma->cur_bit, 0); } - - return 0; } static void bootstrap_rsl(struct gsm_bts_trx *trx) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/23648 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic3ba3323459bba1336adb1f902cb2371edea1f71 Gerrit-Change-Number: 23648 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged