Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation
lynxis lazus has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-bsc/+/21451 )
Change subject: OML: sysmobts: add state to track feature negotiation
..
OML: sysmobts: add state to track feature negotiation
Add variables to track feature negotiation for sysmobts. In preparation
for the NSVC MO which need to check for IPv6 feature.
Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280
---
M include/osmocom/bsc/bts.h
M src/osmo-bsc/abis_nm.c
M src/osmo-bsc/bts_ipaccess_nanobts.c
3 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/21451/1
diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h
index 22839d6..de0994f 100644
--- a/include/osmocom/bsc/bts.h
+++ b/include/osmocom/bsc/bts.h
@@ -295,6 +295,8 @@
uint16_t bts_id;
uint32_t flags;
uint32_t rsl_ip;
+ bool feature_dynamic;
+ bool feature_negotiated;
} ip_access;
struct {
struct {
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 73dc2d0..dab5bb6 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -596,6 +596,8 @@
osmo_bts_has_feature(&bts->features, i),
osmo_bts_has_feature(&bts->model->features, i));
}
}
+
+ bts->ip_access.feature_negotiated = true;
}
/* Parse Attribute Response Info content for 3GPP TS 52.021 ยง9.4.28
Manufacturer Dependent State */
diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c
b/src/osmo-bsc/bts_ipaccess_nanobts.c
index f9dc8b3..32823bb 100644
--- a/src/osmo-bsc/bts_ipaccess_nanobts.c
+++ b/src/osmo-bsc/bts_ipaccess_nanobts.c
@@ -502,6 +502,11 @@
/* First of all, remove deferred drop if enabled */
osmo_timer_del(&bts->oml_drop_link_timer);
+ if (is_sysmobts_v2(bts)) {
+ bts->ip_access.feature_negotiated = false;
+ bts->ip_access.feature_dynamic = true;
+ }
+
if (!bts->oml_link)
return;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280
Gerrit-Change-Number: 21451
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus
Gerrit-MessageType: newchange
Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation
Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451 to look at the new patch set (#2). Change subject: OML: sysmobts: add state to track feature negotiation .. OML: sysmobts: add state to track feature negotiation Add variables to track feature negotiation for sysmobts. In preparation for the NSVC MO which need to check for IPv6 feature. Related: SYS#4915 OS#4870 Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bts_ipaccess_nanobts.c 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/51/21451/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280 Gerrit-Change-Number: 21451 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21451 ) Change subject: OML: sysmobts: add state to track feature negotiation .. Patch Set 2: (1 comment) If you plan me using this in a later commit please describe it better :P https://gerrit.osmocom.org/c/osmo-bsc/+/21451/2/include/osmocom/bsc/bts.h File include/osmocom/bsc/bts.h: https://gerrit.osmocom.org/c/osmo-bsc/+/21451/2/include/osmocom/bsc/bts.h@298 PS2, Line 298: bool feature_dynamic; Add some description of the meaning. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280 Gerrit-Change-Number: 21451 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 02 Dec 2020 13:02:19 + Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21451 ) Change subject: OML: sysmobts: add state to track feature negotiation .. Patch Set 2: Code-Review-1 This needs to be integrated into "BTS" and "Baseband Transceiver" NM object FSMs, for which "Get Attributes" is requested by BSC. Those flags hence should go in the respective mo structs. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280 Gerrit-Change-Number: 21451 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 02 Dec 2020 17:33:53 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: OML: sysmobts: add state to track feature negotiation
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21451 ) Change subject: OML: sysmobts: add state to track feature negotiation .. Patch Set 2: I'll take care of it when rebasing it on top of my work -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21451 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7c207eee0e331995ae04acec014fbd13d4d16280 Gerrit-Change-Number: 21451 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin Gerrit-Comment-Date: Wed, 02 Dec 2020 17:34:07 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
