Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10850 ) Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH channel .. cbch: Don't send cell-broadcast command on BTS without CBCH channel Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index e99029a..b1938e6 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -4240,6 +4240,10 @@ vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE); return CMD_WARNING; } + if (!gsm_bts_get_cbch(bts)) { + vty_out(vty, "%% BTS %d doesn't have a CBCH%s", bts_nr, VTY_NEWLINE); + return CMD_WARNING; + } rc = osmo_hexparse(argv[2], buf, sizeof(buf)); if (rc < 0 || rc > sizeof(buf)) { vty_out(vty, "Error parsing HEXSTRING%s", VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/10850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10850 ) Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH channel .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Sun, 09 Sep 2018 15:25:21 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: cbch: Don't send cell-broadcast command on BTS without CBCH channel
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/10850 Change subject: cbch: Don't send cell-broadcast command on BTS without CBCH channel .. cbch: Don't send cell-broadcast command on BTS without CBCH channel Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/10850/1 diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index e99029a..b1938e6 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -4240,6 +4240,10 @@ vty_out(vty, "%% No such BTS (%d)%s", bts_nr, VTY_NEWLINE); return CMD_WARNING; } + if (!gsm_bts_get_cbch(bts)) { + vty_out(vty, "%% BTS %d doesn't have a CBCH%s", bts_nr, VTY_NEWLINE); + return CMD_WARNING; + } rc = osmo_hexparse(argv[2], buf, sizeof(buf)); if (rc < 0 || rc > sizeof(buf)) { vty_out(vty, "Error parsing HEXSTRING%s", VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/10850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I83d6b0b3eafd83e2c0fbdec81d9677ff0118db92 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte