Change in osmo-bsc[master]: chan_alloc: Don't include CBCH channels in load computation
Harald Welte has uploaded this change for review. (
https://gerrit.osmocom.org/14152
Change subject: chan_alloc: Don't include CBCH channels in load computation
..
chan_alloc: Don't include CBCH channels in load computation
When displaying the channel (lchan) load, we are interested in the
dedicated channels as available for communication with mobile
stations. If CBCH is enabled, it "steals" one of the SDCCH slots,
so we have to exclude this channel from the count of available
dedicated channels.
Before this patch, A CBCH would show up as "in use" dedicated channel
(so both the total and the in_use count were incremented).
After this patch, neither "total" nor "use" are affected; The CBCH
slot is completely excluded from load statistics.
Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/14152/1
diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index 9c43414..7f0aa31 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -59,6 +59,10 @@
continue;
ts_for_each_lchan(lchan, ts) {
+ /* don't even count CBCH slots in total */
+ if (lchan->type == GSM_LCHAN_CBCH)
+ continue;
+
pl->total++;
switch (lchan->fi->state) {
--
To view, visit https://gerrit.osmocom.org/14152
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
Gerrit-Change-Number: 14152
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte
Change in osmo-bsc[master]: chan_alloc: Don't include CBCH channels in load computation
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/14152 ) Change subject: chan_alloc: Don't include CBCH channels in load computation .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/14152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0 Gerrit-Change-Number: 14152 Gerrit-PatchSet: 2 Gerrit-Owner: Harald Welte Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 24 May 2019 08:52:13 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: chan_alloc: Don't include CBCH channels in load computation
Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/14152 )
Change subject: chan_alloc: Don't include CBCH channels in load computation
..
chan_alloc: Don't include CBCH channels in load computation
When displaying the channel (lchan) load, we are interested in the
dedicated channels as available for communication with mobile
stations. If CBCH is enabled, it "steals" one of the SDCCH slots,
so we have to exclude this channel from the count of available
dedicated channels.
Before this patch, A CBCH would show up as "in use" dedicated channel
(so both the total and the in_use count were incremented).
After this patch, neither "total" nor "use" are affected; The CBCH
slot is completely excluded from load statistics.
Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
---
M src/osmo-bsc/chan_alloc.c
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/chan_alloc.c b/src/osmo-bsc/chan_alloc.c
index 9c43414..7f0aa31 100644
--- a/src/osmo-bsc/chan_alloc.c
+++ b/src/osmo-bsc/chan_alloc.c
@@ -59,6 +59,10 @@
continue;
ts_for_each_lchan(lchan, ts) {
+ /* don't even count CBCH slots in total */
+ if (lchan->type == GSM_LCHAN_CBCH)
+ continue;
+
pl->total++;
switch (lchan->fi->state) {
--
To view, visit https://gerrit.osmocom.org/14152
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I606962e4977f122ff05a2d4e756c04c7f38bdaa0
Gerrit-Change-Number: 14152
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte
Gerrit-Reviewer: Harald Welte
Gerrit-Reviewer: Jenkins Builder (102)
