Change in osmo-bsc[master]: codec_pref.c: Add comment in expected switch case without break
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10775 ) Change subject: codec_pref.c: Add comment in expected switch case without break .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568353f070f049003326306106dce89b35deb92f Gerrit-Change-Number: 10775 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Comment-Date: Fri, 07 Sep 2018 09:10:57 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: codec_pref.c: Add comment in expected switch case without break
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/10775 ) Change subject: codec_pref.c: Add comment in expected switch case without break .. codec_pref.c: Add comment in expected switch case without break Change-Id: I568353f070f049003326306106dce89b35deb92f --- M src/osmo-bsc/codec_pref.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index cbe8ef4..2a9be6e 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -44,6 +44,7 @@ break; case GSM0808_PERM_HR2: LOGP(DMSC, LOGL_FATAL, "Speech HR2 was never specified!\n"); + /* fall through */ default: LOGP(DMSC, LOGL_FATAL, "Unsupported permitted speech %s selected, " "assuming AMR as channel mode...\n", -- To view, visit https://gerrit.osmocom.org/10775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I568353f070f049003326306106dce89b35deb92f Gerrit-Change-Number: 10775 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102)
Change in osmo-bsc[master]: codec_pref.c: Add comment in expected switch case without break
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/10775 Change subject: codec_pref.c: Add comment in expected switch case without break .. codec_pref.c: Add comment in expected switch case without break Change-Id: I568353f070f049003326306106dce89b35deb92f --- M src/osmo-bsc/codec_pref.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/75/10775/1 diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index cbe8ef4..2a9be6e 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -44,6 +44,7 @@ break; case GSM0808_PERM_HR2: LOGP(DMSC, LOGL_FATAL, "Speech HR2 was never specified!\n"); + /* fall through */ default: LOGP(DMSC, LOGL_FATAL, "Unsupported permitted speech %s selected, " "assuming AMR as channel mode...\n", -- To view, visit https://gerrit.osmocom.org/10775 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I568353f070f049003326306106dce89b35deb92f Gerrit-Change-Number: 10775 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol
