Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. configure.ac: Require python3 for ext_tests The python scripts already use #!/usr/bin/env python3 so it was pure coincidence that the tests are working. Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index ed9b2cb..f1f17b8 100644 --- a/configure.ac +++ b/configure.ac @@ -154,9 +154,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) -if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) +if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 3 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: merged
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Mon, 09 Nov 2020 10:58:18 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 16:41:04 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 to look at the new patch set (#2). Change subject: configure.ac: Require python3 for ext_tests .. configure.ac: Require python3 for ext_tests The python scripts already use #!/usr/bin/env python3 so it was pure coincidence that the tests are working. Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/21060/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 2 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. Patch Set 1: > Patch Set 1: > > a bit more verbosity would be nice. Do the ext_tests actually work with > python3? If so, with which version? We generally consider debian8 as the > last supported platform, so if we require python3, then it needs to work with > that Right, forgot to mention: the python scripts are already executed with python3: #!/usr/bin/env python3 > Also, what about https://gerrit.osmocom.org/c/osmo-bsc/+/5661 ? can it be > abandoned? osmo-bsc commit e1f0844afbe14d2cfb7a5247deefff10bffb1a2f switched to python3 (everywhere but in configure.ac) so I think so, yeah. I don't know how / have the permissions to abandon that change, though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 16:00:35 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. Patch Set 1: a bit more verbosity would be nice. Do the ext_tests actually work with python3? If so, with which version? We generally consider debian8 as the last supported platform, so if we require python3, then it needs to work with that Also, what about https://gerrit.osmocom.org/c/osmo-bsc/+/5661 ? can it be abandoned? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 15:30:31 + Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Reviewer: pespin Gerrit-Comment-Date: Fri, 06 Nov 2020 14:41:39 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: configure.ac: Require python3 for ext_tests
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21060 ) Change subject: configure.ac: Require python3 for ext_tests .. configure.ac: Require python3 for ext_tests Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 --- M configure.ac 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/60/21060/1 diff --git a/configure.ac b/configure.ac index ed9b2cb..f1f17b8 100644 --- a/configure.ac +++ b/configure.ac @@ -154,9 +154,9 @@ [Include the VTY/CTRL tests in make check [default=no]]), [enable_ext_tests="$enableval"],[enable_ext_tests="no"]) if test "x$enable_ext_tests" = "xyes" ; then - AC_CHECK_PROG(PYTHON2_AVAIL,python2,yes) -if test "x$PYTHON2_AVAIL" != "xyes" ; then - AC_MSG_ERROR([Please install python2 to run the VTY/CTRL tests.]) + AC_CHECK_PROG(PYTHON3_AVAIL,python3,yes) +if test "x$PYTHON3_AVAIL" != "xyes" ; then + AC_MSG_ERROR([Please install python3 to run the VTY/CTRL tests.]) fi AC_CHECK_PROG(OSMOTESTEXT_CHECK,osmotestvty.py,yes) if test "x$OSMOTESTEXT_CHECK" != "xyes" ; then -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id5745d5ff5ff1072ccfbf9ad50b2d67f3ea95583 Gerrit-Change-Number: 21060 Gerrit-PatchSet: 1 Gerrit-Owner: daniel Gerrit-MessageType: newchange
