Change in osmo-bsc[master]: control.adoc: comment out fixme note
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note .. control.adoc: comment out fixme note The fixme note: "FIXME: add variables defined in src/ctrl/control_if.c?" is not directed at the reader of the manual. It should stay in the source, but it should not be visible in the pdf. Lets comment it out. Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 --- M doc/manuals/chapters/control.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 695dd80..09e828e 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -148,4 +148,4 @@ NOTE: The bsic-number () can also be set to "any" if no explcit bsic shall be given -FIXME: add variables defined in src/ctrl/control_if.c? +//FIXME: add variables defined in src/ctrl/control_if.c? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 2 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: merged
Change in osmo-bsc[master]: control.adoc: comment out fixme note
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-Comment-Date: Mon, 01 Nov 2021 12:06:15 + Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Change in osmo-bsc[master]: control.adoc: comment out fixme note
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/26052 ) Change subject: control.adoc: comment out fixme note .. control.adoc: comment out fixme note The fixme note: "FIXME: add variables defined in src/ctrl/control_if.c?" is not directed at the reader of the manual. It should stay in the source, but it should not be visible in the pdf. Lets comment it out. Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 --- M doc/manuals/chapters/control.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/52/26052/1 diff --git a/doc/manuals/chapters/control.adoc b/doc/manuals/chapters/control.adoc index 9193646..b57c31c 100644 --- a/doc/manuals/chapters/control.adoc +++ b/doc/manuals/chapters/control.adoc @@ -148,4 +148,4 @@ NOTE: The bsic-number () can also be set to "any" if no explcit bsic shall be given -FIXME: add variables defined in src/ctrl/control_if.c? +//FIXME: add variables defined in src/ctrl/control_if.c? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/26052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id68f53d18f0873af3c07a0ae52cd12bc94bc0b96 Gerrit-Change-Number: 26052 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-MessageType: newchange
