Change in osmo-bsc[master]: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

2018-05-17 Thread Neels Hofmeyr
Neels Hofmeyr has uploaded this change for review. ( 
https://gerrit.osmocom.org/9229


Change subject: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or
..

cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 1 insertion(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/9229/1

diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index c7181ac..862a761 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -460,8 +460,7 @@
TS_F_PDCH_ACTIVE =  0x1000,
TS_F_PDCH_ACT_PENDING = 0x2000,
TS_F_PDCH_DEACT_PENDING =   0x4000,
-   TS_F_PDCH_PENDING_MASK =0x6000 /*<
-   TS_F_PDCH_ACT_PENDING | TS_F_PDCH_DEACT_PENDING */
+   TS_F_PDCH_PENDING_MASK =(TS_F_PDCH_ACT_PENDING | 
TS_F_PDCH_DEACT_PENDING),
 } gsm_bts_trx_ts_flags;

 /* One Timeslot in a TRX */

--
To view, visit https://gerrit.osmocom.org/9229
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
Gerrit-Change-Number: 9229
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr 


Change in osmo-bsc[master]: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

2018-05-23 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9229 )

Change subject: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9229
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
Gerrit-Change-Number: 9229
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 23 May 2018 12:11:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-bsc[master]: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

2018-05-23 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9229 )

Change subject: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or
..


Patch Set 2: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9229
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
Gerrit-Change-Number: 9229
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Wed, 23 May 2018 16:02:47 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-bsc[master]: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

2018-05-23 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9229 )

Change subject: cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or
..

cosmetic: define TCH_F_PDCH_PENDING_MASK as actual bitwise or

Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
---
M include/osmocom/bsc/gsm_data.h
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved



diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index da5e87f..5ba4362 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -460,8 +460,7 @@
TS_F_PDCH_ACTIVE =  0x1000,
TS_F_PDCH_ACT_PENDING = 0x2000,
TS_F_PDCH_DEACT_PENDING =   0x4000,
-   TS_F_PDCH_PENDING_MASK =0x6000 /*<
-   TS_F_PDCH_ACT_PENDING | TS_F_PDCH_DEACT_PENDING */
+   TS_F_PDCH_PENDING_MASK =(TS_F_PDCH_ACT_PENDING | 
TS_F_PDCH_DEACT_PENDING),
 } gsm_bts_trx_ts_flags;

 /* One Timeslot in a TRX */

--
To view, visit https://gerrit.osmocom.org/9229
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5266d6e1ea0ea89c66fa481136c31e2f84bcb313
Gerrit-Change-Number: 9229
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy