Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Neels Hofmeyr has submitted this change and it was merged. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. gsm_data: remove unused struct member full_rate. Remove unused member gsm_subscriber_connection.user_plane.full_rate. It was forgotten to be removed in: commit 31f525e7560ad13e32cfc5e0b5f1862c0efcb991 Date Mon May 14 18:14:15 2018 +0200 "large refactoring: use FSMs for lchans; add inter-BSC HO" change-id I82e3f918295daa83274a4cf803f046979f284366 Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Neels Hofmeyr: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index e408ff9..5a922d1 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -269,9 +269,6 @@ * (The BTS side CI is handled by struct gsm_lchan and the lchan_fsm.) */ struct mgwep_ci *mgw_endpoint_ci_msc; - /* Channel rate flag requested by the MSC, FR=1, HR=0, Invalid=-1 */ - int full_rate; - /* Channel mode requested by the MSC (signalling or voice channel) */ enum gsm48_chan_mode chan_mode; -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Neels Hofmeyr Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-Comment-Date: Mon, 17 Sep 2018 12:55:44 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Neels Hofmeyr has uploaded a new patch set (#5) to the change originally created by dexter. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. gsm_data: remove unused struct member full_rate. Remove unused member gsm_subscriber_connection.user_plane.full_rate. It was forgotten to be removed in: commit 31f525e7560ad13e32cfc5e0b5f1862c0efcb991 Date Mon May 14 18:14:15 2018 +0200 "large refactoring: use FSMs for lchans; add inter-BSC HO" change-id I82e3f918295daa83274a4cf803f046979f284366 Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/10906/5 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 5 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-CC: Neels Hofmeyr
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-CC: Neels Hofmeyr Gerrit-Comment-Date: Mon, 17 Sep 2018 12:47:24 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Neels Hofmeyr has uploaded a new patch set (#3) to the change originally created by dexter. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. gsm_data: remove unused struct member full_rate. Remove unused member gsm_subscriber_connection.user_plane.full_rate. It was forgotten to be removed in: commit 31f525e7560ad13e32cfc5e0b5f1862c0efcb991 Date Mon May 14 18:14:15 2018 +0200 "large refactoring: use FSMs for lchans; add inter-BSC HO" Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/10906/3 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 3 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-CC: Neels Hofmeyr
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 1: > (1 comment) Presumably the problem with the abandoned struct members just slipped through while neels was working on the lchan FSM. I will ask him. Maybe he knows more about this. -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Assignee: Neels Hofmeyr Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: dexter Gerrit-CC: Neels Hofmeyr Gerrit-Comment-Date: Fri, 14 Sep 2018 17:37:18 + Gerrit-HasComments: No Gerrit-HasLabels: No
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10906/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/10906/1//COMMIT_MSG@10 PS1, Line 10: used anymore. Lets remove it. it would be good to reference the change-id which made it unused/abandoned. -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 13 Sep 2018 13:56:15 + Gerrit-HasComments: Yes Gerrit-HasLabels: No
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Thu, 13 Sep 2018 13:55:25 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10906 ) Change subject: gsm_data: remove unused struct member full_rate. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 1 Gerrit-Owner: dexter Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 12 Sep 2018 17:49:28 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: gsm_data: remove unused struct member full_rate.
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/10906 Change subject: gsm_data: remove unused struct member full_rate. .. gsm_data: remove unused struct member full_rate. The struct member full_rate in struct gsm_subscriber_connection is not used anymore. Lets remove it. Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 --- M include/osmocom/bsc/gsm_data.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/06/10906/1 diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index e408ff9..5a922d1 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -269,9 +269,6 @@ * (The BTS side CI is handled by struct gsm_lchan and the lchan_fsm.) */ struct mgwep_ci *mgw_endpoint_ci_msc; - /* Channel rate flag requested by the MSC, FR=1, HR=0, Invalid=-1 */ - int full_rate; - /* Channel mode requested by the MSC (signalling or voice channel) */ enum gsm48_chan_mode chan_mode; -- To view, visit https://gerrit.osmocom.org/10906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3a14efe0039ff4690e27e3b083eb23c1b2a616c3 Gerrit-Change-Number: 10906 Gerrit-PatchSet: 1 Gerrit-Owner: dexter
