Change in osmo-bsc[master]: handover_start_inter_bsc_in(): Uninitialized variable

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11398 )

Change subject: handover_start_inter_bsc_in(): Uninitialized variable
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/11398
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e5b164194855f78a266c1a4441730cc6c378d11
Gerrit-Change-Number: 11398
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Neels Hofmeyr 
Gerrit-Comment-Date: Sun, 21 Oct 2018 12:11:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes


Change in osmo-bsc[master]: handover_start_inter_bsc_in(): Uninitialized variable

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/11398 )

Change subject: handover_start_inter_bsc_in(): Uninitialized variable
..

handover_start_inter_bsc_in(): Uninitialized variable

This only afffects a log statement, so not really an issue.

Change-Id: I8e5b164194855f78a266c1a4441730cc6c378d11
Fixes: Coverity CID#188829
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 4286084..68230e1 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -522,7 +522,7 @@
struct handover_in_req *req = >inter_bsc_in;
int match_idx;
enum gsm48_chan_mode mode;
-   bool full_rate;
+   bool full_rate = false;
uint16_t s15_s0;
struct osmo_fsm_inst *fi;


--
To view, visit https://gerrit.osmocom.org/11398
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5b164194855f78a266c1a4441730cc6c378d11
Gerrit-Change-Number: 11398
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte 
Gerrit-Assignee: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder (102)
Gerrit-CC: Neels Hofmeyr 


Change in osmo-bsc[master]: handover_start_inter_bsc_in(): Uninitialized variable

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( 
https://gerrit.osmocom.org/11398


Change subject: handover_start_inter_bsc_in(): Uninitialized variable
..

handover_start_inter_bsc_in(): Uninitialized variable

This only afffects a log statement, so not really an issue.

Change-Id: I8e5b164194855f78a266c1a4441730cc6c378d11
Fixes: Coverity CID#188829
---
M src/osmo-bsc/handover_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/98/11398/1

diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c
index 4286084..68230e1 100644
--- a/src/osmo-bsc/handover_fsm.c
+++ b/src/osmo-bsc/handover_fsm.c
@@ -522,7 +522,7 @@
struct handover_in_req *req = >inter_bsc_in;
int match_idx;
enum gsm48_chan_mode mode;
-   bool full_rate;
+   bool full_rate = false;
uint16_t s15_s0;
struct osmo_fsm_inst *fi;


--
To view, visit https://gerrit.osmocom.org/11398
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e5b164194855f78a266c1a4441730cc6c378d11
Gerrit-Change-Number: 11398
Gerrit-PatchSet: 1
Gerrit-Owner: Harald Welte