Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP
osmith has submitted this change and it was merged. ( https://gerrit.osmocom.org/11538 ) Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP .. ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP Fixes: coverity scan CID#189459 Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Vadim Yanitskiy: Looks good to me, but someone else must approve Pau Espin Pedrol: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 40cabb8..1fffd89 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -494,7 +495,7 @@ return; entry->site_id = site_id; entry->bts_id = bts_id; - strncpy(entry->ip, ip, sizeof(entry->ip)); + osmo_strlcpy(entry->ip, ip, sizeof(entry->ip)); } /* Add to beginning with current timestamp */ -- To view, visit https://gerrit.osmocom.org/11538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 Gerrit-Change-Number: 11538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Reviewer: osmith
Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11538 ) Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 Gerrit-Change-Number: 11538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Jenkins Builder (102) Gerrit-Reviewer: Pau Espin Pedrol Gerrit-Reviewer: Vadim Yanitskiy Gerrit-Comment-Date: Wed, 31 Oct 2018 09:42:24 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11538 ) Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/11538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 Gerrit-Change-Number: 11538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith Gerrit-Reviewer: Vadim Yanitskiy Gerrit-CC: Jenkins Builder (102) Gerrit-Comment-Date: Wed, 31 Oct 2018 09:37:05 + Gerrit-HasComments: No Gerrit-HasLabels: Yes
Change in osmo-bsc[master]: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/11538 Change subject: ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP .. ipaccess_sign_link_reject: fix: use osmo_strlcpy() to safely copy IP Fixes: coverity scan CID#189459 Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 --- M src/osmo-bsc/bts_ipaccess_nanobts.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/38/11538/1 diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 40cabb8..1fffd89 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -32,6 +32,7 @@ #include #include #include +#include #include #include #include @@ -494,7 +495,7 @@ return; entry->site_id = site_id; entry->bts_id = bts_id; - strncpy(entry->ip, ip, sizeof(entry->ip)); + osmo_strlcpy(entry->ip, ip, sizeof(entry->ip)); } /* Add to beginning with current timestamp */ -- To view, visit https://gerrit.osmocom.org/11538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ib9c5e374b9c5c8f79eecf95c439a25b0f438e4e5 Gerrit-Change-Number: 11538 Gerrit-PatchSet: 1 Gerrit-Owner: osmith
